[PATCH] Re: instrumentName in StaffGroup
Am Freitag, 14. Januar 2011, um 20:56:22 schrieb Reinhold Kainhofer: From a user's point of view, if he sets an instrument name, he wants it to be shown, and if he doesn't set an instrument name, the engraver will not do anything, anyway. So, from that POV, the sane thing would be to add it to staff groups, too. Are there any objections from the other developers? If not, I'll prepare a patch. Okay, so here is a patch: http://codereview.appspot.com/4031043 Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: instrumentName in StaffGroup
2011/1/14 Reinhold Kainhofer reinh...@kainhofer.com: To be honest, I don't understand, why the Instrument_name_engraver is not added to all staff group contexts by default. It is a very simple engraver, so it would not induce much overhead. From a user's point of view, if he sets an instrument name, he wants it to be shown, and if he doesn't set an instrument name, the engraver will not do anything, anyway. So, from that POV, the sane thing would be to add it to staff groups, too. +1 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: instrumentName in StaffGroup
On 14 January 2011 20:56, Reinhold Kainhofer reinh...@kainhofer.com wrote:
To be honest, I don't understand, why the Instrument_name_engraver is not
added to all staff group contexts by default. It is a very simple engraver, so
it would not induce much overhead. And it does not have any side effects. On
the other hand, it happens regularly that you want a staff group to display an
instrument name, too.
I don't see any argument against adding the engraver also to all staff groups.
(I'm already doing that in my orchestrallily package, so I can tell from my
experience that I'm not running into any problem).
From a user's point of view, if he sets an instrument name, he wants it to be
shown, and if he doesn't set an instrument name, the engraver will not do
anything, anyway.
So, from that POV, the sane thing would be to add it to staff groups, too.
+1 too
Actually IIRC it was already asked as a request by some users (maybe it
was on the French user mailing list).
Are there any objections from the other developers?
Not an objection (and I'm not a developer) but I just ran into an odd
side-effect (bug?) while helping a user on the French user mailing list.
instrumentName of one staff group also affect (apply to) identical
_nested_ staff groups.
This is unexpected (at least for me, but I suppose for lambda users
as well).
\score {
\new StaffGroup \with {
instrumentName = Big
}
\new Staff {
c'1
}
\new StaffGroup \with {
% instrumentName = % need to be added, otherwise Big is
printed here too!
}
\new Staff {
c'1
}
\new Staff {
c'1
}
\layout {
\context {
\StaffGroup
\consists Instrument_name_engraver
}
}
}
Cheers,
Xavier
--
Xavier Scheuer x.sche...@gmail.com
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: instrumentName in StaffGroup
Am Freitag, 14. Januar 2011, um 13:16:34 schrieb Federico Bruni: I found the information, sorry for the noise: To add instrument names to other contexts (such as GrandStaff, ChoirStaff, or StaffGroup), Instrument_name_engraver must be added to that context. For details, see Modifying context plug-inshttp://lilypond.org/doc/v2.13/Documentation/notation/modifying-con text-plug_002dins . It's where it was expected to be: http://lilypond.org/doc/v2.13/Documentation/notation/writing-parts#instrume nt-names To be honest, I don't understand, why the Instrument_name_engraver is not added to all staff group contexts by default. It is a very simple engraver, so it would not induce much overhead. And it does not have any side effects. On the other hand, it happens regularly that you want a staff group to display an instrument name, too. I don't see any argument against adding the engraver also to all staff groups. (I'm already doing that in my orchestrallily package, so I can tell from my experience that I'm not running into any problem). From a user's point of view, if he sets an instrument name, he wants it to be shown, and if he doesn't set an instrument name, the engraver will not do anything, anyway. So, from that POV, the sane thing would be to add it to staff groups, too. Are there any objections from the other developers? If not, I'll prepare a patch. Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: instrumentName in StaffGroup
On Fri, Jan 14, 2011 at 08:56:22PM +0100, Reinhold Kainhofer wrote: To be honest, I don't understand, why the Instrument_name_engraver is not added to all staff group contexts by default. It is a very simple engraver, so it would not induce much overhead. Sounds good to me. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
