parser.yy et al: turn \partial and \skip into music functions. (issue 4969076)

2011-09-12 Thread n . puttock

LGTM.


http://codereview.appspot.com/4969076/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/4969076/diff/1/ly/music-functions-init.ly#newcode794
ly/music-functions-init.ly:794: Make a partial measure.
(_i Make a partial measure.)

indent

http://codereview.appspot.com/4969076/diff/1/ly/music-functions-init.ly#newcode908
ly/music-functions-init.ly:908: (make-music 'SkipMusic
indent

needs docstring

http://codereview.appspot.com/4969076/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: parser.yy et al: turn \partial and \skip into music functions. (issue 4969076)

2011-09-12 Thread bordage . bertrand

LGTM.
Is there any way to also move \time, \key, \repeat and \alternative from
the parser?
Bertrand

http://codereview.appspot.com/4969076/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: parser.yy et al: turn \partial and \skip into music functions. (issue 4969076)

2011-09-12 Thread David Kastrup
bordage.bertr...@gmail.com writes:

 LGTM.
 Is there any way to also move \time, \key, \repeat and \alternative
 from the parser?

\time has a weird syntax with optional assignment
\key can take a \default argument
\repeat only takes an _optional_ \alternative

So no.  I am not sure about other candidates.

 http://codereview.appspot.com/4969076/

Currently my accumulated patches are getting out of hand.  I'll be
flushing out about a dozen of them once the regtests complete.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: parser.yy et al: turn \partial and \skip into music functions. (issue 4969076)

2011-09-12 Thread dak


Pushed as 12449405eb89bb45d49d3dd3a37bdfcebda3ceaa.

http://codereview.appspot.com/4969076/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel