Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál 
> Pal, could you do that git pull, then send me git format-patch
> origin ?  Now that we have James' approval, let's push your latest
> patch.

attached; thanks!
p


0001-document-new-mensural-ligature-features.patch
Description: Binary data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe 
Benko,

-Original Message-
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org 
[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On Behalf Of 
Benko Pál
Sent: 02 February 2011 16:22
To: Graham Percival
Cc: pkx1...@gmail.com; re...@codereview.appspotmail.com; 
percival.music...@gmail.com; lilypond-devel@gnu.org
Subject: Re: regression tests for white mensural ligature enhancements 
(issue3989049)

>> > http://codereview.appspot.com/3989049/diff/3002/Documentation/notat
>> > ion/ancient.itely#newcode966
>> > Documentation/notation/ancient.itely:966: \[ d\longa Can we put 
>> > note durations for the first note of every new line (again as per 
>> > the CG)?
>>
>> I'm afraid I don't get this.  all first notes have duration, don't they?
>
> The first note on *every line*.

still confused, but a new idea struck me: the problem is not with that example, 
but with all other?  I hope I'll have time to do that in two days.

---

The CG asks that for every new line of music you put the note length of the 
first note of every measure that starts a new line, even though it is not 
technically needed.

That's all.

So for example

\override NoteHead #'style = #'blackpetrucci 
  a'8*4/3 a' 
  \override NoteHead #'style = #'petrucci 
  a'\longa

should be written

\override NoteHead #'style = #'blackpetrucci 
  a'8*4/3 a' % <-- note is only numbered on first instance of same line
  \override NoteHead #'style = #'petrucci 
  a'8\longa  % <-- note is numbered on first instance of next new line

Does this help?

James



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe 
Benko,

-Original Message-
From: Benkő Pál [mailto:benko@gmail.com] 
Sent: 02 February 2011 17:09
To: James Lowe
Cc: Graham Percival; lilypond-devel@gnu.org
Subject: Re: regression tests for white mensural ligature enhancements 
(issue3989049)


\longa is a duration; a'8\longa should be syntax error.
ancient music, in particular ligatures, work with durations longer than 1 - 
\breve, \longa and \maxima.

P

---

Ah I see; that shows you my ignorance of Ancient Music - I just assumed \longa 
forced a specific glyph, sorry. I'm not sure then in this case we can apply the 
same CG Policies. 

This is probably where the confusion came from.

So maybe there is nothing more to do and it all LGTM!

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Graham Percival 
On Wed, Feb 02, 2011 at 12:19:58PM +, James Lowe wrote:
> On Mon, Jan 31, 2011 at 11:17:46AM +, pkx1...@gmail.com wrote:
> >> Just some minor syntax changes to make it read better. I hope no one 
> >> is offended.
> 
> >Not offended, but unfortunately I already pushed it.  Could you make these 
> >changes to git?
> 
> No problem, I'll do that.

Actually, if Pal did a git pull before starting his editing, he
should already have a patch.

Pal, could you do that git pull, then send me git format-patch
origin ?  Now that we have James' approval, let's push your latest
patch.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál 
hi James,

> The CG asks that for every new line of music you put the note length
> of the first note of every measure that starts a new line,
> even though it is not technically needed.
>
> That's all.
>
> So for example
>
> \override NoteHead #'style = #'blackpetrucci
>  a'8*4/3 a'
>  \override NoteHead #'style = #'petrucci
>  a'\longa
>
> should be written
>
> \override NoteHead #'style = #'blackpetrucci
>  a'8*4/3 a' % <-- note is only numbered on first instance of same line
>  \override NoteHead #'style = #'petrucci
>  a'8\longa  % <-- note is numbered on first instance of next new line
>
> Does this help?

\longa is a duration; a'8\longa should be syntax error.
ancient music, in particular ligatures, work with durations
longer than 1 - \breve, \longa and \maxima.

p

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread pkx166h 

Thanks, that all looks good.


http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál 
>> > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966
>> > Documentation/notation/ancient.itely:966: \[ d\longa
>> > Can we put note durations for the first note of every new line (again as
>> > per the CG)?
>>
>> I'm afraid I don't get this.  all first notes have duration, don't they?
>
> The first note on *every line*.

still confused, but a new idea struck me: the problem is
not with that example, but with all other?  I hope I'll have
time to do that in two days.

p

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe 
Hello,

-Original Message-
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org 
[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On Behalf Of 
Graham Percival
Sent: 01 February 2011 19:21
To: benko@gmail.com; percival.music...@gmail.com; pkx1...@gmail.com; 
lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Subject: Re: regression tests for white mensural ligature enhancements 
(issue3989049)

On Mon, Jan 31, 2011 at 11:17:46AM +, pkx1...@gmail.com wrote:
>> Just some minor syntax changes to make it read better. I hope no one 
>> is offended.

>Not offended, but unfortunately I already pushed it.  Could you make these 
>changes to git?


No problem, I'll do that.


>I don't want to slow down code development by asking non-English speakers to 
>revise text a lot.  As long as the doc team can understand it, I think it's 
>best >for programmers to be programming.

Absolutely, as long as no one feels belittled by these types of corrections 
suggested. I can easily go back afterwards and tidy up.


>> Documentation/notation/ancient.itely:500:
>> General: There is an inconsistency using 'notehead' vs 'note head', so 
>> we need to pick one and stick with it. There is nothing in the CG 
>> (yet) and so we could make a policy if someone has a strong opinion on this.

>gperciva@futoi:~/src/lilypond/Documentation/contributor$ grep notehead * 
>doc-work.itexi:@emph{Note head} NOT notehead.

>that seems like a pretty clear policy.  I didn't check this in the patch, 
>though.

Yes that is clear. Not sure how I missed that, sorry. I'll make the changes in 
the patch for this accordingly.

James




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Graham Percival 
On Tue, Feb 01, 2011 at 10:33:17PM +0100, Benkő Pál wrote:
> 2011/1/31  :
> > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966
> > Documentation/notation/ancient.itely:966: \[ d\longa
> > Can we put note durations for the first note of every new line (again as
> > per the CG)?
> 
> I'm afraid I don't get this.  all first notes have duration, don't they?

The first note on *every line*.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Benkő Pál 
(I don't know what happened to my reply, trying again.)

2011/1/31  :
> Just some minor syntax changes to make it read better. I hope no one is
> offended.

on the contrary!

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely
> File Documentation/notation/ancient.itely (left):
>
> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#oldcode500
> Documentation/notation/ancient.itely:500:
> General: There is an inconsistency using 'notehead' vs 'note head', so
> we need to pick one and stick with it. There is nothing in the CG (yet)
> and so we could make a policy if someone has a strong opinion on this.

done.

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely
> File Documentation/notation/ancient.itely (right):
>
> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode682
> Documentation/notation/ancient.itely:682: The @code{blackpetrucci} style
> gives noteheads usable in black
> "The @code{blackpetrucci} style produces ..."

done.

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode687
> Documentation/notation/ancient.itely:687: can be different if coloratio
> is used e.g. to notate triplets).
> "Because note head style does not influence flag count, a semiminima
> should be notated as @code{a8*2} not @code{a4) otherwise it will look
> like a minima."
>
> Then start a new para with no parenthesis:
>
> "The multiplyer can be differerent..."

modified, but not exactly this way.  I wanted the multiplyer sentence
refer to the blackpetrucci section, not to the semipetrucci one.

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode813
> Documentation/notation/ancient.itely:813: using pitched rests.
> "Longa rests are not grouped automatically so have to be done manually
> by "

done.

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode942
> Documentation/notation/ancient.itely:942: property @code{flexa-width}.
> The length of a flexa can be set by the note head property
> @code{flexa-width}.

done.

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966
> Documentation/notation/ancient.itely:966: \[ d\longa
> Can we put note durations for the first note of every new line (again as
> per the CG)?

I'm afraid I don't get this.  all first notes have duration, don't they?

> http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode1014
> Documentation/notation/ancient.itely:1014: Accidentals may collide with
> previous notes.
> Can we also suggest (if possible) any useful ways to avoid this or tell
> the user how they can workaround this - for instance using some 'hack'
> or spacing parameter - maybe even reference another section if it is
> useful. I just feel that stating this without a possible workaround is
> not as  helpful as we could be, even if it is informative.

I'm afraid (based on the horrible horizontal spacing around ligatures)
that such a workaround is not possible.  fortunately this situation is
very rare.

http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread benko . pal 

sorry Graham; next time I'll try to remember to open a new issue after
pushing.

p

http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-01 Thread Graham Percival 
On Mon, Jan 31, 2011 at 11:17:46AM +, pkx1...@gmail.com wrote:
> Just some minor syntax changes to make it read better. I hope no one is
> offended.

Not offended, but unfortunately I already pushed it.  Could you
make these changes to git?

I don't want to slow down code development by asking non-English
speakers to revise text a lot.  As long as the doc team can
understand it, I think it's best for programmers to be
programming.

> Documentation/notation/ancient.itely:500:
> General: There is an inconsistency using 'notehead' vs 'note head', so
> we need to pick one and stick with it. There is nothing in the CG (yet)
> and so we could make a policy if someone has a strong opinion on this.

gperciva@futoi:~/src/lilypond/Documentation/contributor$ grep
notehead *
doc-work.itexi:@emph{Note head} NOT notehead.

that seems like a pretty clear policy.  I didn't check this in the
patch, though.


Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-01-31 Thread pkx166h 

Just some minor syntax changes to make it read better. I hope no one is
offended.


http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (left):

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#oldcode500
Documentation/notation/ancient.itely:500:
General: There is an inconsistency using 'notehead' vs 'note head', so
we need to pick one and stick with it. There is nothing in the CG (yet)
and so we could make a policy if someone has a strong opinion on this.

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode682
Documentation/notation/ancient.itely:682: The @code{blackpetrucci} style
gives noteheads usable in black
"The @code{blackpetrucci} style produces ..."

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode687
Documentation/notation/ancient.itely:687: can be different if coloratio
is used e.g. to notate triplets).
"Because note head style does not influence flag count, a semiminima
should be notated as @code{a8*2} not @code{a4) otherwise it will look
like a minima."

Then start a new para with no parenthesis:

"The multiplyer can be differerent..."

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode813
Documentation/notation/ancient.itely:813: using pitched rests.
"Longa rests are not grouped automatically so have to be done manually
by "

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode942
Documentation/notation/ancient.itely:942: property @code{flexa-width}.
The length of a flexa can be set by the note head property
@code{flexa-width}.

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966
Documentation/notation/ancient.itely:966: \[ d\longa
Can we put note durations for the first note of every new line (again as
per the CG)?

http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode1014
Documentation/notation/ancient.itely:1014: Accidentals may collide with
previous notes.
Can we also suggest (if possible) any useful ways to avoid this or tell
the user how they can workaround this - for instance using some 'hack'
or spacing parameter - maybe even reference another section if it is
useful. I just feel that stating this without a possible workaround is
not as  helpful as we could be, even if it is informative.

http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-01-30 Thread percival . music . ca 

Looks good enough to me -- it doesn't completely match our doc policies,
but the whole Ancient music doesn't follow them either, and fixing that
is a job for documentation writers, not programmers.

Please send me a git format-patch origin  for this.  (also, please read
the latest docs for git-cl in the CG, especially the "resetting git-cl"
part)



http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-01-29 Thread Benkő Pál 
> LGTM; please send me a git-format origin    patch and I'll push it.

thanks!
p


0001-regtest-and-changes-for-mensural-ligature-improvemen.patch
Description: Binary data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-01-29 Thread percival . music . ca 

On 2011/01/29 14:07:20, benko.pal wrote:

and a try at Changes.


LGTM; please send me a git-format originpatch and I'll push it.

http://codereview.appspot.com/3989049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

regression tests for white mensural ligature enhancements (issue3989049)

2011-01-29 Thread benko . pal 

Reviewers: ,

Message:
and a try at Changes.

Description:
enhance ligature test with new features

Please review this at http://codereview.appspot.com/3989049/

Affected files:
  M Documentation/changes.tely
  M input/regression/mensural-ligatures.ly



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel