Re: source for Patchy the autobot
On Sat, Oct 29, 2011 at 08:30:07PM +0200, m...@apollinemike.com wrote: > On Oct 29, 2011, at 6:01 PM, Graham Percival wrote: > > > 2) I don't have a fast enough computer to want to sit through a > > doc rebuild for every patch > > I may be able to get a dedicated server for Patchy in the next year or so - > I'll keep you posted. James already has an exteremely computer. That's not an issue. The only problem is testing and reliability. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: source for Patchy the autobot
On Oct 29, 2011, at 6:01 PM, Graham Percival wrote: > > 2) I don't have a fast enough computer to want to sit through a > doc rebuild for every patch > I may be able to get a dedicated server for Patchy in the next year or so - I'll keep you posted. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: source for Patchy the autobot
On Sat, Oct 29, 2011 at 03:38:27PM +0200, m...@apollinemike.com wrote: > I'll have time in early 2012 to work on Patchy in more detail, > but there is one contribution that I can make right away. I > thought that patchy did a full doc build (BUILD_ALL_DOCS = > True), but the most recent problem with my in-notes patch leads > me to believe that she doesn't. I've decided to use the male pronoun for Patchy, since Vivi is a girl and I don't want people to think I have a fixation on virtual little girls. (as an anime and vocaloid geek, of couse I actually _do_, but I try not to make it terribly obvious) Anyway, Patchy doesn't do a doc build for patches because of a combation of 1) patch handling is not in a cronjob yet (he needs more testing) 2) I don't have a fast enough computer to want to sit through a doc rebuild for every patch As a result, right now Patchy only does a full doc build for the dev/staging merge. > Do you have any intuition as to > how Patchy may be fine tuned to catch problems in the > reg-tests/docs? I'd gladly spend the hour necessary to write > that Python code! Best thing right now is testing + error-proofing Patchy. Code review would help; it's the best single method of catching bugs: http://kev.inburke.com/kevin/the-best-ways-to-find-bugs-in-your-code/ look at Patchy source, assume that everything I wrote is flawed, and send patches (or just push fixes) for those flaws. once Patchy is tested a bit more, I'll put him in a cronjob (so my computer can be busy with that when I'm not there), and once he's tested even more, I'll offload him to James. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: source for Patchy the autobot
"m...@apollinemike.com" writes: > On Oct 27, 2011, at 11:55 AM, Graham Percival wrote: > >> Again, it would be great if somebody with more patience and/or >> pride in their work could take over Patchy. As an incentive, you >> don't need to deal with our review process. I'll hand git push >> ability for that repo out to anybody; just hack away and push >> without any concerns for code style or readability or reviews or >> whatever. >> >> - Graham >> > > Hey Graham, > > I'll have time in early 2012 to work on Patchy in more detail, but > there is one contribution that I can make right away. I thought that > patchy did a full doc build (BUILD_ALL_DOCS = True), but the most > recent problem with my in-notes patch leads me to believe that she > doesn't. Why? She never admitted that patch into master. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: source for Patchy the autobot
On Oct 27, 2011, at 11:55 AM, Graham Percival wrote: > Again, it would be great if somebody with more patience and/or > pride in their work could take over Patchy. As an incentive, you > don't need to deal with our review process. I'll hand git push > ability for that repo out to anybody; just hack away and push > without any concerns for code style or readability or reviews or > whatever. > > - Graham > Hey Graham, I'll have time in early 2012 to work on Patchy in more detail, but there is one contribution that I can make right away. I thought that patchy did a full doc build (BUILD_ALL_DOCS = True), but the most recent problem with my in-notes patch leads me to believe that she doesn't. Do you have any intuition as to how Patchy may be fine tuned to catch problems in the reg-tests/docs? I'd gladly spend the hour necessary to write that Python code! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
source for Patchy the autobot
In order to de-mystify Patchy, I'm going to point people at the
source:
https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py
As you can see, it's pretty ugly python, but it works. Or at
least, the testing-patches parts work. I haven't checked
dev/staging since there's nothing there at the moment, but I'll do
that tomorrow morning.
If you look at that code and think "yikes, that's horrible. I
could do better than that if I were drunk and typing with one
hand", then I would love it if you did that. I'm particularly
"proud" of my inability to figure out how to use shutils and/or
os.copy and my resulting os.system("cp -r %s %s" % (src, dest)).
Note that Patchy does not need to conform to python 2.4, since
it's not something that gets run in GUB.
The general idea is:
- run compile_lilypond.staging() as a cronjob every X hours
(completely automatic merging)
- run test-patches.py as a cronjob every X hours; this will
prepare a regtest comparison for a human to examine before
accepting the patch.
Again, it would be great if somebody with more patience and/or
pride in their work could take over Patchy. As an incentive, you
don't need to deal with our review process. I'll hand git push
ability for that repo out to anybody; just hack away and push
without any concerns for code style or readability or reviews or
whatever.
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
