Re: incomplete tuplets in non-standard time signatures
Hi Michael,
I just filed a bug report
http://lilypond.1069038.n5.nabble.com/Wrongly-read-property-with-MetronomeMark-td237659.html
2c2908c905ba822ef656b06b1cc4f0ca33960c9c is the first bad commit
commit 2c2908c905ba822ef656b06b1cc4f0ca33960c9c
Author: Malte Meyn
Date: Sun Sep 29 10:10:35 2019 +0200
That does not make sense to me. 2.20.0 was released on March 1, 2020 and
Harm reported that 2.20.0 is fine. I think bisecting must start with
2.20.0., then.
It's well possible that I got this all wrong, but I was under the
impression that, as not all changes added during the 2.19.xx cycle were
cherry-picked into 2.20, it's quite possible for a commit that was added
to master before the release of 2.20.0 to only end up in 2.21.xx.
Also, Malte's commit contains the following change in lily/bracket.cc:
index bc7ad67680..63ab1fcafa 100644
@@ -77,8 +77,9 @@ Bracket::make_bracket (Grob *me, // for line properties.
m.add_stencil (Line_interface::line (me, straight_corners[LEFT],
straight_corners[RIGHT]));
- if (scm_is_number (me->get_property ("dash-fraction")))
- me->set_property ("dash-fraction", scm_from_double (1.0));
+ if (scm_is_eq (me->get_property ("style"), ly_symbol2scm ("dashed-line"))
+ && !to_boolean (me->get_property ("dashed-edge")))
+ me->set_property ("style", ly_symbol2scm ("line"));
for (LEFT_and_RIGHT (d))
m.add_stencil (Line_interface::line (me, straight_corners[d],
flare_corners[d]));
I haven't even tried to understand the scope and logic of Malte's
changes, but to me it seems very plausible that this change could lead
to a behaviour as discovered by Harm.
(And actually, my bisect started as follows:
git bisect start
# good: [b39b2e652fc4bcf282bb8b826e81070a77bc93db] Release: bump Welcome
versions.
git bisect good b39b2e652fc4bcf282bb8b826e81070a77bc93db
# bad: [65932b8fde202a95b7fbf9f400c01c75fa53519f] Add version to
Japanese snippet
git bisect bad 65932b8fde202a95b7fbf9f400c01c75fa53519f
b39b2e is release/2.20.0-1, 65932b8 is release/2.21.0-1.)
Lukas
Re: Wikipedia scores
Thanks Federico & Andrew. @Andrew, music is a high priority with some WP editors, the problem lies with WikiMedia which is the software WP is built on. In passing, I see that non-WP users of score have not been informed. See https://phabricator.wikimedia.org/T257066#6297061 Martin On 29/11/2020 22:16, Andrew Bernard wrote: From that discussion they are keeping the security problem hidden for security reasons! Not accessible to volunteers. Therefore I would say this is unlikely to ever be fixed. Music is not a high priority at Wikipedia as far as I can see. Andrew On 30/11/2020 9:06 am, J Martin Rushton wrote: I don't know if all members of this newsgroup are aware but for many years Wikipedia has supported the ... extension to produce scores and midi in displayed pages from Lily source. However since summer this year scores have been disabled for undisclosed security concerns. See https://en.wikipedia.org/wiki/The_Water_of_Tyne for an example of a disabled score. See https://en.wikipedia.org/wiki/Help_talk:Score and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Musical_scores_not_working for discussions of this problem. Does anyone here have any input? Is there a known problem within LP that is causing WP problems? Can we help WP at all? -- J Martin Rushton MBCS
Re: Wikipedia scores
Hi Martin It was discussed on lilypond-devel last month: https://lists.gnu.org/archive/html/lilypond-devel/2020-10/msg00086.html Il giorno dom, nov 29 2020 at 22:06:58 +, J Martin Rushton ha scritto: I don't know if all members of this newsgroup are aware but for many years Wikipedia has supported the ... extension to produce scores and midi in displayed pages from Lily source. However since summer this year scores have been disabled for undisclosed security concerns. See https://en.wikipedia.org/wiki/The_Water_of_Tyne for an example of a disabled score. See https://en.wikipedia.org/wiki/Help_talk:Score and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Musical_scores_not_working for discussions of this problem. Does anyone here have any input? Is there a known problem within LP that is causing WP problems? Can we help WP at all? Regards, Martin -- J Martin Rushton MBCS
Re: Wikipedia scores
From that discussion they are keeping the security problem hidden for security reasons! Not accessible to volunteers. Therefore I would say this is unlikely to ever be fixed. Music is not a high priority at Wikipedia as far as I can see. Andrew On 30/11/2020 9:06 am, J Martin Rushton wrote: I don't know if all members of this newsgroup are aware but for many years Wikipedia has supported the ... extension to produce scores and midi in displayed pages from Lily source. However since summer this year scores have been disabled for undisclosed security concerns. See https://en.wikipedia.org/wiki/The_Water_of_Tyne for an example of a disabled score. See https://en.wikipedia.org/wiki/Help_talk:Score and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Musical_scores_not_working for discussions of this problem. Does anyone here have any input? Is there a known problem within LP that is causing WP problems? Can we help WP at all?
Re: incomplete tuplets in non-standard time signatures
Am Sonntag, dem 29.11.2020 um 22:24 +0100 schrieb Michael Käppler: > Am 29.11.2020 um 21:09 schrieb Lukas-Fabian Moser: > > Hi Harm, > Hi Harm and Lukas, > > > > > I just filed a bug report > > > http://lilypond.1069038.n5.nabble.com/Wrongly-read-property-with-MetronomeMark-td237659.html > > > > > 2c2908c905ba822ef656b06b1cc4f0ca33960c9c is the first bad commit > > commit 2c2908c905ba822ef656b06b1cc4f0ca33960c9c > > Author: Malte Meyn > > Date: Sun Sep 29 10:10:35 2019 +0200 > > > > Issue 5563: make edges of brackets dashable > > > > The new boolean grob property dashed-edge controls whether the > > edges of > > a dashed bracket are solid or dashed. > > > > > That does not make sense to me. 2.20.0 was released on March 1, 2020 and > Harm reported > that 2.20.0 is fine. I think bisecting must start with 2.20.0., then. It does very much make sense: 2.20.0 was not released from master; instead stable/2.20 was branched in August 2017. All commits since then until April 2020 first appeared in 2.21.0 (unless backported for 2.20). Jonas signature.asc Description: This is a digitally signed message part
Wikipedia scores
I don't know if all members of this newsgroup are aware but for many years Wikipedia has supported the ... extension to produce scores and midi in displayed pages from Lily source. However since summer this year scores have been disabled for undisclosed security concerns. See https://en.wikipedia.org/wiki/The_Water_of_Tyne for an example of a disabled score. See https://en.wikipedia.org/wiki/Help_talk:Score and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Musical_scores_not_working for discussions of this problem. Does anyone here have any input? Is there a known problem within LP that is causing WP problems? Can we help WP at all? Regards, Martin -- J Martin Rushton MBCS
Re: Syntax error encountered while engraving a successfully updated Mutopia ly file
That works!
Thanks,
Ken
On Sun, Nov 29, 2020 at 1:08 PM Aaron Hill wrote:
>
> On 2020-11-29 12:03 pm, Kenneth Wolcott wrote:
> > Hi;
> >
> > I downloaded a Mutopia Greensleves ly source and successfully
> > converted it to 2.20.0 but get the following error when engraving:
> >
> > ././updated_greensleeves.ly:68:22: error: syntax error, unexpected
> > SCM_TOKEN, expecting ',' or '.' or '='
> > top-markup-spacing
> > #'padding = #10
> >
> > The output from convert was only the version numbers.
> >
> > Please tell me how to fix this.
> >
> > The engraving did succeed as there were pdf and midi files produced.
> >
> > The paper section, below, is where the error occurs:
> >
> > \paper {
> > first-page-number = 2
> > print-first-page-number = ##t
> > top-markup-spacing #'padding = #10
> > markup-system-spacing #'padding = #7
> > system-system-spacing #'basic-distance = #14
> > }
>
> convert-ly knows how to fix this:
>
>
>\override Thing #'property #'sub-property = #'value
> % ...to...
>\override Thing.property.sub-property = #'value
>
>
> It does not however seem to correct:
>
>
>variable #'key = #'value
> % ...to...
>variable.key = #'value
>
>
>
> -- Aaron Hill
>
Re: incomplete tuplets in non-standard time signatures
Am 29.11.2020 um 21:09 schrieb Lukas-Fabian Moser: Hi Harm, Hi Harm and Lukas, I just filed a bug report http://lilypond.1069038.n5.nabble.com/Wrongly-read-property-with-MetronomeMark-td237659.html 2c2908c905ba822ef656b06b1cc4f0ca33960c9c is the first bad commit commit 2c2908c905ba822ef656b06b1cc4f0ca33960c9c Author: Malte Meyn Date: Sun Sep 29 10:10:35 2019 +0200 Issue 5563: make edges of brackets dashable The new boolean grob property dashed-edge controls whether the edges of a dashed bracket are solid or dashed. That does not make sense to me. 2.20.0 was released on March 1, 2020 and Harm reported that 2.20.0 is fine. I think bisecting must start with 2.20.0., then. Cheers, Michael
Re: Syntax error encountered while engraving a successfully updated Mutopia ly file
On 2020-11-29 12:03 pm, Kenneth Wolcott wrote:
Hi;
I downloaded a Mutopia Greensleves ly source and successfully
converted it to 2.20.0 but get the following error when engraving:
././updated_greensleeves.ly:68:22: error: syntax error, unexpected
SCM_TOKEN, expecting ',' or '.' or '='
top-markup-spacing
#'padding = #10
The output from convert was only the version numbers.
Please tell me how to fix this.
The engraving did succeed as there were pdf and midi files produced.
The paper section, below, is where the error occurs:
\paper {
first-page-number = 2
print-first-page-number = ##t
top-markup-spacing #'padding = #10
markup-system-spacing #'padding = #7
system-system-spacing #'basic-distance = #14
}
convert-ly knows how to fix this:
\override Thing #'property #'sub-property = #'value
% ...to...
\override Thing.property.sub-property = #'value
It does not however seem to correct:
variable #'key = #'value
% ...to...
variable.key = #'value
-- Aaron Hill
Re: incomplete tuplets in non-standard time signatures
Hi Harm, I just filed a bug report http://lilypond.1069038.n5.nabble.com/Wrongly-read-property-with-MetronomeMark-td237659.html 2c2908c905ba822ef656b06b1cc4f0ca33960c9c is the first bad commit commit 2c2908c905ba822ef656b06b1cc4f0ca33960c9c Author: Malte Meyn Date: Sun Sep 29 10:10:35 2019 +0200 Issue 5563: make edges of brackets dashable The new boolean grob property dashed-edge controls whether the edges of a dashed bracket are solid or dashed. Lukas
Syntax error encountered while engraving a successfully updated Mutopia ly file
Hi;
I downloaded a Mutopia Greensleves ly source and successfully
converted it to 2.20.0 but get the following error when engraving:
././updated_greensleeves.ly:68:22: error: syntax error, unexpected
SCM_TOKEN, expecting ',' or '.' or '='
top-markup-spacing
#'padding = #10
The output from convert was only the version numbers.
Please tell me how to fix this.
The engraving did succeed as there were pdf and midi files produced.
The paper section, below, is where the error occurs:
\paper {
first-page-number = 2
print-first-page-number = ##t
top-markup-spacing #'padding = #10
markup-system-spacing #'padding = #7
system-system-spacing #'basic-distance = #14
}
Thanks,
Ken
Re: incomplete tuplets in non-standard time signatures
Am Fr., 27. Nov. 2020 um 17:21 Uhr schrieb 98123981293 1293812397123
:
>
> Dear list,
>
> On list thread Apr 6 2020, Harm provided a Scheme workaround for half-dashed
> tuplet brackets in non-standard time signatures in version 2.20. However, in
> using his solution in 2.21.6, if a /tempo marking is included in any staff, I
> observe that, for the first staff in the score, the custom stencil will
> always engrave as a fully dashed instead of half-dashed tuplet (and no matter
> where the /tempo statement occurs, all tuplets in that first staff are
> affected). Half-dashed tuplet stencils engrave as expected in all other
> staves regardless of any /tempo statements. Can anyone give any insight as to
> why? Compare output of the following three examples below.
>
> (Or is there an easier way to do this now altogether in ver 2.21.6? Harm
> hinted at such features possibly becoming available in future releases.)
>
> Thank you,
> Kyle
>
> \version "2.21.6"
>
> %%%SCHEME FUNCTIONS:%%%
>
> #(define (translated-dashed-line->draw-line bool lst)
> ;; lst is supposed to be a list retrieved from a stencil-expression, p.e.
> ;; (translate-stencil
> ;; (17.1123059321317 . 0.0)
> ;; (dashed-line
> ;; 0.16 <- thick
> ;; 0.409629549559636 <- on
> ;; 0.61324339455 <- off
> ;; -7.5781485327 <- x-destination
> ;; 0.0 <- y-destination
> ;; 0.0 <- phase
> ;; ))
> ;; This procedure will transform it into:
> ;; (drawline
> ;; thick
> ;; x-start
> ;; y-start
> ;; x-end
> ;; y-end)
>
> (if (and bool
>(>= (length lst) 3)
>(not (eq? (car lst) 'draw-line)))
> (let* ((translate (list-ref lst 1))
> (dashed-line (last lst))
> (thick (list-ref dashed-line 1))
> (x-dest (list-ref dashed-line 4))
> (y-dest (list-ref dashed-line 5)))
> (list
> 'draw-line
> thick
> (car translate)
> (cdr translate)
> (+ x-dest (car translate))
> (+ y-dest (cdr translate
> lst))
>
> #(define (half-solid-tuplet-bracket bool-pair)
> (lambda (grob)
> (if (and ;; continue if the TupletBracket is dashed
>(eq? (ly:grob-property grob 'style) 'dashed-line)
>;; continue if left or right part should become solid
>(or (car bool-pair) (cdr bool-pair))
>;; don't continue, if TupletBracket is omitted
>(not (ly:stencil-empty? (ly:grob-property grob 'stencil)))
>;; don't continue, if the whole TupletBracket should be dashed
>(not (and (car bool-pair) (cdr bool-pair
> ;; make left or right part solid
> (let* ((stil (ly:grob-property grob 'stencil))
> (x-ext (ly:stencil-extent stil X))
> (y-ext (ly:stencil-extent stil Y))
> (stil-expr (ly:stencil-expr stil))
> (translate (list-ref stil-expr 1))
> (combined-stil (last stil-expr))
> (new-stencil-expr
>(list
> 'translate-stencil
> translate
> (cons 'combine-stencil
> (map
> (lambda (i)
> (translated-dashed-line->draw-line
> (if (odd? i)
> (cdr bool-pair)
> (car bool-pair))
> (list-ref combined-stil i)))
> (iota 4 1 1))
> (ly:grob-set-property! grob 'stencil
> (ly:make-stencil
> new-stencil-expr
> x-ext
> y-ext))
>
> halfSolidTupletBracket =
> #(define-music-function (pair)(pair?)
> #{
> \override TupletBracket.after-line-breaking =
> #(half-solid-tuplet-bracket pair)
> #})
>
> %%%FAILS:%%%
>
> \score {
> <<
> \new Staff
> {
> \override TupletBracket.bracket-visibility = ##t
> \once \halfSolidTupletBracket #'(#t . #f)
> \once \override TupletBracket.style = #'dashed-line
> \once \override TupletBracket.edge-height = #'(0.7 . 0)
> \tempo 4 = 60
> \time 2/5
> \times 4/5 { c'16 c'8. c'16 c'16 c'8 } |
> }
>
> \new Staff
> {
> \override TupletBracket.bracket-visibility = ##t
> \once \halfSolidTupletBracket #'(#t . #f)
> \once \override TupletBracket.style = #'dashed-line
> \once \override TupletBracket.edge-height = #'(0.7 . 0)
> \tempo 4 = 60
> \time 2/5
> \times 4/5 { c'16 c'8. c'16 c'16 c'8 } |
> }
> >>
> }
>
> %%% ALSO FAILS:%%%
>
> \score {
> <<
> \new Staff
> {
> \override TupletBracket.bracket-visibility = ##t
> \once \halfSolidTupletBracket #'(#t . #f)
> \once \override TupletBracket.style = #'dashed-line
> \once \override TupletBracket.edge-height = #'(0.7 . 0)
> \time 2/5
> \times 4/
