Frescobaldi: errors with 2.23.80

2022-11-01 Thread Knute Snortum 
(I'm hoping this is the best place to post Frescobaldi issues.)

I have found that Frescobaldi emits errors when in the Layout Control
view with Display control points checked.  The first error has to do
with the new way Guile 2 deals with the format function. This is my
proposed fix:

--- a/frescobaldi_app/layoutcontrol/debug-layout-options.ly
+++ b/frescobaldi_app/layoutcontrol/debug-layout-options.ly
@@ -50,8 +50,8 @@ debugLayoutOptions =
   ;; based on the current LilyPond version
   (lambda (filename)
 (if lily-version-new
-(ly:parser-include-string (format "\\include \"./~a\"" filename))
-(ly:parser-include-string parser (format "\\include
\"./~a\"" filename))
+(ly:parser-include-string (format #f "\\include \"./~a\""
filename))
+(ly:parser-include-string parser (format #f "\\include
\"./~a\"" filename))
 ;; include the optional custom file first.
 ;; This way it can for example define configuration variables.
 (if (ly:get-option 'debug-custom-file)

The format function now has #f as the first argument.  But this leads
to another error in Frescobaldi which I have attached.

Any 2.23.80 LilyPond source will cause the error in Frescobaldi, even:

\version "2.23.80"
{c' c' c' c'}

--
Knute Snortum
Processing `/tmp/frescobaldi-7wxtzsl7/tmpain8aecz/document.ly'
Parsing...[/home/knute/lilypond/lilypond-2.23.80/share/lilypond/2.23.80/ly/init.ly
Using `nederlands' note names...[[/home/knute/git-repos/frescobaldi/frescobaldi_app/layoutcontrol/debug-layout-options.ly[/home/knute/git-repos/frescobaldi/frescobaldi_app/layoutcontrol/./lilypond-version-predicates.ily][[/home/knute/git-repos/frescobaldi/frescobaldi_app/layoutcontrol/./display-control-points.ily
/home/knute/git-repos/frescobaldi/frescobaldi_app/layoutcontrol/./display-control-points.ily:58:2:
 error: Guile signaled an error for the expression beginning here
#
 (cond ((not (defined? 'debug-control-points-line-thickness))
/home/knute/lilypond/lilypond-2.23.80/share/lilypond/2.23.80/scm/lily/lily.scm  
15 #
In 
/home/lily/lilypond-2.23.80/release/binaries/lilypond/build/out/share/lilypond/current/scm/lily/lily.scm:
   876:16 14 (lilypond-main _)
905:4 13 (lilypond-all _)
In srfi/srfi-1.scm:
640:9 12 (for-each # ?)
In 
/home/lily/lilypond-2.23.80/release/binaries/lilypond/build/out/share/lilypond/current/scm/lily/lily.scm:
915:9 11 (_ "/tmp/frescobaldi-7wxtzsl7/tmpain8aecz/document.ly")
In ice-9/boot-9.scm:
829:9 10 (catch ly-file-failed # ?)
In unknown file:
   9 (ly:parse-file "/tmp/frescobaldi-7wxtzsl7/tmpain8aecz/d?")
   8 (apply-smob/1 #)
In ice-9/eval.scm:
   721:20  7 (primitive-eval (cond ((not (defined? (quote #))) (?
In ice-9/psyntax.scm:
  1261:22  6 (expand-top-sequence ((cond ((not (defined? #)) (? _ ?)
In ice-9/boot-9.scm:
   222:17  5 (map1 (#))
In ice-9/psyntax.scm:
  1435:12  4 (_ _ _)
  1085:24  3 (expand-sequence (#) ?)
  1435:12  2 (dobody (#) ?)
In ice-9/boot-9.scm:
   751:25  1 (dispatch-exception 0 syntax-error (#f "definition i?" ?))
In unknown file:
   0 (apply-smob/1 # syntax-error ?)
Syntax error:
/home/knute/git-repos/frescobaldi/frescobaldi_app/layoutcontrol/./display-control-points.ily:59:8:
 definition in expression context, where definitions are not allowed, in form 
(define debug-control-points-line-thickness 0.05)
Exited with return code 1.

Re: Frescobaldi: errors with 2.23.80

2022-11-01 Thread Jean Abou Samra 

Le 01/11/2022 à 22:23, Knute Snortum a écrit :

(I'm hoping this is the best place to post Frescobaldi issues.)

I have found that Frescobaldi emits errors when in the Layout Control
view with Display control points checked.




Remember this?

https://github.com/frescobaldi/frescobaldi/issues/1378#issuecomment-879393706

Just don't use this Frescobaldi feature in 2.23.80, use the new
\vshape command instead. This feature is slated to be removed
when LilyPond 2.24 is released because \vshape obviates it.

Best,
Jean

Re: Frescobaldi: errors with 2.23.80

2022-11-01 Thread Knute Snortum 
On Tue, Nov 1, 2022 at 2:33 PM Jean Abou Samra  wrote:
>
> Le 01/11/2022 à 22:23, Knute Snortum a écrit :
> > (I'm hoping this is the best place to post Frescobaldi issues.)
> >
> > I have found that Frescobaldi emits errors when in the Layout Control
> > view with Display control points checked.
>
>
>
> Remember this?
>
> https://github.com/frescobaldi/frescobaldi/issues/1378#issuecomment-879393706
>
> Just don't use this Frescobaldi feature in 2.23.80, use the new
> \vshape command instead. This feature is slated to be removed
> when LilyPond 2.24 is released because \vshape obviates it.
>
> Best,
> Jean
>

Thanks Jean, I searched Frescobaldi issues but completely missed that.
*sigh* Getting older.

--
Knute Snortum