Key signatures in hidden staves take up space

2014-10-04 Thread Peter Crighton
As you can see in the following code and the attached image, there is a
possible bug when using \RemoveEmptyStaves with voices in different keys
(such as in a score with transposing instruments): key signatures appearing
only in hidden empty staves are still causing space in the shown staves.


\version "2.19.13"

<<
  \new Staff <<
{
  c''1 \break
  c''2. \break
  c''1
}
  >>
  \new Staff \with {
\RemoveEmptyStaves
  } <<
{
  \key d \major
  R1 \break
  \time 3/4 R2. \break
  \key c \major
  \time 4/4 R1
}
  >>
>>

<<
  \new Staff <<
{
  c''1 \break
  c''2. \break
  c''1
}
  >>
  \new Staff <<
{
  \key d \major
  R1 \break
  \time 3/4 R2. \break
  \key c \major
  \time 4/4 R1
}
  >>
>>


I don’t think this is as it should be. How can I correct this? And should
it be filed as a bug report, or is there some intention behind this
appearance?

--
Peter Crighton | Musician & Music Engraver based in Mainz, Germany
http://www.petercrighton.de
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-04 Thread Simon Albrecht

Am 04.10.2014 um 23:13 schrieb Peter Crighton:
As you can see in the following code and the attached image, there is 
a possible bug when using \RemoveEmptyStaves with voices in different 
keys (such as in a score with transposing instruments): key signatures 
appearing only in hidden empty staves are still causing space in the 
shown staves.



\version "2.19.13"

<<
  \new Staff <<
{
  c''1 \break
  c''2. \break
  c''1
}
  >>
  \new Staff \with {
\RemoveEmptyStaves
  } <<
{
  \key d \major
  R1 \break
  \time 3/4 R2. \break
  \key c \major
  \time 4/4 R1
}
  >>
>>

<<
  \new Staff <<
{
  c''1 \break
  c''2. \break
  c''1
}
  >>
  \new Staff <<
{
  \key d \major
  R1 \break
  \time 3/4 R2. \break
  \key c \major
  \time 4/4 R1
}
  >>
>>


I don’t think this is as it should be. How can I correct this? And 
should it be filed as a bug report, or is there some intention behind 
this appearance?
I quite agree that this is likely a bug (or at least: unexpected 
behaviour which should be enhanced).

Yours, Simon
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-05 Thread David Kastrup
Simon Albrecht  writes:

> Am 04.10.2014 um 23:13 schrieb Peter Crighton:
>> As you can see in the following code and the attached image, there
>> is a possible bug when using \RemoveEmptyStaves with voices in
>> different keys (such as in a score with transposing instruments):
>> key signatures appearing only in hidden empty staves are still
>> causing space in the shown staves.
>>
>> I don’t think this is as it should be. How can I correct this? And
>> should it be filed as a bug report, or is there some intention
>> behind this appearance?
> I quite agree that this is likely a bug (or at least: unexpected
> behaviour which should be enhanced).

It is not unexpected behavior.  \RemoveEmptyStaves can only work after
the line breaks are known and the line breaks are the result of
horizontal spacing.

Basically you'd need to redo all of the horizontal spacing after stuff
like \RemoveEmptyStaves have run without changing the line breaking
again if you find out that this gives you more space to work with.

Unlikely to happen in the next few years of LilyPond development.

-- 
David Kastrup

___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-05 Thread Peter Crighton
2014-10-05 11:15 GMT+02:00 David Kastrup :

> Simon Albrecht  writes:
>
> > Am 04.10.2014 um 23:13 schrieb Peter Crighton:
> >> As you can see in the following code and the attached image, there
> >> is a possible bug when using \RemoveEmptyStaves with voices in
> >> different keys (such as in a score with transposing instruments):
> >> key signatures appearing only in hidden empty staves are still
> >> causing space in the shown staves.
> >>
> >> I don’t think this is as it should be. How can I correct this? And
> >> should it be filed as a bug report, or is there some intention
> >> behind this appearance?
> > I quite agree that this is likely a bug (or at least: unexpected
> > behaviour which should be enhanced).
>
> It is not unexpected behavior.  \RemoveEmptyStaves can only work after
> the line breaks are known and the line breaks are the result of
> horizontal spacing.
>
> Basically you'd need to redo all of the horizontal spacing after stuff
> like \RemoveEmptyStaves have run without changing the line breaking
> again if you find out that this gives you more space to work with.
>
> Unlikely to happen in the next few years of LilyPond development.


Okay, thanks for explaining. For now I am content with using “\omit
Staff.KeySignature” and “\revert Staff.KeySignature.stencil” respectively
to get rid of the problem.

What I found strange, though, was that in my score the problem only
appeared when there was a time signature change at the beginning of the
line. I couldn’t reproduce this in a minimal example.

--
Peter Crighton | Musician & Music Engraver based in Mainz, Germany
http://www.petercrighton.de
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-05 Thread David Kastrup
Peter Crighton  writes:

> 2014-10-05 11:15 GMT+02:00 David Kastrup :
>
>> Simon Albrecht  writes:
>>
>> > Am 04.10.2014 um 23:13 schrieb Peter Crighton:
>> >> As you can see in the following code and the attached image, there
>> >> is a possible bug when using \RemoveEmptyStaves with voices in
>> >> different keys (such as in a score with transposing instruments):
>> >> key signatures appearing only in hidden empty staves are still
>> >> causing space in the shown staves.
>> >>
>> >> I don’t think this is as it should be. How can I correct this? And
>> >> should it be filed as a bug report, or is there some intention
>> >> behind this appearance?
>> > I quite agree that this is likely a bug (or at least: unexpected
>> > behaviour which should be enhanced).
>>
>> It is not unexpected behavior.  \RemoveEmptyStaves can only work after
>> the line breaks are known and the line breaks are the result of
>> horizontal spacing.
>>
>> Basically you'd need to redo all of the horizontal spacing after stuff
>> like \RemoveEmptyStaves have run without changing the line breaking
>> again if you find out that this gives you more space to work with.
>>
>> Unlikely to happen in the next few years of LilyPond development.
>
>
> Okay, thanks for explaining. For now I am content with using “\omit
> Staff.KeySignature” and “\revert Staff.KeySignature.stencil” respectively
> to get rid of the problem.
>
> What I found strange, though, was that in my score the problem only
> appeared when there was a time signature change at the beginning of the
> line. I couldn’t reproduce this in a minimal example.

Huh.  Maybe LilyPond _does_ set the line/horizontal spacing fresh after
determining the break points.  But things like key/time signature
changes are repeated on the _previous_ line.  And maybe it's too late to
redo the line spacing on _that_?

You can try creating a minimal example with multiple lines by manually
placing breaks with \break.

-- 
David Kastrup

___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-07 Thread Peter Crighton
2014-10-05 16:38 GMT+02:00 David Kastrup :

> Peter Crighton  writes:
>
> > 2014-10-05 11:15 GMT+02:00 David Kastrup :
> >
> >> Simon Albrecht  writes:
> >>
> >> > Am 04.10.2014 um 23:13 schrieb Peter Crighton:
> >> >> As you can see in the following code and the attached image, there
> >> >> is a possible bug when using \RemoveEmptyStaves with voices in
> >> >> different keys (such as in a score with transposing instruments):
> >> >> key signatures appearing only in hidden empty staves are still
> >> >> causing space in the shown staves.
> >> >>
> >> >> I don’t think this is as it should be. How can I correct this? And
> >> >> should it be filed as a bug report, or is there some intention
> >> >> behind this appearance?
> >> > I quite agree that this is likely a bug (or at least: unexpected
> >> > behaviour which should be enhanced).
> >>
> >> It is not unexpected behavior.  \RemoveEmptyStaves can only work after
> >> the line breaks are known and the line breaks are the result of
> >> horizontal spacing.
> >>
> >> Basically you'd need to redo all of the horizontal spacing after stuff
> >> like \RemoveEmptyStaves have run without changing the line breaking
> >> again if you find out that this gives you more space to work with.
> >>
> >> Unlikely to happen in the next few years of LilyPond development.
> >
> >
> > Okay, thanks for explaining. For now I am content with using “\omit
> > Staff.KeySignature” and “\revert Staff.KeySignature.stencil” respectively
> > to get rid of the problem.
> >
> > What I found strange, though, was that in my score the problem only
> > appeared when there was a time signature change at the beginning of the
> > line. I couldn’t reproduce this in a minimal example.
>
> Huh.  Maybe LilyPond _does_ set the line/horizontal spacing fresh after
> determining the break points.  But things like key/time signature
> changes are repeated on the _previous_ line.  And maybe it's too late to
> redo the line spacing on _that_?
>
> You can try creating a minimal example with multiple lines by manually
> placing breaks with \break.


I know, what I meant was that in my minimal example the problem appears in
every line, not only those with a time signature change.


\version "2.19.13"

<<
  \new Staff <<
\relative c'' {
  c1 \break
  c2.
  c \break
  c1
  c
}
  >>
  \new Staff \with {
\RemoveEmptyStaves
  } <<
{
  \key d \major
  R1 \break
  \time 3/4
  R2. \break
  R2.
  \key c \major
  \time 4/4
  R1 \break
  R1
}
  >>
>>

--
Peter Crighton | Musician & Music Engraver based in Mainz, Germany
http://www.petercrighton.de
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-07 Thread David Kastrup
Peter Crighton  writes:

> 2014-10-05 16:38 GMT+02:00 David Kastrup :
>> >
>> > Okay, thanks for explaining. For now I am content with using “\omit
>> > Staff.KeySignature” and “\revert Staff.KeySignature.stencil” respectively
>> > to get rid of the problem.
>> >
>> > What I found strange, though, was that in my score the problem only
>> > appeared when there was a time signature change at the beginning of the
>> > line. I couldn’t reproduce this in a minimal example.
>>
>> Huh.  Maybe LilyPond _does_ set the line/horizontal spacing fresh after
>> determining the break points.  But things like key/time signature
>> changes are repeated on the _previous_ line.  And maybe it's too late to
>> redo the line spacing on _that_?
>>
>> You can try creating a minimal example with multiple lines by manually
>> placing breaks with \break.
>
>
> I know, what I meant was that in my minimal example the problem appears in
> every line, not only those with a time signature change.
>
>
> \version "2.19.13"
>
> <<
>   \new Staff <<
> \relative c'' {
>   c1 \break
>   c2.
>   c \break
>   c1
>   c
> }
>   >>
>   \new Staff \with {
> \RemoveEmptyStaves
>   } <<
> {
>   \key d \major
>   R1 \break
>   \time 3/4
>   R2. \break
>   R2.
>   \key c \major
>   \time 4/4
>   R1 \break
>   R1
> }
>   >>
>>>

I don't really see what you are getting at.  The horizontal spacing in
your example is, as I conjectured first, fixed before removing the
frenched staff: it is in all cases identical to the version without
\RemoveEmptyStaves.  Fixing that would require another pass through the
horizontal spacing, redistributing the additionally available space
without considering the frenched staff.  I don't know how well this
could be implemented given current LilyPond's internals, but it is
certainly going to be a non-trivial expense.

-- 
David Kastrup


___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-07 Thread Keith OHara
Peter Crighton  gmail.com> writes:

> As you can see in the following code and the attached image, there is a 
possible bug when using \RemoveEmptyStaves with voices in different keys 
(such as in a score with transposing instruments): key signatures appearing 
only in hidden empty staves are still causing space in the shown staves.
> 

entered at https://code.google.com/p/lilypond/issues/detail?id=4157


___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user


Re: Key signatures in hidden staves take up space

2014-10-09 Thread Peter Crighton
2014-10-07 20:16 GMT+02:00 David Kastrup :

> Peter Crighton  writes:
>
> > 2014-10-05 16:38 GMT+02:00 David Kastrup :
> >> >
> >> > Okay, thanks for explaining. For now I am content with using “\omit
> >> > Staff.KeySignature” and “\revert Staff.KeySignature.stencil”
> respectively
> >> > to get rid of the problem.
> >> >
> >> > What I found strange, though, was that in my score the problem only
> >> > appeared when there was a time signature change at the beginning of
> the
> >> > line. I couldn’t reproduce this in a minimal example.
> >>
> >> Huh.  Maybe LilyPond _does_ set the line/horizontal spacing fresh after
> >> determining the break points.  But things like key/time signature
> >> changes are repeated on the _previous_ line.  And maybe it's too late to
> >> redo the line spacing on _that_?
> >>
> >> You can try creating a minimal example with multiple lines by manually
> >> placing breaks with \break.
> >
> >
> > I know, what I meant was that in my minimal example the problem appears
> in
> > every line, not only those with a time signature change.
> >
> >
> > \version "2.19.13"
> >
> > <<
> >   \new Staff <<
> > \relative c'' {
> >   c1 \break
> >   c2.
> >   c \break
> >   c1
> >   c
> > }
> >   >>
> >   \new Staff \with {
> > \RemoveEmptyStaves
> >   } <<
> > {
> >   \key d \major
> >   R1 \break
> >   \time 3/4
> >   R2. \break
> >   R2.
> >   \key c \major
> >   \time 4/4
> >   R1 \break
> >   R1
> > }
> >   >>
> >>>
>
> I don't really see what you are getting at.  The horizontal spacing in
> your example is, as I conjectured first, fixed before removing the
> frenched staff: it is in all cases identical to the version without
> \RemoveEmptyStaves.  Fixing that would require another pass through the
> horizontal spacing, redistributing the additionally available space
> without considering the frenched staff.  I don't know how well this
> could be implemented given current LilyPond's internals, but it is
> certainly going to be a non-trivial expense.


Maybe I misunderstood what you had written before, but you seemed to be
surprised about the problem appearing in my score only at time signature
changes. And that’s the one thing I can’t reproduce in a minimal example,
there the problem appears in every line, regardless of there being a time
signature change or not. In my score there would be no extra space before
the first note at the beginning of the line in a situation like measure 3.

--
Peter Crighton | Musician & Music Engraver based in Mainz, Germany
http://www.petercrighton.de



--
Peter Crighton | Musician & Music Engraver based in Mainz, Germany
http://www.petercrighton.de

2014-10-07 20:16 GMT+02:00 David Kastrup :

> Peter Crighton  writes:
>
> > 2014-10-05 16:38 GMT+02:00 David Kastrup :
> >> >
> >> > Okay, thanks for explaining. For now I am content with using “\omit
> >> > Staff.KeySignature” and “\revert Staff.KeySignature.stencil”
> respectively
> >> > to get rid of the problem.
> >> >
> >> > What I found strange, though, was that in my score the problem only
> >> > appeared when there was a time signature change at the beginning of
> the
> >> > line. I couldn’t reproduce this in a minimal example.
> >>
> >> Huh.  Maybe LilyPond _does_ set the line/horizontal spacing fresh after
> >> determining the break points.  But things like key/time signature
> >> changes are repeated on the _previous_ line.  And maybe it's too late to
> >> redo the line spacing on _that_?
> >>
> >> You can try creating a minimal example with multiple lines by manually
> >> placing breaks with \break.
> >
> >
> > I know, what I meant was that in my minimal example the problem appears
> in
> > every line, not only those with a time signature change.
> >
> >
> > \version "2.19.13"
> >
> > <<
> >   \new Staff <<
> > \relative c'' {
> >   c1 \break
> >   c2.
> >   c \break
> >   c1
> >   c
> > }
> >   >>
> >   \new Staff \with {
> > \RemoveEmptyStaves
> >   } <<
> > {
> >   \key d \major
> >   R1 \break
> >   \time 3/4
> >   R2. \break
> >   R2.
> >   \key c \major
> >   \time 4/4
> >   R1 \break
> >   R1
> > }
> >   >>
> >>>
>
> I don't really see what you are getting at.  The horizontal spacing in
> your example is, as I conjectured first, fixed before removing the
> frenched staff: it is in all cases identical to the version without
> \RemoveEmptyStaves.  Fixing that would require another pass through the
> horizontal spacing, redistributing the additionally available space
> without considering the frenched staff.  I don't know how well this
> could be implemented given current LilyPond's internals, but it is
> certainly going to be a non-trivial expense.
>
> --
> David Kastrup
>
>
> ___
> lilypond-user mailing list
> lilypond-user@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-user
>
___