Re: Snippet "Clef change and repeat barline"
Hi Harm, Le lun. 29 juin 2020 à 09:59, Thomas Morley a écrit : > Hi Pierre, > > I've now approved it as > lsr.di.unimi.it/LSR/Item?u=1&id=1116 > with some slight changes. > > I deleted another instance of \hideNotes and changed > \once\override Staff.Clef.space-alist = > #'((key-cancellation minimum-space . 3) > (key-signature minimum-space . 3)) > to > \once\override Staff.Clef.space-alist.key-cancellation = > #'(minimum-space . 3) > \once\override Staff.Clef.space-alist.key-signature = #'(minimum-space . > 3) > > Although your original syntax is ok in this case (no programming error > resulting) it throws away the other default settings for > Clef.space-alist. > I think we should demonstrate how to update certain settings. Instead > of confusing the user by replacing the whole alist, which will work > here but probably not in other cases. > WDYT? > Fine! Actually I never noticed the effects of my syntax... > P.S. > Did you approve > http://lsr.di.unimi.it/LSR/Item?u=1&id=1005 > yourself? > It somehow vanished from my TODO-list and I forgot about it. Sorry for > that! > Not impossible, but actually I don't remember. Maybe... (Normally I don't think I'd do that without asking you first.) As far as I remember, it was approved a long time ago. I simply deleted the commentary lines as soon as I got Fuka's editor agreement. Cheers, Pierre
Re: Snippet "Clef change and repeat barline"
Am So., 28. Juni 2020 um 09:37 Uhr schrieb Pierre Perol-Schneider : > > Hi Harm, > > Le sam. 27 juin 2020 à 10:39, Thomas Morley a > écrit : > ... >> >> Some Remarks: >> (a) Your override >> \once\override Staff.TimeSignature.space-alist = >> #'((first-note . (fixed-space . 0))) >> will replace the default space-alist with your setting, i.e. the other >> default settings (see IR) are thrown away, causing: >> programming error: No spacing entry from TimeSignature to `right-edge' >> You rather want to update a single entry of said space-alist. Thus >> \once\override Staff.TimeSignature.space-alist.first-note = #'(fixed-space . >> 0) >> is preferable. > > > Ok > >> (b) Is there any reason for >> \once\hideNotes >> ? >> Deleting it seems to make no difference > > > No clue...:( Probably a forgotten trial... > >> >> (c) I'd not use two different overrides in the snippet to adjust >> spacing. Thus I'd replace >> \once\override Staff.Clef.X-offset = #.5 >> by >> \once\override Staff.BarLine.space-alist.clef = #'(extra-space . 0.5) > > > Hum, that seems a little short to me: I'd go for #'(extra-space . 0.7) > >> >> (d) I'd replace the namings "Default output:"/"Traditional output:" >> by >> "Current default LilyPond"/"Following E.Gould" >> I always have difficulties with "traditional", because different >> people may not agree with what's traditional at all. >> And I'd say it's closer to the snippets description. > > > Ok, I fully agree. > I've also re-adjust the the after clef space. > Thank you very much Harm. > > Cheers, > Pierre > > PS. LSR #1110 has been deleted. Hi Pierre, I've now approved it as lsr.di.unimi.it/LSR/Item?u=1&id=1116 with some slight changes. I deleted another instance of \hideNotes and changed \once\override Staff.Clef.space-alist = #'((key-cancellation minimum-space . 3) (key-signature minimum-space . 3)) to \once\override Staff.Clef.space-alist.key-cancellation = #'(minimum-space . 3) \once\override Staff.Clef.space-alist.key-signature = #'(minimum-space . 3) Although your original syntax is ok in this case (no programming error resulting) it throws away the other default settings for Clef.space-alist. I think we should demonstrate how to update certain settings. Instead of confusing the user by replacing the whole alist, which will work here but probably not in other cases. WDYT? Thanks, Harm P.S. Did you approve http://lsr.di.unimi.it/LSR/Item?u=1&id=1005 yourself? It somehow vanished from my TODO-list and I forgot about it. Sorry for that!
Re: Snippet "Clef change and repeat barline"
Hi Harm, Le sam. 27 juin 2020 à 10:39, Thomas Morley a écrit : ... > Some Remarks: > (a) Your override > \once\override Staff.TimeSignature.space-alist = > #'((first-note . (fixed-space . 0))) > will replace the default space-alist with your setting, i.e. the other > default settings (see IR) are thrown away, causing: > programming error: No spacing entry from TimeSignature to `right-edge' > You rather want to update a single entry of said space-alist. Thus > \once\override Staff.TimeSignature.space-alist.first-note = #'(fixed-space > . 0) > is preferable. > Ok (b) Is there any reason for > \once\hideNotes > ? > Deleting it seems to make no difference > No clue...:( Probably a forgotten trial... > (c) I'd not use two different overrides in the snippet to adjust > spacing. Thus I'd replace > \once\override Staff.Clef.X-offset = #.5 > by > \once\override Staff.BarLine.space-alist.clef = #'(extra-space . 0.5) > Hum, that seems a little short to me: I'd go for #'(extra-space . 0.7) > (d) I'd replace the namings "Default output:"/"Traditional output:" > by > "Current default LilyPond"/"Following E.Gould" > I always have difficulties with "traditional", because different > people may not agree with what's traditional at all. > And I'd say it's closer to the snippets description. > Ok, I fully agree. I've also re-adjust the the after clef space. Thank you very much Harm. Cheers, Pierre PS. LSR #1110 has been deleted.
Re: Snippet "Clef change and repeat barline"
Am Fr., 26. Juni 2020 um 12:06 Uhr schrieb Pierre Perol-Schneider : > > Hi Harm, > Thank you for your suggestion. Definitly better. > Ultimately, I've created a new snippet: > http://lsr.di.unimi.it/LSR/Item?u=1&id=1116 > If you're ok with it, I'll delete snippet #1110 > Cheers, > Pierre Hi Pierre, in general, much better. Some Remarks: (a) Your override \once\override Staff.TimeSignature.space-alist = #'((first-note . (fixed-space . 0))) will replace the default space-alist with your setting, i.e. the other default settings (see IR) are thrown away, causing: programming error: No spacing entry from TimeSignature to `right-edge' You rather want to update a single entry of said space-alist. Thus \once\override Staff.TimeSignature.space-alist.first-note = #'(fixed-space . 0) is preferable. (b) Is there any reason for \once\hideNotes ? Deleting it seems to make no difference (c) I'd not use two different overrides in the snippet to adjust spacing. Thus I'd replace \once\override Staff.Clef.X-offset = #.5 by \once\override Staff.BarLine.space-alist.clef = #'(extra-space . 0.5) (d) I'd replace the namings "Default output:"/"Traditional output:" by "Current default LilyPond"/"Following E.Gould" I always have difficulties with "traditional", because different people may not agree with what's traditional at all. And I'd say it's closer to the snippets description. Thanks, Harm
Re: Snippet "Clef change and repeat barline"
Hi Harm, Thank you for your suggestion. Definitly better. Ultimately, I've created a new snippet: http://lsr.di.unimi.it/LSR/Item?u=1&id=1116 If you're ok with it, I'll delete snippet #1110 Cheers, Pierre Le jeu. 25 juin 2020 à 22:21, Thomas Morley a écrit : > Am Do., 25. Juni 2020 um 10:55 Uhr schrieb Pierre Perol-Schneider > : > > > > Hi Harm, > > > > Le mer. 24 juin 2020 à 23:26, Thomas Morley > a écrit : > >> > >> To the author of said snippet. > >> lsr.di.unimi.it/LSR/Item?u=1&id=1110 > >> > >> I will not approve it in it's current state. > > > > > > Ok. > > > >> This sounds like default LilyPond being wrong in this regard. If so, > >> it's a bug, needed to be reported, probably discussed and finally > >> fixed. > > > > > > Ok, will do. > > > >> > >> Tbh, I don't think LilyPond is wrong. Ofcourse I'd could be proven > wrong. > > > > > > See: E. Gould/ Behind bars (ed. 2011, pp. 234-235) > > (and: > http://lilypond-french-users.1298960.n2.nabble.com/Clef-apres-signe-de-reprise-td7589673.html > ) > > > > Cheers, > > Pierre > > Hi Pierre, > > ok, I'm convinced. > Please change the description to something at the lines of: > "According to Elaine Gould, Behind Bars, pp ..., changes of ... > should be printed after the closing repeat-sign. > This is currently not the default in Lily. > This snippet provides a manual workaround." > > Syntax, wording, grammar could surely be improved... > > Nevertheless, I don't think it should be doc-tagged. > If it's an issue then an entry in "known issues and warnings" seems to > be more appropriate, imho. > > And thanks for the bug-report, cheers, > Harm >
Re: Snippet "Clef change and repeat barline"
Am Do., 25. Juni 2020 um 10:55 Uhr schrieb Pierre Perol-Schneider : > > Hi Harm, > > Le mer. 24 juin 2020 à 23:26, Thomas Morley a > écrit : >> >> To the author of said snippet. >> lsr.di.unimi.it/LSR/Item?u=1&id=1110 >> >> I will not approve it in it's current state. > > > Ok. > >> This sounds like default LilyPond being wrong in this regard. If so, >> it's a bug, needed to be reported, probably discussed and finally >> fixed. > > > Ok, will do. > >> >> Tbh, I don't think LilyPond is wrong. Ofcourse I'd could be proven wrong. > > > See: E. Gould/ Behind bars (ed. 2011, pp. 234-235) > (and: > http://lilypond-french-users.1298960.n2.nabble.com/Clef-apres-signe-de-reprise-td7589673.html) > > Cheers, > Pierre Hi Pierre, ok, I'm convinced. Please change the description to something at the lines of: "According to Elaine Gould, Behind Bars, pp ..., changes of ... should be printed after the closing repeat-sign. This is currently not the default in Lily. This snippet provides a manual workaround." Syntax, wording, grammar could surely be improved... Nevertheless, I don't think it should be doc-tagged. If it's an issue then an entry in "known issues and warnings" seems to be more appropriate, imho. And thanks for the bug-report, cheers, Harm
Re: Snippet "Clef change and repeat barline"
Le mer. 24 juin 2020 à 23:26, Thomas Morley a écrit : ... > Please check whether there's an issue about it already, if not report > it on the bug-list. > Done: http://lilypond.1069038.n5.nabble.com/Clef-change-and-repeat-sign-td234226.html Cheers, Pierre
Re: Snippet "Clef change and repeat barline"
Hi Harm, Le mer. 24 juin 2020 à 23:26, Thomas Morley a écrit : > To the author of said snippet. > lsr.di.unimi.it/LSR/Item?u=1&id=1110 > > I will not approve it in it's current state. > Ok. This sounds like default LilyPond being wrong in this regard. If so, > it's a bug, needed to be reported, probably discussed and finally > fixed. > Ok, will do. > Tbh, I don't think LilyPond is wrong. Ofcourse I'd could be proven wrong. > See: E. Gould/ Behind bars (ed. 2011, pp. 234-235) (and: http://lilypond-french-users.1298960.n2.nabble.com/Clef-apres-signe-de-reprise-td7589673.html ) Cheers, Pierre
Snippet "Clef change and repeat barline"
To the author of said snippet. lsr.di.unimi.it/LSR/Item?u=1&id=1110 I will not approve it in it's current state. It shows how to change BreakAlignment.break-align-orders, ok, though this is covered in the docs already. It's description says "Here's a workaround to get a traditional output when clef changes after a repeat barline!" This sounds like default LilyPond being wrong in this regard. If so, it's a bug, needed to be reported, probably discussed and finally fixed. Please check whether there's an issue about it already, if not report it on the bug-list. Tbh, I don't think LilyPond is wrong. Ofcourse I'd could be proven wrong. Cheers, Harm
