Re: Tweak Slur direction "neutral",Re: Tweak Slur direction "neutral",Re: Tweak Slur direction "neutral",Re: Tweak Slur direction "neutral"
>> But the user shouldn't see an assertion error even in case of a wrong >> argument, right? > > Yeah, > https://gitlab.com/lilypond/lilypond/-/merge_requests/1828 Thanks! Werner
Re: Tweak Slur direction "neutral", Re: Tweak Slur direction "neutral"
On 30/01/2023 08:19, Werner LEMBERG wrote: > >>> When I attempt to change the "direction" property of a slur, >>> whether that is with \tweak or \override, I cannot set the >>> direction to neutral (0). UP (1) and DOWN (-1) work fine, but when >>> setting to 0, I get the following error: >>> >>> "Assertion failed: d, file >>> /home/lily/lilypond-2.24.0/release/binaries/mingw/lilypond/lilypond-2.24.0/flower/include/drul-array.hh, >>> line 56 >>> Exited with return code 3." [...] >> >> You can see with >> >> \void \displayLilyMusic \slurNeutral >> >> that \slurNeutral is not equivalent to \override Slur.direction = >> #0, but \revert Slur.direction, which reverts Slur.direction to its >> default value #ly:slur::calc-direction. [...] > > But the user shouldn't see an assertion error even in case of a wrong > argument, right? Yeah, https://gitlab.com/lilypond/lilypond/-/merge_requests/1828 OpenPGP_signature Description: OpenPGP digital signature
Re: Tweak Slur direction "neutral", Re: Tweak Slur direction "neutral"
It think the problem here is not that the error happens, but that the error message is absolutely unusable for a user. If the error message was somthing like "direction must not be 0" it would be much clearer for the user. Still maybe this should be handled before passing this to the drul array. Cheers, Valentin Am Montag, 30. Jänner 2023, 08:19:41 CET schrieb Werner LEMBERG: > >> When I attempt to change the "direction" property of a slur, > >> whether that is with \tweak or \override, I cannot set the > >> direction to neutral (0). UP (1) and DOWN (-1) work fine, but when > >> setting to 0, I get the following error: > >> > >> > >> > >> "Assertion failed: d, file > >> /home/lily/lilypond-2.24.0/release/binaries/mingw/lilypond/lilypond-2.24 > >> .0/flower/include/drul-array.hh, line 56 Exited with return code 3." > >> [...] > > > > > > > > You can see with > > > > > > > > \void \displayLilyMusic \slurNeutral > > > > > > > > that \slurNeutral is not equivalent to \override Slur.direction = > > #0, but \revert Slur.direction, which reverts Slur.direction to its > > default value #ly:slur::calc-direction. [...] > > > But the user shouldn't see an assertion error even in case of a wrong > argument, right? > > > Werner signature.asc Description: This is a digitally signed message part.
Re: Tweak Slur direction "neutral",Re: Tweak Slur direction "neutral"
>> When I attempt to change the "direction" property of a slur, >> whether that is with \tweak or \override, I cannot set the >> direction to neutral (0). UP (1) and DOWN (-1) work fine, but when >> setting to 0, I get the following error: >> >> "Assertion failed: d, file >> /home/lily/lilypond-2.24.0/release/binaries/mingw/lilypond/lilypond-2.24.0/flower/include/drul-array.hh, >> line 56 >> Exited with return code 3." [...] > > You can see with > > \void \displayLilyMusic \slurNeutral > > that \slurNeutral is not equivalent to \override Slur.direction = > #0, but \revert Slur.direction, which reverts Slur.direction to its > default value #ly:slur::calc-direction. [...] But the user shouldn't see an assertion error even in case of a wrong argument, right? Werner
