Re: [PATCH v11] Regulator: Add Anatop regulator driver

2012-03-09 Thread Mark Brown
On Fri, Mar 09, 2012 at 03:57:09PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> From: "Ying-Chun Liu (PaulLiu)" 
> 
> Anatop is an integrated regulator inside i.MX6 SoC.
> There are 3 digital regulators which controls PU, CORE (ARM), and SOC.
> And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).
> This patch adds the Anatop regulator driver.

This looks good apart from the issue Axel noted.


signature.asc
Description: Digital signature
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev


Re: [PATCH v11] Regulator: Add Anatop regulator driver

2012-03-09 Thread Axel Lin
2012/3/9 Ying-Chun Liu (PaulLiu) :
> From: "Ying-Chun Liu (PaulLiu)" 
>
> Anatop is an integrated regulator inside i.MX6 SoC.
> There are 3 digital regulators which controls PU, CORE (ARM), and SOC.
> And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).
> This patch adds the Anatop regulator driver.
>
> Signed-off-by: Nancy Chen 
> Signed-off-by: Ying-Chun Liu (PaulLiu) 
> Acked-by: Shawn Guo 
> Cc: Mark Brown 
> Cc: Liam Girdwood 
> Cc: Samuel Ortiz 
> Cc: Jean-Christophe PLAGNIOL-VILLARD 
> Cc: Axel Lin 

The rdesc->n_voltage setting is missing.
Otherwise, Reviewed-by: Axel Lin 

___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev