[PATCH] [ACPI] utilities/: Compliment va_start() with va_end().
Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested on i386 with allyesconfig allmodconfig. utdebug.c |2 ++ utmisc.c |4 2 files changed, 6 insertions(+) diff --git a/drivers/acpi/utilities/utdebug.c b/drivers/acpi/utilities/utdebug.c index c7e128e..f45e3d5 100644 --- a/drivers/acpi/utilities/utdebug.c +++ b/drivers/acpi/utilities/utdebug.c @@ -203,6 +203,7 @@ acpi_ut_debug_print(u32 requested_debug_level, va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); } ACPI_EXPORT_SYMBOL(acpi_ut_debug_print) @@ -240,6 +241,7 @@ acpi_ut_debug_print_raw(u32 requested_debug_level, va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); } ACPI_EXPORT_SYMBOL(acpi_ut_debug_print_raw) diff --git a/drivers/acpi/utilities/utmisc.c b/drivers/acpi/utilities/utmisc.c index 2d19f71..ca4904c 100644 --- a/drivers/acpi/utilities/utmisc.c +++ b/drivers/acpi/utilities/utmisc.c @@ -1032,6 +1032,7 @@ acpi_ut_error(char *module_name, u32 line_number, char *format, ...) va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); acpi_os_printf( [%X]\n, ACPI_CA_VERSION); } @@ -1046,6 +1047,7 @@ acpi_ut_exception(char *module_name, va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); acpi_os_printf( [%X]\n, ACPI_CA_VERSION); } @@ -1060,6 +1062,7 @@ acpi_ut_warning(char *module_name, u32 line_number, char *format, ...) va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); acpi_os_printf( [%X]\n, ACPI_CA_VERSION); } @@ -1076,5 +1079,6 @@ acpi_ut_info(char *module_name, u32 line_number, char *format, ...) va_start(args, format); acpi_os_vprintf(format, args); + va_end(args); acpi_os_printf(\n); } - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.24: Serial disabled in BIOS but serial modules still loaded (probably PnP related)
On Nov 24, 2007 12:36 PM, Andrey Borzenkov [EMAIL PROTECTED] wrote:
I have no COM port on notebook (without port replicator which I do not have)
so COM is disabled in BIOS. No ttyS* is detected during boot (and no device
created) but I just noticed that serial modules are still loaded. Well, this
partially defeats the purpose of disabling COM port - the intention was to
free resources by *not* loading unneeded modules ...
This may have something to do with (ACPI) PnP which apparently believes COM
is alive.
Notebook is Toshiba Portege 4000.
{pts/0}% lsmod | grep 82
8250_pnp9792 0
8250 24660 1 8250_pnp
serial_core22872 1 8250
{pts/0}% lspnp -v
00:00 PNP0c01 System board
state = active
mem 0x0-0x9
mem 0xe-0xe
mem 0xf-0xf
mem 0x10-0x1ef5
00:01 PNP0a03 PCI bus
state = active
io 0xcf8-0xcff
00:02 PNP0200 AT DMA controller
state = active
io 0x0-0xf
io 0x81-0x83
io 0x87-0x87
io 0x89-0x8b
io 0x8f-0x8f
io 0xc0-0xdf
dma 4
00:03 PNP0800 AT speaker
state = active
io 0x61-0x61
00:04 PNP0c04 Math coprocessor
state = active
io 0xf0-0xff
irq 13
00:05 PNP0303 IBM enhanced keyboard (101/102-key, PS/2 mouse support)
state = active
io 0x60-0x60
io 0x64-0x64
irq 1
00:06 PNP0f13 PS/2 port for PS/2-style mice
state = active
irq 12
00:07 PNP0b00 AT real-time clock
state = active
io 0x70-0x71
irq 8
00:08 PNP0c02 Motherboard resources
state = active
io 0x2e-0x2f
io 0x62-0x62
io 0x66-0x66
io 0x80-0x80
io 0x84-0x86
io 0x88-0x88
io 0x8c-0x8e
io 0x92-0x92
00:09 PNP0501 16550A-compatible serial port
state = active
io 0x3f8-0x3ff
irq 5
00:0a SMCf010 SMC Fast Infrared Port
state = disabled
00:0b PNP0401 ECP printer port
state = disabled
..
[ 126.035809] Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ
sharing enabled
...
[ 126.107096] serial 00:09: activated
...
Can you cat /sys/firmware/acpi/DSDT and use iasl to decode it?
it seems that your BIOS has problem about com setup.
YH
-
To unsubscribe from this list: send the line unsubscribe linux-acpi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
No blacklight Re: [patch] remove debug info in acpi video
Since I begging to see this message on dmesg , when i press lid button , I don't have black light On Tue, 2007-11-13 at 10:36 +0800, Zhang Rui wrote: On Tue, 2007-11-13 at 08:50 +0800, Zhenyu Wang wrote: Remove acpi video debug message. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] Acked-by: Zhang Rui [EMAIL PROTECTED] --- drivers/acpi/video.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index bac956b..9c8c8e6 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -1782,9 +1782,6 @@ static void acpi_video_bus_notify(acpi_handle handle, u32 event, void *data) struct input_dev *input; int keycode; - - printk(video bus notify\n); - if (!video) return; -- 1.5.3.3 - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sérgio M. B. smime.p7s Description: S/MIME cryptographic signature
Re: 2.6.24: Serial disabled in BIOS but serial modules still loaded (probably PnP related)
On Sat, 2007-11-24 at 23:36 +0300, Andrey Borzenkov wrote: I have no COM port on notebook (without port replicator which I do not have) so COM is disabled in BIOS. No ttyS* is detected during boot (and no device created) but I just noticed that serial modules are still loaded. Well, this partially defeats the purpose of disabling COM port - the intention was to free resources by *not* loading unneeded modules ... This may have something to do with (ACPI) PnP which apparently believes COM is alive. Notebook is Toshiba Portege 4000. Nice... What's this then? 00:09 PNP0501 16550A-compatible serial port state = active io 0x3f8-0x3ff irq 5 0x3f8-0x3ff is COM1 and a 16550A is the most common invocation of the vernerable serial port. I haven't seen a real 8250 in ages. the 16550 is an 8250 with larger FIFO's and better rates. Now, it's on IRQ5 instead of IRQ4 but that's all allocatable on PCI. Unless I'm missing something, it looks like you've got a COM port and it looks like it's active. Might be related to an IR port? 00:0a SMCf010 SMC Fast Infrared Port state = disabled 00:0b PNP0401 ECP printer port state = disabled : Mike -- Michael H. Warfield (AI4NB) | (770) 985-6132 | [EMAIL PROTECTED] /\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/ NIC whois: MHW9 | An optimist believes we live in the best of all PGP Key: 0xDF1DD471| possible worlds. A pessimist is sure of it! signature.asc Description: This is a digitally signed message part
Re: 2.6.24: Serial disabled in BIOS but serial modules still loaded (probably PnP related)
Michael H. Warfield wrote: On Sat, 2007-11-24 at 23:36 +0300, Andrey Borzenkov wrote: I have no COM port on notebook (without port replicator which I do not have) so COM is disabled in BIOS. No ttyS* is detected during boot (and no device created) but I just noticed that serial modules are still loaded. Well, this partially defeats the purpose of disabling COM port - the intention was to free resources by *not* loading unneeded modules ... This may have something to do with (ACPI) PnP which apparently believes COM is alive. Notebook is Toshiba Portege 4000. Nice... What's this then? 00:09 PNP0501 16550A-compatible serial port state = active io 0x3f8-0x3ff irq 5 This doesn't mean that a port (ie connector) is present. My notebook also has the electronics without the physical connector. - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
