Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On Tue, Aug 02, 2011 at 02:30:18PM +0530, Anirudh Ghayal wrote: > Hi Dmitry, > > On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: > >On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: > > > >>Yes should have been dev_err. > >> > >>Dmitry, would you like me to submit another patch for this? I can > >>make the @work change as well. Or would you make this minor change > >>as well. Thank you. > >> > > > >Anirudh, I made this plus a few more cosmetic changes, if you could try > >the patch below and let me know if it still works I will commit it for > >the next merge window. > > > > Thank you for making changes. I have tested the patch and it works fine. > Thank you, I queued it for 3.2. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS initialization
> -Original Message-
> From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm-
> ow...@vger.kernel.org] On Behalf Of Nath, Arindam
> Sent: Tuesday, August 02, 2011 3:21 PM
> To: Subhash Jadavani; 'Chris Ball'
> Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; 'Philip
> Rakity'; 'zhangfei gao'
> Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS
> initialization
>
>
>
> > -Original Message-
> > From: Subhash Jadavani [mailto:subha...@codeaurora.org]
> > Sent: Tuesday, August 02, 2011 2:43 PM
> > To: Nath, Arindam; 'Chris Ball'
> > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; 'Philip
> > Rakity'; 'zhangfei gao'
> > Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in
> UHS
> > initialization
> >
> > Hi Arindam,
> >
> > Thank you for the review. Please find few comments inline.
> >
> > > -Original Message-
> > > From: Nath, Arindam [mailto:arindam.n...@amd.com]
> > > Sent: Tuesday, August 02, 2011 12:38 PM
> > > To: Chris Ball; Subhash Jadavani
> > > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org;
> Philip
> > > Rakity; zhangfei gao
> > > Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in
> > UHS
> > > initialization
> > >
> > > Hi Subhash,
> > >
> > >
> > > > -Original Message-
> > > > From: Chris Ball [mailto:c...@laptop.org]
> > > > Sent: Tuesday, August 02, 2011 1:40 AM
> > > > To: Subhash Jadavani
> > > > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org;
> Nath,
> > > > Arindam
> > > > Subject: Re: [PATCH] mmc: sd: UHS-I bus speed should be set last
> in
> > > UHS
> > > > initialization
> > > >
> > > > Hi Subhash, adding Arindam for review,
> > > >
> > > > On Mon, Aug 01 2011, Subhash Jadavani wrote:
> > > > > mmc_sd_init_uhs_card function sets the driver type, current
> limit
> > > > > and bus speed mode on card as well as on host controller side.
> > > > >
> > > > > Currently bus speed mode is set by sending CMD6 to card and
> > > > > immediately setting the timing mode in host controller. But
> > > > > then before initiating tuning sequence, it also tries to set
> > > > > current limit by sending CMD6 to card which results in data
> > > > > timeout errors in controller if bus speed mode is SDR50/SDR104
> > > mode.
> > > > >
> > > > > So basically bus speed mode should be set only after current
> > limit
> > > > > is set in the card and immediately after setting the bus speed
> > > mode,
> > > > > tuning sequence should be initiated.
> > > > >
> > > > > Signed-off-by: Subhash Jadavani
> > > > > ---
> > > > > drivers/mmc/core/sd.c | 57 -
> --
> > --
> > > --
> > > > -
> > > > > 1 files changed, 38 insertions(+), 19 deletions(-)
> > > > >
> > > > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> > > > > index ff27741..d257496 100644
> > > > > --- a/drivers/mmc/core/sd.c
> > > > > +++ b/drivers/mmc/core/sd.c
> > > > > @@ -459,10 +459,9 @@ static int sd_select_driver_type(struct
> > > mmc_card
> > > > *card, u8 *status)
> > > > > return 0;
> > > > > }
> > > > >
> > > > > -static int sd_set_bus_speed_mode(struct mmc_card *card, u8
> > > *status)
> > > > > +static int sd_get_bus_speed_mode(struct mmc_card *card)
> > > > > {
> > > > > - unsigned int bus_speed = 0, timing = 0;
> > > > > - int err;
> > > > > + int bus_speed = 0;
> > > > >
> > > > > /*
> > > > >* If the host doesn't support any of the UHS-I modes,
> > fallback
> > > > on
> > > > > @@ -470,37 +469,56 @@ static int sd_set_bus_speed_mode(struct
> > > > mmc_card *card, u8 *status)
> > > > >*/
> > > > > if (!(card->host->caps & (MMC_CAP_UHS_SDR12 |
> > MMC_CAP_UHS_SDR25 |
> > > > > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 |
> > MMC_CAP_UHS_DDR50)))
> > > > > - return 0;
> > > > > + return -EINVAL;
> > >
> > > We should not return -EINVAL here, because this is not an error
> > > condition. This would simply mean that the card and host controller
> > > will fall back to using the default bus speed, and should still be
> > > operable. Check the comment below too.
> >
> > Return value of this function gets used in sd_set_bus_speed_mode()
> > function
> > and compared against all the valid bus speed modes. If we choose to
> > return 0
> > from here then '0' corresponds to valid bus speed mode
> > 'UHS_SDR12_BUS_SPEED'.
> >
> > #define UHS_SDR12_BUS_SPEED 0
> > #define UHS_SDR25_BUS_SPEED 1
> > #define UHS_SDR50_BUS_SPEED 2
> > #define UHS_SDR104_BUS_SPEED3
> > #define UHS_DDR50_BUS_SPEED 4
> >
> > If we don't want to return the error value from this function then we
> > can
> > basically remove following check from this *get* function and move it
> > to
> > each *set* function before calling *get*. Please see more comments
> > inline in
> > *set* functions below.
> >
> > if (!(card->host->caps & (MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25 |
> > M
RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS initialization
> -Original Message-
> From: Subhash Jadavani [mailto:subha...@codeaurora.org]
> Sent: Tuesday, August 02, 2011 2:43 PM
> To: Nath, Arindam; 'Chris Ball'
> Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; 'Philip
> Rakity'; 'zhangfei gao'
> Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS
> initialization
>
> Hi Arindam,
>
> Thank you for the review. Please find few comments inline.
>
> > -Original Message-
> > From: Nath, Arindam [mailto:arindam.n...@amd.com]
> > Sent: Tuesday, August 02, 2011 12:38 PM
> > To: Chris Ball; Subhash Jadavani
> > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; Philip
> > Rakity; zhangfei gao
> > Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in
> UHS
> > initialization
> >
> > Hi Subhash,
> >
> >
> > > -Original Message-
> > > From: Chris Ball [mailto:c...@laptop.org]
> > > Sent: Tuesday, August 02, 2011 1:40 AM
> > > To: Subhash Jadavani
> > > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; Nath,
> > > Arindam
> > > Subject: Re: [PATCH] mmc: sd: UHS-I bus speed should be set last in
> > UHS
> > > initialization
> > >
> > > Hi Subhash, adding Arindam for review,
> > >
> > > On Mon, Aug 01 2011, Subhash Jadavani wrote:
> > > > mmc_sd_init_uhs_card function sets the driver type, current limit
> > > > and bus speed mode on card as well as on host controller side.
> > > >
> > > > Currently bus speed mode is set by sending CMD6 to card and
> > > > immediately setting the timing mode in host controller. But
> > > > then before initiating tuning sequence, it also tries to set
> > > > current limit by sending CMD6 to card which results in data
> > > > timeout errors in controller if bus speed mode is SDR50/SDR104
> > mode.
> > > >
> > > > So basically bus speed mode should be set only after current
> limit
> > > > is set in the card and immediately after setting the bus speed
> > mode,
> > > > tuning sequence should be initiated.
> > > >
> > > > Signed-off-by: Subhash Jadavani
> > > > ---
> > > > drivers/mmc/core/sd.c | 57 ---
> --
> > --
> > > -
> > > > 1 files changed, 38 insertions(+), 19 deletions(-)
> > > >
> > > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> > > > index ff27741..d257496 100644
> > > > --- a/drivers/mmc/core/sd.c
> > > > +++ b/drivers/mmc/core/sd.c
> > > > @@ -459,10 +459,9 @@ static int sd_select_driver_type(struct
> > mmc_card
> > > *card, u8 *status)
> > > > return 0;
> > > > }
> > > >
> > > > -static int sd_set_bus_speed_mode(struct mmc_card *card, u8
> > *status)
> > > > +static int sd_get_bus_speed_mode(struct mmc_card *card)
> > > > {
> > > > - unsigned int bus_speed = 0, timing = 0;
> > > > - int err;
> > > > + int bus_speed = 0;
> > > >
> > > > /*
> > > > * If the host doesn't support any of the UHS-I modes,
> fallback
> > > on
> > > > @@ -470,37 +469,56 @@ static int sd_set_bus_speed_mode(struct
> > > mmc_card *card, u8 *status)
> > > > */
> > > > if (!(card->host->caps & (MMC_CAP_UHS_SDR12 |
> MMC_CAP_UHS_SDR25 |
> > > > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 |
> MMC_CAP_UHS_DDR50)))
> > > > - return 0;
> > > > + return -EINVAL;
> >
> > We should not return -EINVAL here, because this is not an error
> > condition. This would simply mean that the card and host controller
> > will fall back to using the default bus speed, and should still be
> > operable. Check the comment below too.
>
> Return value of this function gets used in sd_set_bus_speed_mode()
> function
> and compared against all the valid bus speed modes. If we choose to
> return 0
> from here then '0' corresponds to valid bus speed mode
> 'UHS_SDR12_BUS_SPEED'.
>
> #define UHS_SDR12_BUS_SPEED 0
> #define UHS_SDR25_BUS_SPEED 1
> #define UHS_SDR50_BUS_SPEED 2
> #define UHS_SDR104_BUS_SPEED3
> #define UHS_DDR50_BUS_SPEED 4
>
> If we don't want to return the error value from this function then we
> can
> basically remove following check from this *get* function and move it
> to
> each *set* function before calling *get*. Please see more comments
> inline in
> *set* functions below.
>
> if (!(card->host->caps & (MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25 |
> MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 | MMC_CAP_UHS_DDR50)))
> return -EINVAL;
By *Default Bus Speed*, I meant speed corresponding to SDR12. So if we return 0
from sd_get_bus_speed_mode(), that would make sure that your modified
sd_set_bus_speed_mode() correctly executes the last *else if* condition, and
we set the default speed. So I don't think we will need to return -EINVAL.
>
> >
> > > >
> > > > if ((card->host->caps & MMC_CAP_UHS_SDR104) &&
> > > > (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR104)) {
> > > > bus_speed = UHS_SDR104_BUS_SPEED;
> > > > - t
RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS initialization
Hi Arindam,
Thank you for the review. Please find few comments inline.
> -Original Message-
> From: Nath, Arindam [mailto:arindam.n...@amd.com]
> Sent: Tuesday, August 02, 2011 12:38 PM
> To: Chris Ball; Subhash Jadavani
> Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; Philip
> Rakity; zhangfei gao
> Subject: RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS
> initialization
>
> Hi Subhash,
>
>
> > -Original Message-
> > From: Chris Ball [mailto:c...@laptop.org]
> > Sent: Tuesday, August 02, 2011 1:40 AM
> > To: Subhash Jadavani
> > Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; Nath,
> > Arindam
> > Subject: Re: [PATCH] mmc: sd: UHS-I bus speed should be set last in
> UHS
> > initialization
> >
> > Hi Subhash, adding Arindam for review,
> >
> > On Mon, Aug 01 2011, Subhash Jadavani wrote:
> > > mmc_sd_init_uhs_card function sets the driver type, current limit
> > > and bus speed mode on card as well as on host controller side.
> > >
> > > Currently bus speed mode is set by sending CMD6 to card and
> > > immediately setting the timing mode in host controller. But
> > > then before initiating tuning sequence, it also tries to set
> > > current limit by sending CMD6 to card which results in data
> > > timeout errors in controller if bus speed mode is SDR50/SDR104
> mode.
> > >
> > > So basically bus speed mode should be set only after current limit
> > > is set in the card and immediately after setting the bus speed
> mode,
> > > tuning sequence should be initiated.
> > >
> > > Signed-off-by: Subhash Jadavani
> > > ---
> > > drivers/mmc/core/sd.c | 57 -
> --
> > -
> > > 1 files changed, 38 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> > > index ff27741..d257496 100644
> > > --- a/drivers/mmc/core/sd.c
> > > +++ b/drivers/mmc/core/sd.c
> > > @@ -459,10 +459,9 @@ static int sd_select_driver_type(struct
> mmc_card
> > *card, u8 *status)
> > > return 0;
> > > }
> > >
> > > -static int sd_set_bus_speed_mode(struct mmc_card *card, u8
> *status)
> > > +static int sd_get_bus_speed_mode(struct mmc_card *card)
> > > {
> > > - unsigned int bus_speed = 0, timing = 0;
> > > - int err;
> > > + int bus_speed = 0;
> > >
> > > /*
> > >* If the host doesn't support any of the UHS-I modes, fallback
> > on
> > > @@ -470,37 +469,56 @@ static int sd_set_bus_speed_mode(struct
> > mmc_card *card, u8 *status)
> > >*/
> > > if (!(card->host->caps & (MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25 |
> > > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 | MMC_CAP_UHS_DDR50)))
> > > - return 0;
> > > + return -EINVAL;
>
> We should not return -EINVAL here, because this is not an error
> condition. This would simply mean that the card and host controller
> will fall back to using the default bus speed, and should still be
> operable. Check the comment below too.
Return value of this function gets used in sd_set_bus_speed_mode() function
and compared against all the valid bus speed modes. If we choose to return 0
from here then '0' corresponds to valid bus speed mode
'UHS_SDR12_BUS_SPEED'.
#define UHS_SDR12_BUS_SPEED 0
#define UHS_SDR25_BUS_SPEED 1
#define UHS_SDR50_BUS_SPEED 2
#define UHS_SDR104_BUS_SPEED3
#define UHS_DDR50_BUS_SPEED 4
If we don't want to return the error value from this function then we can
basically remove following check from this *get* function and move it to
each *set* function before calling *get*. Please see more comments inline in
*set* functions below.
if (!(card->host->caps & (MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25 |
MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 | MMC_CAP_UHS_DDR50)))
return -EINVAL;
>
> > >
> > > if ((card->host->caps & MMC_CAP_UHS_SDR104) &&
> > > (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR104)) {
> > > bus_speed = UHS_SDR104_BUS_SPEED;
> > > - timing = MMC_TIMING_UHS_SDR104;
> > > - card->sw_caps.uhs_max_dtr = UHS_SDR104_MAX_DTR;
> > > } else if ((card->host->caps & MMC_CAP_UHS_DDR50) &&
> > > (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_DDR50)) {
> > > bus_speed = UHS_DDR50_BUS_SPEED;
> > > - timing = MMC_TIMING_UHS_DDR50;
> > > - card->sw_caps.uhs_max_dtr = UHS_DDR50_MAX_DTR;
> > > } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> > > MMC_CAP_UHS_SDR50)) && (card->sw_caps.sd3_bus_mode &
> > > SD_MODE_UHS_SDR50)) {
> > > bus_speed = UHS_SDR50_BUS_SPEED;
> > > - timing = MMC_TIMING_UHS_SDR50;
> > > - card->sw_caps.uhs_max_dtr = UHS_SDR50_MAX_DTR;
> > > } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> > > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR25)) &&
> > > (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR25)) {
> > >
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
Hi Dmitry, On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well. Thank you. Anirudh, I made this plus a few more cosmetic changes, if you could try the patch below and let me know if it still works I will commit it for the next merge window. Thank you for making changes. I have tested the patch and it works fine. Thank you, ~Anirudh Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS initialization
Hi Subhash,
> -Original Message-
> From: Chris Ball [mailto:c...@laptop.org]
> Sent: Tuesday, August 02, 2011 1:40 AM
> To: Subhash Jadavani
> Cc: linux-...@vger.kernel.org; linux-arm-msm@vger.kernel.org; Nath,
> Arindam
> Subject: Re: [PATCH] mmc: sd: UHS-I bus speed should be set last in UHS
> initialization
>
> Hi Subhash, adding Arindam for review,
>
> On Mon, Aug 01 2011, Subhash Jadavani wrote:
> > mmc_sd_init_uhs_card function sets the driver type, current limit
> > and bus speed mode on card as well as on host controller side.
> >
> > Currently bus speed mode is set by sending CMD6 to card and
> > immediately setting the timing mode in host controller. But
> > then before initiating tuning sequence, it also tries to set
> > current limit by sending CMD6 to card which results in data
> > timeout errors in controller if bus speed mode is SDR50/SDR104 mode.
> >
> > So basically bus speed mode should be set only after current limit
> > is set in the card and immediately after setting the bus speed mode,
> > tuning sequence should be initiated.
> >
> > Signed-off-by: Subhash Jadavani
> > ---
> > drivers/mmc/core/sd.c | 57 ---
> -
> > 1 files changed, 38 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> > index ff27741..d257496 100644
> > --- a/drivers/mmc/core/sd.c
> > +++ b/drivers/mmc/core/sd.c
> > @@ -459,10 +459,9 @@ static int sd_select_driver_type(struct mmc_card
> *card, u8 *status)
> > return 0;
> > }
> >
> > -static int sd_set_bus_speed_mode(struct mmc_card *card, u8 *status)
> > +static int sd_get_bus_speed_mode(struct mmc_card *card)
> > {
> > - unsigned int bus_speed = 0, timing = 0;
> > - int err;
> > + int bus_speed = 0;
> >
> > /*
> > * If the host doesn't support any of the UHS-I modes, fallback
> on
> > @@ -470,37 +469,56 @@ static int sd_set_bus_speed_mode(struct
> mmc_card *card, u8 *status)
> > */
> > if (!(card->host->caps & (MMC_CAP_UHS_SDR12 | MMC_CAP_UHS_SDR25 |
> > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104 | MMC_CAP_UHS_DDR50)))
> > - return 0;
> > + return -EINVAL;
We should not return -EINVAL here, because this is not an error condition. This
would simply mean that the card and host controller will fall back to using the
default bus speed, and should still be operable. Check the comment below too.
> >
> > if ((card->host->caps & MMC_CAP_UHS_SDR104) &&
> > (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR104)) {
> > bus_speed = UHS_SDR104_BUS_SPEED;
> > - timing = MMC_TIMING_UHS_SDR104;
> > - card->sw_caps.uhs_max_dtr = UHS_SDR104_MAX_DTR;
> > } else if ((card->host->caps & MMC_CAP_UHS_DDR50) &&
> >(card->sw_caps.sd3_bus_mode & SD_MODE_UHS_DDR50)) {
> > bus_speed = UHS_DDR50_BUS_SPEED;
> > - timing = MMC_TIMING_UHS_DDR50;
> > - card->sw_caps.uhs_max_dtr = UHS_DDR50_MAX_DTR;
> > } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> > MMC_CAP_UHS_SDR50)) && (card->sw_caps.sd3_bus_mode &
> > SD_MODE_UHS_SDR50)) {
> > bus_speed = UHS_SDR50_BUS_SPEED;
> > - timing = MMC_TIMING_UHS_SDR50;
> > - card->sw_caps.uhs_max_dtr = UHS_SDR50_MAX_DTR;
> > } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR25)) &&
> >(card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR25)) {
> > bus_speed = UHS_SDR25_BUS_SPEED;
> > - timing = MMC_TIMING_UHS_SDR25;
> > - card->sw_caps.uhs_max_dtr = UHS_SDR25_MAX_DTR;
> > } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> > MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR25 |
> > MMC_CAP_UHS_SDR12)) && (card->sw_caps.sd3_bus_mode &
> > SD_MODE_UHS_SDR12)) {
> > bus_speed = UHS_SDR12_BUS_SPEED;
> > + }
> > +
> > + return bus_speed;
> > +}
> > +
> > +static int sd_set_bus_speed_mode(struct mmc_card *card, u8 *status)
> > +{
> > + int err, bus_speed;
> > + unsigned int timing = 0;
> > +
> > + bus_speed = sd_get_bus_speed_mode(card);
> > +
> > + if (bus_speed == UHS_SDR104_BUS_SPEED) {
> > + timing = MMC_TIMING_UHS_SDR104;
> > + card->sw_caps.uhs_max_dtr = UHS_SDR104_MAX_DTR;
> > + } else if (bus_speed == UHS_DDR50_BUS_SPEED) {
> > + timing = MMC_TIMING_UHS_DDR50;
> > + card->sw_caps.uhs_max_dtr = UHS_DDR50_MAX_DTR;
> > + } else if (bus_speed == UHS_SDR50_BUS_SPEED) {
> > + timing = MMC_TIMING_UHS_SDR50;
> > + card->sw_caps.uhs_max_dtr = UHS_SDR50_MAX_DTR;
> > + } else if (bus_speed == UHS_SDR25_BUS_SPEED) {
> > + timing = MMC_TIMING_UHS_SDR25;
>
