Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE
On Mon, 2010-12-20 at 15:42 -0800, David Brown wrote: > On Mon, Dec 20, 2010 at 03:39:10PM -0800, Daniel Walker wrote: > > > I this feature even used? It looks like some kind debug feature. > > > > Yeah it's used, it's default on.. > > What I meant was "is there any reason to be able to turn this off." > It looks like something that would be used during development, and > doesn't need to be disabled once the driver works. I have no idea. I'm just doing a clean up here .. It's on, it's got a config to turn it off, as far as I know it's used and useful. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE
On Mon, Dec 20, 2010 at 03:39:10PM -0800, Daniel Walker wrote: > > I this feature even used? It looks like some kind debug feature. > > Yeah it's used, it's default on.. What I meant was "is there any reason to be able to turn this off." It looks like something that would be used during development, and doesn't need to be disabled once the driver works. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE
On Mon, 2010-12-20 at 15:35 -0800, David Brown wrote: > On Mon, Dec 20, 2010 at 03:16:47PM -0800, Daniel Walker wrote: > > > It's cleaner to have ifdef's consolidated in one specific > > area. This change pulls adds one ifdef which will swap > > out of the function with a stub function if the ifdef is > > false. > > It also changes the define from #if checks to #ifdef which changes how > it would be used. True, but it's defined in the code. So you have to comment the line out now instead of change it to "0" .. > I this feature even used? It looks like some kind debug feature. Yeah it's used, it's default on.. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE
On Mon, Dec 20, 2010 at 03:16:47PM -0800, Daniel Walker wrote: > It's cleaner to have ifdef's consolidated in one specific > area. This change pulls adds one ifdef which will swap > out of the function with a stub function if the ifdef is > false. It also changes the define from #if checks to #ifdef which changes how it would be used. I this feature even used? It looks like some kind debug feature. David -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
