Re: [PATCH 0/2] security/smack implement logging V3

2009-04-13 Thread James Morris
On Wed, 8 Apr 2009, Etienne Basset wrote:

> Hello,
> 
> the following 2 patches implements auditing of security events for Smack.
> 
> patch 1 : created common LSM auditing code 
> patch 2 : convert smack to use it

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

Note:

Please ensure that each patch has a distinct and descriptive subject line.

Also, the format for the subject is:

  [PATCH x/y] subsystem: short description

See section 15 of Documentation/SubmittingPatches.


-- 
James Morris


--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


[PATCH 0/2] security/smack implement logging V3

2009-04-08 Thread Etienne Basset
Hello,

the following 2 patches implements auditing of security events for Smack.

patch 1 : created common LSM auditing code 
patch 2 : convert smack to use it

Changes since V2 :
- don't make Smack depend on AUDIT
I tried to make it zero overhead in the !CONFIG_AUDIT case,
without making the code too ugly (??). I hope i didn't mess it too much
- makes everything a key=value pair
- various other cleanup suggested by Eric and Casey 

Change since V1 :
moves shareable code to include/linux/lsm_audit.h and security/lsm_audit.c.
Smack specific logging functions are now defined in smack_access.c


sample logs produced :
type=1400 audit(1239127887.607:13): lsm=SMACK fn=smack_sb_mount action=denied 
subject="FOO" object="_" requested=w pid=6693 comm="mount" path="/debug" 
dev=sda5 ino=16161
type=1400 audit(1239127890.267:14): lsm=SMACK fn=smack_ptrace_may_access 
action=denied subject="FOO" object="_" requested=rw pid=6696 comm="ps" pid=6380 
comm="bash"
type=1400 audit(1239127895.051:20): lsm=SMACK fn=smack_task_kill action=denied 
subject="FOO" object="_" requested=w pid=6646 comm="bash" pid=6606 
comm="thunderbird-bin"
type=1400 audit(1239127908.555:21): lsm=SMACK fn=smack_inode_getattr 
action=denied subject="FOO" object="etienne" requested=r pid=6646 comm="bash" 
path="/home/etienne/Desktop" dev=sda8 ino=1237000
type=1400 audit(1239127909.223:22): lsm=SMACK fn=smack_inode_permission 
action=denied subject="FOO" object="_" requested=wx pid=6699 comm="rm" 
name="etienne" dev=sda8 ino=1236993
type=1400 audit(1239128125.263:24): lsm=SMACK fn=smack_netlabel_send 
action=denied subject="FOO" object="BAR" requested=w pid=6757 comm="telnet" 
daddr=212.180.1.1 dest=80



--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit