Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe <ax...@kernel.dk>
Date: Tue, 15 May 2018 13:00:36 -0600

> On 5/15/18 12:58 PM, David Miller wrote:
>> From: Jens Axboe <ax...@kernel.dk>
>> Date: Tue, 15 May 2018 12:51:20 -0600
>> 
>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>> No bio in this whole function, use req->bio instead.
>>>
>>> Applied.
>>>
>>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>>> should just get rid of the driver given that it doesn't look in a good
>>>> shape at all based on his build logs even with the fix..
>>>
>>> Needs input from the folks that actually might use it. The driver looks
>>> abandoned, it's only getting updates through API changes etc.
>> 
>> I don't think anyone is using it.
> 
> Are you fine with removing it then?

Yes, I am:

Acked-by: David S. Miller <da...@davemloft.net>

Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe 
Date: Tue, 15 May 2018 12:51:20 -0600

> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>> No bio in this whole function, use req->bio instead.
> 
> Applied.
> 
>> Looks like no one except for Guenters build bot cared.  I wonder if we
>> should just get rid of the driver given that it doesn't look in a good
>> shape at all based on his build logs even with the fix..
> 
> Needs input from the folks that actually might use it. The driver looks
> abandoned, it's only getting updates through API changes etc.

I don't think anyone is using it.

Re: [PATCH 01/12] iommu-common: move to arch/sparc

[David Miller]

From: Anshuman Khandual 
Date: Mon, 16 Apr 2018 14:26:07 +0530

> On 04/15/2018 08:29 PM, Christoph Hellwig wrote:
>> This code is only used by sparc, and all new iommu drivers should use the
>> drivers/iommu/ framework.  Also remove the unused exports.
>> 
>> Signed-off-by: Christoph Hellwig 
> 
> Right, these functions are used only from SPARC architecture. Simple
> git grep confirms it as well. Hence it makes sense to move them into
> arch code instead.

Well, we put these into a common location and used type friendly for
powerpc because we hoped powerpc would convert over to using this
common piece of code as well.

But nobody did the powerpc work.

If you look at the powerpc iommu support, it's the same code basically
for entry allocation.

Re: [PATCH v6 7/9] ide, scsi: Tell the block layer at request allocation time about preempt requests

[David Miller]

From: Bart Van Assche 
Date: Wed,  4 Oct 2017 17:01:08 -0700

> Convert blk_get_request(q, op, __GFP_RECLAIM) into blk_get_request(q,
> op, BLK_MQ_PREEMPT). This patch does not change any functionality.
> 
> Signed-off-by: Bart Van Assche 
> Cc: Martin K. Petersen 
> Cc: David S. Miller 
> Cc: Ming Lei 
> Cc: Christoph Hellwig 
> Cc: Hannes Reinecke 
> Cc: Johannes Thumshirn 

For IDE:

Acked-by: David S. Miller 

Re: [PATCH 4/6] qlogic: make device_attribute const

[David Miller]

From: Bhumika Goyal 
Date: Mon, 21 Aug 2017 17:13:10 +0530

> Make these const as they are only passed as an argument to the
> function device_create_file and device_remove_file and the corresponding
> arguments are of type const.
> Done using Coccinelle
> 
> Signed-off-by: Bhumika Goyal 

Applied.

But I would seriously suggest that when you have to cross subsystems
like this, just send the patches individually to the respective
maintainers rather than trying to make a "series" out of it.

Thanks.

Re: [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi()

[David Miller]

From: Bart Van Assche 
Date: Thu, 17 Aug 2017 16:23:07 -0700

> This patch does not change any functionality.
> 
> Signed-off-by: Bart Van Assche 

Acked-by: David S. Miller 

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

[David Miller]

From: Christoph Hellwig 
Date: Wed, 26 Apr 2017 09:34:22 +0200

> The caller only looks at the scsi_request result field anyway.
> 
> Signed-off-by: Christoph Hellwig 

Acked-by: David S. Miller 

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

[David Miller]

From: Christoph Hellwig 
Date: Wed, 26 Apr 2017 09:34:21 +0200

> ide_pm_execute_rq exectures a PM request synchronously, and in the failure
> case where it calls __blk_end_request_all it never checks the error field
> passed to the end_io callback, so don't bother setting it.
> 
> Signed-off-by: Christoph Hellwig 

Acked-by: David S. Miller 

Re: [PATCH 09/10] ide: don't abuse cmd_type

[David Miller]

From: Christoph Hellwig 
Date: Tue, 31 Jan 2017 16:57:30 +0100

> Currently the legacy ide driver defines several request types of it's own,
> which is in the way of removing that field entirely.
> 
> Instead add a type field to struct ide_request and use that to distinguish
> the different types of IDE-internal requests.
> 
> It's a bit of a mess, but so is the surrounding code..
> 
> Signed-off-by: Christoph Hellwig 

Acked-by: David S. Miller 
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html