Re: [PATCH] block: remove blk_free_devt in add_partition

2017-08-24 Thread Jens Axboe 
On 08/18/2017 09:54 AM, weiping zhang wrote:
> put_device(pdev) will call pdev->type->release finally, and blk_free_devt
> has been called in part_release(), so remove it.

Your analysis looks correct to me, applied for 4.14.

-- 
Jens Axboe

Re: [PATCH] block: remove blk_free_devt in add_partition

2017-08-24 Thread weiping zhang 
On Fri, Aug 18, 2017 at 11:54:45PM +0800, weiping zhang wrote:
> put_device(pdev) will call pdev->type->release finally, and blk_free_devt
> has been called in part_release(), so remove it.
> 
> Signed-off-by: weiping zhang 
> ---
>  block/partition-generic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/partition-generic.c b/block/partition-generic.c
> index c5ec824..04d82dd 100644
> --- a/block/partition-generic.c
> +++ b/block/partition-generic.c
> @@ -391,7 +391,6 @@ struct hd_struct *add_partition(struct gendisk *disk, int 
> partno,
>   device_del(pdev);
>  out_put:
>   put_device(pdev);
> - blk_free_devt(devt);
>   return ERR_PTR(err);
>  }
>  
> -- 
> 2.9.4
> 

Hi Jens,

would you please look this trivial patch at your convenience?

Thanks

[PATCH] block: remove blk_free_devt in add_partition

2017-08-18 Thread weiping zhang 
put_device(pdev) will call pdev->type->release finally, and blk_free_devt
has been called in part_release(), so remove it.

Signed-off-by: weiping zhang 
---
 block/partition-generic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/partition-generic.c b/block/partition-generic.c
index c5ec824..04d82dd 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -391,7 +391,6 @@ struct hd_struct *add_partition(struct gendisk *disk, int 
partno,
device_del(pdev);
 out_put:
put_device(pdev);
-   blk_free_devt(devt);
return ERR_PTR(err);
 }
 
-- 
2.9.4