Re: [PATCH 0/8] blk-mq: fix and improve queue mapping

[Stefan Haberland]

On 08.04.2018 11:48, Ming Lei wrote:

Hi Jens,

The first two patches fix issues about queue mapping.

The other 6 patches improve queue mapping for blk-mq.

Christian, this patches should fix your issue, so please give
a test, and the patches can be found in the following tree:

https://github.com/ming1/linux/commits/v4.17-rc-blk-fix_mapping_v1

Thanks,
Ming


Hi Ming,

thanks for the patches.
Unfortunately I was not able to try them with your git tree since I ran 
into the same problem, that Li Wang reported today.
But your patches applied to our local git tree seem to work fine. A 
small DASD regression test showed no issues or warnings.


Regards,
Stefan

Re: [PATCH 0/8] blk-mq: fix and improve queue mapping

[Jens Axboe]

On 4/8/18 3:48 AM, Ming Lei wrote:
> Hi Jens,
> 
> The first two patches fix issues about queue mapping.
> 
> The other 6 patches improve queue mapping for blk-mq.
> 
> Christian, this patches should fix your issue, so please give
> a test, and the patches can be found in the following tree:
> 
>   https://github.com/ming1/linux/commits/v4.17-rc-blk-fix_mapping_v1
> 
> Thanks,
> Ming
> 
> Ming Lei (8):
>   blk-mq: make sure that correct hctx->next_cpu is set
>   blk-mq: don't keep offline CPUs mapped to hctx 0
>   blk-mq: avoid to write intermediate result to hctx->next_cpu
>   blk-mq: introduce blk_mq_hw_queue_first_cpu() to figure out first cpu
>   blk-mq: remove blk_mq_delay_queue()
>   blk-mq: don't check queue mapped in __blk_mq_delay_run_hw_queue()
>   blk-mq: reimplement blk_mq_hw_queue_mapped
>   blk-mq: remove code for dealing with remapping queue

Thanks Ming, applied for this series.

-- 
Jens Axboe

Re: [PATCH 0/8] blk-mq: fix and improve queue mapping

[Christian Borntraeger]

On 04/08/2018 11:48 AM, Ming Lei wrote:
> Hi Jens,
> 
> The first two patches fix issues about queue mapping.

> 
> The other 6 patches improve queue mapping for blk-mq.
> 
> Christian, this patches should fix your issue, so please give
> a test, and the patches can be found in the following tree:
> 
>   https://github.com/ming1/linux/commits/v4.17-rc-blk-fix_mapping_v1

Looks good. With all patches applied, I can no longer reproduce any warning 
message.
Tested-by: Christian Borntraeger 

> 
> Thanks,
> Ming
> 
> Ming Lei (8):
>   blk-mq: make sure that correct hctx->next_cpu is set
>   blk-mq: don't keep offline CPUs mapped to hctx 0
>   blk-mq: avoid to write intermediate result to hctx->next_cpu
>   blk-mq: introduce blk_mq_hw_queue_first_cpu() to figure out first cpu
>   blk-mq: remove blk_mq_delay_queue()
>   blk-mq: don't check queue mapped in __blk_mq_delay_run_hw_queue()
>   blk-mq: reimplement blk_mq_hw_queue_mapped
>   blk-mq: remove code for dealing with remapping queue
> 
>  block/blk-mq-cpumap.c  |   5 ---
>  block/blk-mq-debugfs.c |   1 -
>  block/blk-mq.c | 101 
> +++--
>  block/blk-mq.h |   2 +-
>  include/linux/blk-mq.h |   2 -
>  5 files changed, 24 insertions(+), 87 deletions(-)
> 

[PATCH 0/8] blk-mq: fix and improve queue mapping

[Ming Lei]

Hi Jens,

The first two patches fix issues about queue mapping.

The other 6 patches improve queue mapping for blk-mq.

Christian, this patches should fix your issue, so please give
a test, and the patches can be found in the following tree:

https://github.com/ming1/linux/commits/v4.17-rc-blk-fix_mapping_v1

Thanks,
Ming

Ming Lei (8):
  blk-mq: make sure that correct hctx->next_cpu is set
  blk-mq: don't keep offline CPUs mapped to hctx 0
  blk-mq: avoid to write intermediate result to hctx->next_cpu
  blk-mq: introduce blk_mq_hw_queue_first_cpu() to figure out first cpu
  blk-mq: remove blk_mq_delay_queue()
  blk-mq: don't check queue mapped in __blk_mq_delay_run_hw_queue()
  blk-mq: reimplement blk_mq_hw_queue_mapped
  blk-mq: remove code for dealing with remapping queue

 block/blk-mq-cpumap.c  |   5 ---
 block/blk-mq-debugfs.c |   1 -
 block/blk-mq.c | 101 +++--
 block/blk-mq.h |   2 +-
 include/linux/blk-mq.h |   2 -
 5 files changed, 24 insertions(+), 87 deletions(-)

-- 
2.9.5