[PATCH v2 3/3] blk-mq: remove blk_mq_abort_requeue_list()

2017-05-19 Thread Ming Lei
No one uses it any more, so remove it.

Signed-off-by: Ming Lei 
---
 block/blk-mq.c | 19 ---
 include/linux/blk-mq.h |  1 -
 2 files changed, 20 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index a69ad122ed66..f2224ffd225d 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -628,25 +628,6 @@ void blk_mq_delay_kick_requeue_list(struct request_queue 
*q,
 }
 EXPORT_SYMBOL(blk_mq_delay_kick_requeue_list);
 
-void blk_mq_abort_requeue_list(struct request_queue *q)
-{
-   unsigned long flags;
-   LIST_HEAD(rq_list);
-
-   spin_lock_irqsave(&q->requeue_lock, flags);
-   list_splice_init(&q->requeue_list, &rq_list);
-   spin_unlock_irqrestore(&q->requeue_lock, flags);
-
-   while (!list_empty(&rq_list)) {
-   struct request *rq;
-
-   rq = list_first_entry(&rq_list, struct request, queuelist);
-   list_del_init(&rq->queuelist);
-   blk_mq_end_request(rq, -EIO);
-   }
-}
-EXPORT_SYMBOL(blk_mq_abort_requeue_list);
-
 struct request *blk_mq_tag_to_rq(struct blk_mq_tags *tags, unsigned int tag)
 {
if (tag < tags->nr_tags) {
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index c47aa248c640..fcd641032f8d 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -238,7 +238,6 @@ void blk_mq_add_to_requeue_list(struct request *rq, bool 
at_head,
bool kick_requeue_list);
 void blk_mq_kick_requeue_list(struct request_queue *q);
 void blk_mq_delay_kick_requeue_list(struct request_queue *q, unsigned long 
msecs);
-void blk_mq_abort_requeue_list(struct request_queue *q);
 void blk_mq_complete_request(struct request *rq);
 
 bool blk_mq_queue_stopped(struct request_queue *q);
-- 
2.9.4



Re: [PATCH v2 3/3] blk-mq: remove blk_mq_abort_requeue_list()

2017-05-20 Thread Christoph Hellwig
Looks good,

Reviewed-by: Christoph Hellwig 


Re: [PATCH v2 3/3] blk-mq: remove blk_mq_abort_requeue_list()

2017-05-21 Thread Keith Busch
Looks good.

Reviewed-by: Keith Busch 


Re: [PATCH v2 3/3] blk-mq: remove blk_mq_abort_requeue_list()

2017-05-22 Thread Johannes Thumshirn
On 05/20/2017 05:56 AM, Ming Lei wrote:
> No one uses it any more, so remove it.
> 
> Signed-off-by: Ming Lei 
> ---

Looks good,
Reviewed-by: Johannes Thumshirn 


-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850