Re: [PATCH 08/12] nvmet: mask pending AERs

2018-06-03 Thread Hannes Reinecke
On Wed, 30 May 2018 18:45:56 +0200
Christoph Hellwig  wrote:

> Per section 5.2 of the NVMe 1.3 spec:
> 
>   "When the controller posts a completion queue entry for an
> outstanding Asynchronous Event Request command and thus reports an
> asynchronous event, subsequent events of that event type are
> automatically masked by the controller until the host clears that
> event. An event is cleared by reading the log page associated with
> that event using the Get Log Page command (see section 5.14)."
> 
> Signed-off-by: Christoph Hellwig 
> ---
>  drivers/nvme/target/admin-cmd.c | 1 +
>  drivers/nvme/target/core.c  | 9 -
>  drivers/nvme/target/nvmet.h | 1 +
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes



Re: [PATCH 08/12] nvmet: mask pending AERs

2018-05-30 Thread Sagi Grimberg

Reviewed-by: Sagi Grimberg