Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()

2018-08-02 Thread Ed Cashin 
On Wed, Aug 1, 2018 at 2:57 AM Hannes Reinecke  wrote:

> On 08/01/2018 03:00 AM, Ed Cashin wrote:
> > On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke  > > wrote:
> >
> > Use device_add_disk_with_groups() to avoid a race condition with
> > udev during startup.
> >
> >
> > I love the idea of getting rid of the race, but I am having trouble
> > seeing what happened to the cleanup we had via sysfs_remove_group.
> > You're storing a pointer to groups off the device, but I don't see it
> > getting
> > used for cleanup later in this patch set.  Are you patching linux-next?
> >
> And that's the beauty of this patch: you don't need to free/unlink the
> groups yourself.
> Unlinking is done in the driver core via
> device_del()->device_remove_attrs()->device_remove_groups().
>
> So no separate patch needed.
>

OK, thanks for the clarification.

-- 
  Ed Cashin

Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()

2018-08-01 Thread Hannes Reinecke 
On 08/01/2018 03:00 AM, Ed Cashin wrote:
> On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke  > wrote:
> 
> Use device_add_disk_with_groups() to avoid a race condition with
> udev during startup.
> 
> 
> I love the idea of getting rid of the race, but I am having trouble
> seeing what happened to the cleanup we had via sysfs_remove_group.
> You're storing a pointer to groups off the device, but I don't see it
> getting
> used for cleanup later in this patch set.  Are you patching linux-next?
> 
And that's the beauty of this patch: you don't need to free/unlink the
groups yourself.
Unlinking is done in the driver core via
device_del()->device_remove_attrs()->device_remove_groups().

So no separate patch needed.

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()

2018-07-31 Thread Ed Cashin 
On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke  wrote:

> Use device_add_disk_with_groups() to avoid a race condition with
> udev during startup.
>

I love the idea of getting rid of the race, but I am having trouble
seeing what happened to the cleanup we had via sysfs_remove_group.
You're storing a pointer to groups off the device, but I don't see it
getting
used for cleanup later in this patch set.  Are you patching linux-next?

-- Ed

Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()

2018-07-30 Thread Christoph Hellwig 
On Mon, Jul 30, 2018 at 09:12:25AM +0200, Hannes Reinecke wrote:
> Use device_add_disk_with_groups() to avoid a race condition with
> udev during startup.
> 
> Signed-off-by: Hannes Reinecke 
> Cc: Ed L. Cachin 

Looks good,

Reviewed-by: Christoph Hellwig