Re: [PATCH 02/15] scsi/osd: don't save block errors into req_results
On Wed, May 24, 2017 at 04:04:40PM +, Bart Van Assche wrote:
> Are you sure that that code is not necessary? From osd_initiator.c:
>
> static void _put_request(struct request *rq)
> {
> /*
>* If osd_finalize_request() was called but the request was not
>* executed through the block layer, then we must release BIOs.
>* TODO: Keep error code in or->async_error. Need to audit all
>* code paths.
>*/
> if (unlikely(rq->bio))
> blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq));
> else
> blk_put_request(rq);
> }
Which isn't using it at all. It has a ten year old comment to pass
on some error, but even then ORing two different error types together
would no be very helpful.
>
> Bart.---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/15] block: merge blk_types.h into bio.h
On Thu, May 18, 2017 at 02:25:52PM +, Bart Van Assche wrote: > On Thu, 2017-05-18 at 15:18 +0200, Christoph Hellwig wrote: > > We've cleaned up our headers sufficiently that we don't need this split > > anymore. > > Hello Christoph, > > Request-based drivers need the structure definitions from and > the type definitions from but do not need the definition > of > struct bio. Have you considered to remove #include from file > include/linux/blkdev.h? Do you think that would help to reduce the kernel > build > time? Most block drivers end up needing bio.h anyway. But I can skip this part of the series for now. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
