Re: [PATCH] Btrfs: remove unused trans in read_block_for_search

2017-02-02 Thread David Sterba
On Mon, Jan 30, 2017 at 12:23:42PM -0800, Liu Bo wrote:
> @trans is not used at all, this removes it.
> 
> Signed-off-by: Liu Bo 

Reviewed-by: David Sterba 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] Btrfs: remove unused trans in read_block_for_search

2017-01-30 Thread Liu Bo
@trans is not used at all, this removes it.

Signed-off-by: Liu Bo 
---
 fs/btrfs/ctree.c | 17 -
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index a426dc8..dd8014a 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -2437,10 +2437,9 @@ noinline void btrfs_unlock_up_safe(struct btrfs_path 
*path, int level)
  * reada.  -EAGAIN is returned and the search must be repeated.
  */
 static int
-read_block_for_search(struct btrfs_trans_handle *trans,
-  struct btrfs_root *root, struct btrfs_path *p,
-  struct extent_buffer **eb_ret, int level, int slot,
-  struct btrfs_key *key, u64 time_seq)
+read_block_for_search(struct btrfs_root *root, struct btrfs_path *p,
+ struct extent_buffer **eb_ret, int level, int slot,
+ struct btrfs_key *key, u64 time_seq)
 {
struct btrfs_fs_info *fs_info = root->fs_info;
u64 blocknr;
@@ -2870,8 +2869,8 @@ int btrfs_search_slot(struct btrfs_trans_handle *trans, 
struct btrfs_root
goto done;
}
 
-   err = read_block_for_search(trans, root, p,
-   , level, slot, key, 0);
+   err = read_block_for_search(root, p, , level,
+   slot, key, 0);
if (err == -EAGAIN)
goto again;
if (err) {
@@ -3014,7 +3013,7 @@ int btrfs_search_old_slot(struct btrfs_root *root, struct 
btrfs_key *key,
goto done;
}
 
-   err = read_block_for_search(NULL, root, p, , level,
+   err = read_block_for_search(root, p, , level,
slot, key, time_seq);
if (err == -EAGAIN)
goto again;
@@ -5784,7 +5783,7 @@ int btrfs_next_old_leaf(struct btrfs_root *root, struct 
btrfs_path *path,
 
next = c;
next_rw_lock = path->locks[level];
-   ret = read_block_for_search(NULL, root, path, , level,
+   ret = read_block_for_search(root, path, , level,
slot, , 0);
if (ret == -EAGAIN)
goto again;
@@ -5834,7 +5833,7 @@ int btrfs_next_old_leaf(struct btrfs_root *root, struct 
btrfs_path *path,
if (!level)
break;
 
-   ret = read_block_for_search(NULL, root, path, , level,
+   ret = read_block_for_search(root, path, , level,
0, , 0);
if (ret == -EAGAIN)
goto again;
-- 
2.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html