Re: [PATCH] Fix typos
On Wed, Nov 28, 2018 at 06:02:47PM +0100, David Sterba wrote: > You've put your time to find and fix the typos so you deserve the > credit. Because you sent them with the signed-off-by line I will use Ok, David, thanks a lot. So, I'm going to rework the patch with the various suggestion, and then re-send it. Thanks a lot, Andrea
Re: [PATCH] Fix typos
On Wed, Nov 28, 2018 at 05:17:09PM +0100, Andrea Gelmini wrote: > On Wed, Nov 28, 2018 at 04:56:20PM +0100, David Sterba wrote: > > Thanks, such patches are accepted once in a while when the amount of new > > typo fixes becomes noticeable. > > About this patch (and the others sent to this m/l), I don't > care to have them committed with my name. You've put your time to find and fix the typos so you deserve the credit. Because you sent them with the signed-off-by line I will use that and maybe write a short changelog but otherwise I don't see a reason why you should not be mentioned. > Feel free to copy/integrate/commit with your/someone else name. Unless you really want to stay out of the linux git history, I'm somehow obliged by the development process to stick with the patch author name. > It's just - probably - the best way to let the real devs to know > about the typos, but it's not valuable effort that must be > recognized. The typos can be annoying and distracting while reading code or prevent some function names to be greppable (which is usually the reason to fix them). My first patch to linux was also fixing typos, and see where I am now :)
Re: [PATCH] Fix typos
On Wed, Nov 28, 2018 at 04:56:20PM +0100, David Sterba wrote: > > Thanks, such patches are accepted once in a while when the amount of new > typo fixes becomes noticeable. About this patch (and the others sent to this m/l), I don't care to have them committed with my name. Feel free to copy/integrate/commit with your/someone else name. It's just - probably - the best way to let the real devs to know about the typos, but it's not valuable effort that must be recognized. So, use them as you prefer. Thanks a lot for your work, Gelma
Re: [PATCH] Fix typos
On Wed, Nov 28, 2018 at 12:05:13PM +0100, Andrea Gelmini wrote: > Signed-off-by: Andrea Gelmini > --- > > Stupid fixes. Made on 4.20-rc4, and ported on linux-next (next-20181128). Thanks, such patches are accepted once in a while when the amount of new typo fixes becomes noticeable. > fs/btrfs/backref.c | 4 ++-- > fs/btrfs/check-integrity.c | 2 +- > fs/btrfs/compression.c | 4 ++-- > fs/btrfs/ctree.c | 4 ++-- > fs/btrfs/dev-replace.c | 2 +- > fs/btrfs/disk-io.c | 4 ++-- > fs/btrfs/extent-tree.c | 28 ++-- > fs/btrfs/extent_io.c | 4 ++-- > fs/btrfs/extent_io.h | 2 +- > fs/btrfs/extent_map.c | 2 +- > fs/btrfs/file.c| 6 +++--- > fs/btrfs/free-space-tree.c | 2 +- > fs/btrfs/inode.c | 10 +- > fs/btrfs/ioctl.c | 4 ++-- > fs/btrfs/lzo.c | 2 +- > fs/btrfs/qgroup.c | 14 +++--- > fs/btrfs/qgroup.h | 4 ++-- > fs/btrfs/raid56.c | 2 +- > fs/btrfs/ref-verify.c | 6 +++--- > fs/btrfs/relocation.c | 2 +- > fs/btrfs/scrub.c | 2 +- > fs/btrfs/send.c| 4 ++-- > fs/btrfs/super.c | 8 > fs/btrfs/transaction.c | 4 ++-- > fs/btrfs/tree-checker.c| 6 +++--- > fs/btrfs/tree-log.c| 4 ++-- > fs/btrfs/volumes.c | 8 > 27 files changed, 72 insertions(+), 72 deletions(-) Approves. > @@ -1010,14 +1010,14 @@ int btrfs_lookup_extent_info(struct > btrfs_trans_handle *trans, > * > * - multiple snapshots, subvolumes, or different generations in one subvol > * - different files inside a single subvolume > - * - different offsets inside a file (bookend extents in file.c) > + * - different offsets inside a file (booked extents in file.c) > * > * The extent ref structure for the implicit back refs has fields for: > * > * - Objectid of the subvolume root > * - objectid of the file holding the reference > * - original offset in the file > - * - how many bookend extents > + * - how many booked extents Please note that 'bookend' is not a typo here. The meaning used for btrfs is close to 2a or 2b in https://www.merriam-webster.com/dictionary/bookend and refers to the mechanism how blocks are shared by extents and lengthier explanation would show why snapshots are so cheap (I really tried to write a tl;dr version, but nope).
Re: [PATCH] Fix typos
On 28.11.18 г. 15:24 ч., Brendan Hide wrote: > > > On 11/28/18 1:23 PM, Nikolay Borisov wrote: >> >> >> On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote: >>> Signed-off-by: Andrea Gelmini >>> --- > > > >>> >>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c >>> index bab2f1983c07..babbd75d91d2 100644 >>> --- a/fs/btrfs/inode.c >>> +++ b/fs/btrfs/inode.c >>> @@ -104,7 +104,7 @@ static void __endio_write_update_ordered(struct >>> inode *inode, >>> /* >>> * Cleanup all submitted ordered extents in specified range to >>> handle errors >>> - * from the fill_dellaloc() callback. >>> + * from the fill_delalloc() callback. >> >> This is a pure whitespace fix which is generally frowned upon. What you >> can do though, is replace 'fill_delalloc callback' with >> 'btrfs_run_delalloc_range' since the callback is gone already. >> >>> * >>> * NOTE: caller must ensure that when an error happens, it can not >>> call >>> * extent_clear_unlock_delalloc() to clear both the bits >>> EXTENT_DO_ACCOUNTING >>> @@ -1831,7 +1831,7 @@ void btrfs_clear_delalloc_extent(struct inode >>> *vfs_inode, >> >> >> >>> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c >>> index 410c7e007ba8..d7b6c2b09a0c 100644 >>> --- a/fs/btrfs/ioctl.c >>> +++ b/fs/btrfs/ioctl.c >>> @@ -892,7 +892,7 @@ static int create_snapshot(struct btrfs_root >>> *root, struct inode *dir, >>> * 7. If we were asked to remove a directory and victim isn't one >>> - ENOTDIR. >>> * 8. If we were asked to remove a non-directory and victim isn't >>> one - EISDIR. >>> * 9. We can't remove a root or mountpoint. >>> - * 10. We don't allow removal of NFS sillyrenamed files; it's >>> handled by >>> + * 10. We don't allow removal of NFS silly renamed files; it's >>> handled by >>> * nfs_async_unlink(). >>> */ >>> @@ -3522,7 +3522,7 @@ static int btrfs_extent_same_range(struct >>> inode *src, u64 loff, u64 olen, >>> false); >>> /* >>> * If one of the inodes has dirty pages in the respective range or >>> - * ordered extents, we need to flush dellaloc and wait for all >>> ordered >>> + * ordered extents, we need to flush delalloc and wait for all >>> ordered >> >> Just whitespace fix, drop it. >> >> >> > > If the spelling is changed, surely that is not a whitespace fix? My bad, I missed it the first time. >
Re: [PATCH] Fix typos
On 11/28/18 1:23 PM, Nikolay Borisov wrote: On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote: Signed-off-by: Andrea Gelmini --- diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index bab2f1983c07..babbd75d91d2 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -104,7 +104,7 @@ static void __endio_write_update_ordered(struct inode *inode, /* * Cleanup all submitted ordered extents in specified range to handle errors - * from the fill_dellaloc() callback. + * from the fill_delalloc() callback. This is a pure whitespace fix which is generally frowned upon. What you can do though, is replace 'fill_delalloc callback' with 'btrfs_run_delalloc_range' since the callback is gone already. * * NOTE: caller must ensure that when an error happens, it can not call * extent_clear_unlock_delalloc() to clear both the bits EXTENT_DO_ACCOUNTING @@ -1831,7 +1831,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode, diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 410c7e007ba8..d7b6c2b09a0c 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -892,7 +892,7 @@ static int create_snapshot(struct btrfs_root *root, struct inode *dir, * 7. If we were asked to remove a directory and victim isn't one - ENOTDIR. * 8. If we were asked to remove a non-directory and victim isn't one - EISDIR. * 9. We can't remove a root or mountpoint. - * 10. We don't allow removal of NFS sillyrenamed files; it's handled by + * 10. We don't allow removal of NFS silly renamed files; it's handled by * nfs_async_unlink(). */ @@ -3522,7 +3522,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 olen, false); /* * If one of the inodes has dirty pages in the respective range or -* ordered extents, we need to flush dellaloc and wait for all ordered +* ordered extents, we need to flush delalloc and wait for all ordered Just whitespace fix, drop it. If the spelling is changed, surely that is not a whitespace fix?
Re: [PATCH] Fix typos
On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini
> ---
>
> Stupid fixes. Made on 4.20-rc4, and ported on linux-next (next-20181128).
>
>
> fs/btrfs/backref.c | 4 ++--
> fs/btrfs/check-integrity.c | 2 +-
> fs/btrfs/compression.c | 4 ++--
> fs/btrfs/ctree.c | 4 ++--
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/disk-io.c | 4 ++--
> fs/btrfs/extent-tree.c | 28 ++--
> fs/btrfs/extent_io.c | 4 ++--
> fs/btrfs/extent_io.h | 2 +-
> fs/btrfs/extent_map.c | 2 +-
> fs/btrfs/file.c| 6 +++---
> fs/btrfs/free-space-tree.c | 2 +-
> fs/btrfs/inode.c | 10 +-
> fs/btrfs/ioctl.c | 4 ++--
> fs/btrfs/lzo.c | 2 +-
> fs/btrfs/qgroup.c | 14 +++---
> fs/btrfs/qgroup.h | 4 ++--
> fs/btrfs/raid56.c | 2 +-
> fs/btrfs/ref-verify.c | 6 +++---
> fs/btrfs/relocation.c | 2 +-
> fs/btrfs/scrub.c | 2 +-
> fs/btrfs/send.c| 4 ++--
> fs/btrfs/super.c | 8
> fs/btrfs/transaction.c | 4 ++--
> fs/btrfs/tree-checker.c| 6 +++---
> fs/btrfs/tree-log.c| 4 ++--
> fs/btrfs/volumes.c | 8
> 27 files changed, 72 insertions(+), 72 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 4a15f87dbbb4..78556447e1d5 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -591,7 +591,7 @@ unode_aux_to_inode_list(struct ulist_node *node)
> }
>
> /*
> @@ -9807,7 +9807,7 @@ void btrfs_dec_block_group_ro(struct
> btrfs_block_group_cache *cache)
> }
>
> /*
> - * checks to see if its even possible to relocate this block group.
> + * checks to see if it's even possible to relocate this block group.
> *
> * @return - false if not enough space can be found for relocation, true
> * otherwise
> @@ -9872,7 +9872,7 @@ bool btrfs_can_relocate(struct btrfs_fs_info *fs_info,
> u64 bytenr)
>* ok we don't have enough space, but maybe we have free space on our
>* devices to allocate new chunks for relocation, so loop through our
>* alloc devices and guess if we have enough space. if this block
> - * group is going to be restriped, run checks against the target
> + * group is going to be restripped, run checks against the target
Drop this hunk, here we mean to restripe the changes and not restrip
them. So restriped is the correct past tense of the verb.
>* profile instead of the current one.
>*/
> can_reloc = false;
> @@ -10424,7 +10424,7 @@ int btrfs_read_block_groups(struct btrfs_fs_info
> *info)
>* check for two cases, either we are full, and therefore
>* don't need to bother with the caching work since we won't
>* find any space, or we are empty, and we can just add all
> - * the space in and be done with it. This saves us _alot_ of
> + * the space in and be done with it. This saves us _a_lot_ of
This should be _a lot_
>* time, particularly in the full case.
>*/
> if (found_key.offset == btrfs_block_group_used(>item)) {
> @@ -10700,7 +10700,7 @@ int btrfs_remove_block_group(struct
> btrfs_trans_handle *trans,
>
> mutex_lock(>transaction->cache_write_mutex);
> /*
> - * make sure our free spache cache IO is done before remove the
> + * make sure our free space cache IO is done before remove the
I think there should be a 'we' before 'remove'
>* free space inode
>*/
> spin_lock(>transaction->dirty_bgs_lock);
> @@ -11217,7 +11217,7 @@ static int btrfs_trim_free_extents(struct
> btrfs_device *device,
> if (!blk_queue_discard(bdev_get_queue(device->bdev)))
> return 0;
>
> - /* Not writeable = nothing to do. */
> + /* Not writable = nothing to do. */
This comment is redundant so could be removed altogether
> if (!test_bit(BTRFS_DEV_STATE_WRITEABLE, >dev_state))
> return 0;
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index aef3c9866ff0..1493f0c102ec 100644
> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
> index e5089087eaa6..13e71efcfe21 100644
> --- a/fs/btrfs/free-space-tree.c
> +++ b/fs/btrfs/free-space-tree.c
> @@ -550,7 +550,7 @@ static void free_space_set_bits(struct
> btrfs_block_group_cache *block_group,
>
> /*
> * We can't use btrfs_next_item() in modify_free_space_bitmap() because
> - * btrfs_next_leaf() doesn't get the path for writing. We can forgo the fancy
> + * btrfs_next_leaf() doesn't get the path for writing. We can forgot the
> fancy
Drop this hunk, the meaning is we can eschew the fancy tree walking.
> * tree walking in btrfs_next_leaf() anyways because we know exactly what
> we're
> * looking for.
> */
> diff --git a/fs/btrfs/inode.c
[PATCH] Fix typos
Signed-off-by: Andrea Gelmini
---
Stupid fixes. Made on 4.20-rc4, and ported on linux-next (next-20181128).
fs/btrfs/backref.c | 4 ++--
fs/btrfs/check-integrity.c | 2 +-
fs/btrfs/compression.c | 4 ++--
fs/btrfs/ctree.c | 4 ++--
fs/btrfs/dev-replace.c | 2 +-
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/extent-tree.c | 28 ++--
fs/btrfs/extent_io.c | 4 ++--
fs/btrfs/extent_io.h | 2 +-
fs/btrfs/extent_map.c | 2 +-
fs/btrfs/file.c| 6 +++---
fs/btrfs/free-space-tree.c | 2 +-
fs/btrfs/inode.c | 10 +-
fs/btrfs/ioctl.c | 4 ++--
fs/btrfs/lzo.c | 2 +-
fs/btrfs/qgroup.c | 14 +++---
fs/btrfs/qgroup.h | 4 ++--
fs/btrfs/raid56.c | 2 +-
fs/btrfs/ref-verify.c | 6 +++---
fs/btrfs/relocation.c | 2 +-
fs/btrfs/scrub.c | 2 +-
fs/btrfs/send.c| 4 ++--
fs/btrfs/super.c | 8
fs/btrfs/transaction.c | 4 ++--
fs/btrfs/tree-checker.c| 6 +++---
fs/btrfs/tree-log.c| 4 ++--
fs/btrfs/volumes.c | 8
27 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 4a15f87dbbb4..78556447e1d5 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -591,7 +591,7 @@ unode_aux_to_inode_list(struct ulist_node *node)
}
/*
- * We maintain three seperate rbtrees: one for direct refs, one for
+ * We maintain three separate rbtrees: one for direct refs, one for
* indirect refs which have a key, and one for indirect refs which do not
* have a key. Each tree does merge on insertion.
*
@@ -695,7 +695,7 @@ static int resolve_indirect_refs(struct btrfs_fs_info
*fs_info,
}
/*
-* Now it's a direct ref, put it in the the direct tree. We must
+* Now it's a direct ref, put it in the direct tree. We must
* do this last because the ref could be merged/freed here.
*/
prelim_ref_insert(fs_info, >direct, ref, NULL);
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index 781cae168d2a..42b2c5e159f1 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -2327,7 +2327,7 @@ static int btrfsic_check_all_ref_blocks(struct
btrfsic_state *state,
* write operations. Therefore it keeps the linkage
* information for a block until a block is
* rewritten. This can temporarily cause incorrect
-* and even circular linkage informations. This
+* and even circular linkage information. This
* causes no harm unless such blocks are referenced
* by the most recent super block.
*/
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 34d50bc5c10d..d8ce66f3e943 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -1202,7 +1202,7 @@ int btrfs_decompress_buf2page(const char *buf, unsigned
long buf_start,
/*
* Shannon Entropy calculation
*
- * Pure byte distribution analysis fails to determine compressiability of data.
+ * Pure byte distribution analysis fails to determine compressibility of data.
* Try calculating entropy to estimate the average minimum number of bits
* needed to encode the sampled data.
*
@@ -1266,7 +1266,7 @@ static u8 get4bits(u64 num, int shift) {
/*
* Use 4 bits as radix base
- * Use 16 u32 counters for calculating new possition in buf array
+ * Use 16 u32 counters for calculating new position in buf array
*
* @array - array that will be sorted
* @array_buf - buffer array to store sorting results
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 1ec08efba814..25a58486bf89 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1414,7 +1414,7 @@ static inline int should_cow_block(struct
btrfs_trans_handle *trans,
*
* What is forced COW:
*when we create snapshot during committing the transaction,
-*after we've finished coping src root, we must COW the shared
+*after we've finished copying src root, we must COW the shared
*block to ensure the metadata consistency.
*/
if (btrfs_header_generation(buf) == trans->transid &&
@@ -3746,7 +3746,7 @@ static int push_leaf_right(struct btrfs_trans_handle
*trans, struct btrfs_root
/* Key greater than all keys in the leaf, right neighbor has
* enough room for it and we're not emptying our leaf to delete
* it, therefore use right neighbor to insert the new item and
-* no need to touch/dirty our left leaft. */
+* no need to touch/dirty our left leaf. */
btrfs_tree_unlock(left);
free_extent_buffer(left);
path->nodes[0] = right;
Re: [PATCH] Fix typos in docs (second try...)
On 27.11.18 г. 15:56 ч., Andrea Gelmini wrote: > Signed-off-by: Andrea Gelmini Reviewed-by: Nikolay Borisov > --- > Documentation/DocConventions | 4 ++-- > Documentation/ReleaseChecklist| 4 ++-- > Documentation/btrfs-man5.asciidoc | 8 > Documentation/btrfs-property.asciidoc | 2 +- > Documentation/btrfs-qgroup.asciidoc | 4 ++-- > Documentation/mkfs.btrfs.asciidoc | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/Documentation/DocConventions b/Documentation/DocConventions > index e84ed7a..969209c 100644 > --- a/Documentation/DocConventions > +++ b/Documentation/DocConventions > @@ -23,7 +23,7 @@ Quotation in subcommands: > - command reference: bold *btrfs fi show* > - section references: italics 'EXAMPLES' > > -- argument name in option desciption: caps in angle brackets > +- argument name in option description: caps in angle brackets >- reference in help text: caps NAME > also possible: caps italics 'NAME' > > @@ -34,6 +34,6 @@ Quotation in subcommands: >- optional parameter with argument: [-p ] > > > -Refrences: > +References: > - full asciidoc syntax: http://asciidoc.org/userguide.html > - cheatsheet: http://powerman.name/doc/asciidoc > diff --git a/Documentation/ReleaseChecklist b/Documentation/ReleaseChecklist > index d8bf50c..ebe251d 100644 > --- a/Documentation/ReleaseChecklist > +++ b/Documentation/ReleaseChecklist > @@ -4,7 +4,7 @@ Release checklist > Last code touches: > > * make the code ready, collect patches queued for the release > -* look to mailinglist for any relevant last-minute fixes > +* look to mailing list for any relevant last-minute fixes > > Pre-checks: > > @@ -31,7 +31,7 @@ Release: > > Post-release: > > -* write and send announcement mail to mailinglist > +* write and send announcement mail to mailing list > * update wiki://Main_page#News > * update wiki://Changelog#btrfs-progs > * update title on IRC > diff --git a/Documentation/btrfs-man5.asciidoc > b/Documentation/btrfs-man5.asciidoc > index 448710a..4a269e2 100644 > --- a/Documentation/btrfs-man5.asciidoc > +++ b/Documentation/btrfs-man5.asciidoc > @@ -156,7 +156,7 @@ under 'nodatacow' are also set the NOCOW file attribute > (see `chattr`(1)). > NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. > + > Updates in-place improve performance for workloads that do frequent > overwrites, > -at the cost of potential partial writes, in case the write is interruted > +at the cost of potential partial writes, in case the write is interrupted > (system crash, device failure). > > *datasum*:: > @@ -171,7 +171,7 @@ corresponding file attribute (see `chattr`(1)). > NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. > + > There is a slight performance gain when checksums are turned off, the > -correspoinding metadata blocks holding the checksums do not need to updated. > +corresponding metadata blocks holding the checksums do not need to be > updated. > The cost of checksumming of the blocks in memory is much lower than the IO, > modern CPUs feature hardware support of the checksumming algorithm. > > @@ -185,7 +185,7 @@ missing, for example if a stripe member is completely > missing from RAID0. > Since 4.14, the constraint checks have been improved and are verified on the > chunk level, not an the device level. This allows degraded mounts of > filesystems with mixed RAID profiles for data and metadata, even if the > -device number constraints would not be satisfied for some of the prifles. > +device number constraints would not be satisfied for some of the profiles. > + > Example: metadata -- raid1, data -- single, devices -- /dev/sda, /dev/sdb > + > @@ -649,7 +649,7 @@ inherent limit of btrfs is 2^64^ (16 EiB) but the linux > VFS limit is 2^63^ (8 Ei > > maximum number of subvolumes:: > 2^64^ but depends on the available metadata space, the space consumed by all > -subvolume metadata includes bookeeping of the shared extents can be large > (MiB, > +subvolume metadata includes bookkeeping of the shared extents can be large > (MiB, > GiB) > > maximum number of hardlinks of a file in a directory:: > diff --git a/Documentation/btrfs-property.asciidoc > b/Documentation/btrfs-property.asciidoc > index b562717..4bad88b 100644 > --- a/Documentation/btrfs-property.asciidoc > +++ b/Documentation/btrfs-property.asciidoc > @@ -34,7 +34,7 @@ specify what type of object you meant. This is only needed > when a > property could be set for more then one object type. > + > Possible types are 's[ubvol]', 'f[ilesystem]', 'i[node]' and 'd[evice]', > where > -the first lettes is a shortcut. > +the first letter is a shortcut. > + > Set the name of property by 'name'. If no 'name' is specified, > all properties for the given object are printed. 'name' is one of > diff --git a/Documentation/btrfs-qgroup.asciidoc > b/Documentation/btrfs-qgroup.asciidoc >
[PATCH] Fix typos in docs (second try...)
Signed-off-by: Andrea Gelmini --- Documentation/DocConventions | 4 ++-- Documentation/ReleaseChecklist| 4 ++-- Documentation/btrfs-man5.asciidoc | 8 Documentation/btrfs-property.asciidoc | 2 +- Documentation/btrfs-qgroup.asciidoc | 4 ++-- Documentation/mkfs.btrfs.asciidoc | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/DocConventions b/Documentation/DocConventions index e84ed7a..969209c 100644 --- a/Documentation/DocConventions +++ b/Documentation/DocConventions @@ -23,7 +23,7 @@ Quotation in subcommands: - command reference: bold *btrfs fi show* - section references: italics 'EXAMPLES' -- argument name in option desciption: caps in angle brackets +- argument name in option description: caps in angle brackets - reference in help text: caps NAME also possible: caps italics 'NAME' @@ -34,6 +34,6 @@ Quotation in subcommands: - optional parameter with argument: [-p ] -Refrences: +References: - full asciidoc syntax: http://asciidoc.org/userguide.html - cheatsheet: http://powerman.name/doc/asciidoc diff --git a/Documentation/ReleaseChecklist b/Documentation/ReleaseChecklist index d8bf50c..ebe251d 100644 --- a/Documentation/ReleaseChecklist +++ b/Documentation/ReleaseChecklist @@ -4,7 +4,7 @@ Release checklist Last code touches: * make the code ready, collect patches queued for the release -* look to mailinglist for any relevant last-minute fixes +* look to mailing list for any relevant last-minute fixes Pre-checks: @@ -31,7 +31,7 @@ Release: Post-release: -* write and send announcement mail to mailinglist +* write and send announcement mail to mailing list * update wiki://Main_page#News * update wiki://Changelog#btrfs-progs * update title on IRC diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc index 448710a..4a269e2 100644 --- a/Documentation/btrfs-man5.asciidoc +++ b/Documentation/btrfs-man5.asciidoc @@ -156,7 +156,7 @@ under 'nodatacow' are also set the NOCOW file attribute (see `chattr`(1)). NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. + Updates in-place improve performance for workloads that do frequent overwrites, -at the cost of potential partial writes, in case the write is interruted +at the cost of potential partial writes, in case the write is interrupted (system crash, device failure). *datasum*:: @@ -171,7 +171,7 @@ corresponding file attribute (see `chattr`(1)). NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. + There is a slight performance gain when checksums are turned off, the -correspoinding metadata blocks holding the checksums do not need to updated. +corresponding metadata blocks holding the checksums do not need to be updated. The cost of checksumming of the blocks in memory is much lower than the IO, modern CPUs feature hardware support of the checksumming algorithm. @@ -185,7 +185,7 @@ missing, for example if a stripe member is completely missing from RAID0. Since 4.14, the constraint checks have been improved and are verified on the chunk level, not an the device level. This allows degraded mounts of filesystems with mixed RAID profiles for data and metadata, even if the -device number constraints would not be satisfied for some of the prifles. +device number constraints would not be satisfied for some of the profiles. + Example: metadata -- raid1, data -- single, devices -- /dev/sda, /dev/sdb + @@ -649,7 +649,7 @@ inherent limit of btrfs is 2^64^ (16 EiB) but the linux VFS limit is 2^63^ (8 Ei maximum number of subvolumes:: 2^64^ but depends on the available metadata space, the space consumed by all -subvolume metadata includes bookeeping of the shared extents can be large (MiB, +subvolume metadata includes bookkeeping of the shared extents can be large (MiB, GiB) maximum number of hardlinks of a file in a directory:: diff --git a/Documentation/btrfs-property.asciidoc b/Documentation/btrfs-property.asciidoc index b562717..4bad88b 100644 --- a/Documentation/btrfs-property.asciidoc +++ b/Documentation/btrfs-property.asciidoc @@ -34,7 +34,7 @@ specify what type of object you meant. This is only needed when a property could be set for more then one object type. + Possible types are 's[ubvol]', 'f[ilesystem]', 'i[node]' and 'd[evice]', where -the first lettes is a shortcut. +the first letter is a shortcut. + Set the name of property by 'name'. If no 'name' is specified, all properties for the given object are printed. 'name' is one of diff --git a/Documentation/btrfs-qgroup.asciidoc b/Documentation/btrfs-qgroup.asciidoc index dff0867..dc4c93b 100644 --- a/Documentation/btrfs-qgroup.asciidoc +++ b/Documentation/btrfs-qgroup.asciidoc @@ -52,7 +52,7 @@ assignment would lead to quota inconsistency. See 'QUOTA RESCAN' for more information. --no-rescan Explicitly ask not to do a rescan, even if the assignment will make the quotas
Re: [PATCH] Fix typos in docs
On Tue, Nov 27, 2018 at 03:41:55PM +0200, Nikolay Borisov wrote: > On 27.11.18 г. 15:37 ч., Andrea Gelmini wrote: > > Wrong position of space, should be mailing list Thanks a lot Nikolay for the review. I'm going to send new version. Thanks again, Andrea
Re: [PATCH] Fix typos in docs
On 27.11.18 г. 15:37 ч., Andrea Gelmini wrote: > Signed-off-by: Andrea Gelmini > --- > Documentation/DocConventions | 4 ++-- > Documentation/ReleaseChecklist| 4 ++-- > Documentation/btrfs-man5.asciidoc | 8 > Documentation/btrfs-property.asciidoc | 2 +- > Documentation/btrfs-qgroup.asciidoc | 4 ++-- > Documentation/mkfs.btrfs.asciidoc | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/Documentation/DocConventions b/Documentation/DocConventions > index e84ed7a..969209c 100644 > --- a/Documentation/DocConventions > +++ b/Documentation/DocConventions > @@ -23,7 +23,7 @@ Quotation in subcommands: > - command reference: bold *btrfs fi show* > - section references: italics 'EXAMPLES' > > -- argument name in option desciption: caps in angle brackets > +- argument name in option description: caps in angle brackets >- reference in help text: caps NAME > also possible: caps italics 'NAME' > > @@ -34,6 +34,6 @@ Quotation in subcommands: >- optional parameter with argument: [-p ] > > > -Refrences: > +References: > - full asciidoc syntax: http://asciidoc.org/userguide.html > - cheatsheet: http://powerman.name/doc/asciidoc > diff --git a/Documentation/ReleaseChecklist b/Documentation/ReleaseChecklist > index d8bf50c..7fdbddf 100644 > --- a/Documentation/ReleaseChecklist > +++ b/Documentation/ReleaseChecklist > @@ -4,7 +4,7 @@ Release checklist > Last code touches: > > * make the code ready, collect patches queued for the release > -* look to mailinglist for any relevant last-minute fixes > +* look to mailin glist for any relevant last-minute fixes Wrong position of space, should be mailing list > > Pre-checks: > > @@ -31,7 +31,7 @@ Release: > > Post-release: > > -* write and send announcement mail to mailinglist > +* write and send announcement mail to mailing list > * update wiki://Main_page#News > * update wiki://Changelog#btrfs-progs > * update title on IRC > diff --git a/Documentation/btrfs-man5.asciidoc > b/Documentation/btrfs-man5.asciidoc > index 448710a..c358cef 100644 > --- a/Documentation/btrfs-man5.asciidoc > +++ b/Documentation/btrfs-man5.asciidoc > @@ -156,7 +156,7 @@ under 'nodatacow' are also set the NOCOW file attribute > (see `chattr`(1)). > NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. > + > Updates in-place improve performance for workloads that do frequent > overwrites, > -at the cost of potential partial writes, in case the write is interruted > +at the cost of potential partial writes, in case the write is interrupted > (system crash, device failure). > > *datasum*:: > @@ -171,7 +171,7 @@ corresponding file attribute (see `chattr`(1)). > NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. > + > There is a slight performance gain when checksums are turned off, the > -correspoinding metadata blocks holding the checksums do not need to updated. > +corresponding metadata blocks holding the checksums do not need to updated. You've missed one grammatical error - the end of the sentence should say" do not need to be updated". > The cost of checksumming of the blocks in memory is much lower than the IO, > modern CPUs feature hardware support of the checksumming algorithm. >
[PATCH] Fix typos in docs
Signed-off-by: Andrea Gelmini --- Documentation/DocConventions | 4 ++-- Documentation/ReleaseChecklist| 4 ++-- Documentation/btrfs-man5.asciidoc | 8 Documentation/btrfs-property.asciidoc | 2 +- Documentation/btrfs-qgroup.asciidoc | 4 ++-- Documentation/mkfs.btrfs.asciidoc | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/DocConventions b/Documentation/DocConventions index e84ed7a..969209c 100644 --- a/Documentation/DocConventions +++ b/Documentation/DocConventions @@ -23,7 +23,7 @@ Quotation in subcommands: - command reference: bold *btrfs fi show* - section references: italics 'EXAMPLES' -- argument name in option desciption: caps in angle brackets +- argument name in option description: caps in angle brackets - reference in help text: caps NAME also possible: caps italics 'NAME' @@ -34,6 +34,6 @@ Quotation in subcommands: - optional parameter with argument: [-p ] -Refrences: +References: - full asciidoc syntax: http://asciidoc.org/userguide.html - cheatsheet: http://powerman.name/doc/asciidoc diff --git a/Documentation/ReleaseChecklist b/Documentation/ReleaseChecklist index d8bf50c..7fdbddf 100644 --- a/Documentation/ReleaseChecklist +++ b/Documentation/ReleaseChecklist @@ -4,7 +4,7 @@ Release checklist Last code touches: * make the code ready, collect patches queued for the release -* look to mailinglist for any relevant last-minute fixes +* look to mailin glist for any relevant last-minute fixes Pre-checks: @@ -31,7 +31,7 @@ Release: Post-release: -* write and send announcement mail to mailinglist +* write and send announcement mail to mailing list * update wiki://Main_page#News * update wiki://Changelog#btrfs-progs * update title on IRC diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc index 448710a..c358cef 100644 --- a/Documentation/btrfs-man5.asciidoc +++ b/Documentation/btrfs-man5.asciidoc @@ -156,7 +156,7 @@ under 'nodatacow' are also set the NOCOW file attribute (see `chattr`(1)). NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. + Updates in-place improve performance for workloads that do frequent overwrites, -at the cost of potential partial writes, in case the write is interruted +at the cost of potential partial writes, in case the write is interrupted (system crash, device failure). *datasum*:: @@ -171,7 +171,7 @@ corresponding file attribute (see `chattr`(1)). NOTE: If 'nodatacow' or 'nodatasum' are enabled, compression is disabled. + There is a slight performance gain when checksums are turned off, the -correspoinding metadata blocks holding the checksums do not need to updated. +corresponding metadata blocks holding the checksums do not need to updated. The cost of checksumming of the blocks in memory is much lower than the IO, modern CPUs feature hardware support of the checksumming algorithm. @@ -185,7 +185,7 @@ missing, for example if a stripe member is completely missing from RAID0. Since 4.14, the constraint checks have been improved and are verified on the chunk level, not an the device level. This allows degraded mounts of filesystems with mixed RAID profiles for data and metadata, even if the -device number constraints would not be satisfied for some of the prifles. +device number constraints would not be satisfied for some of the profiles. + Example: metadata -- raid1, data -- single, devices -- /dev/sda, /dev/sdb + @@ -649,7 +649,7 @@ inherent limit of btrfs is 2^64^ (16 EiB) but the linux VFS limit is 2^63^ (8 Ei maximum number of subvolumes:: 2^64^ but depends on the available metadata space, the space consumed by all -subvolume metadata includes bookeeping of the shared extents can be large (MiB, +subvolume metadata includes bookkeeping of the shared extents can be large (MiB, GiB) maximum number of hardlinks of a file in a directory:: diff --git a/Documentation/btrfs-property.asciidoc b/Documentation/btrfs-property.asciidoc index b562717..4bad88b 100644 --- a/Documentation/btrfs-property.asciidoc +++ b/Documentation/btrfs-property.asciidoc @@ -34,7 +34,7 @@ specify what type of object you meant. This is only needed when a property could be set for more then one object type. + Possible types are 's[ubvol]', 'f[ilesystem]', 'i[node]' and 'd[evice]', where -the first lettes is a shortcut. +the first letter is a shortcut. + Set the name of property by 'name'. If no 'name' is specified, all properties for the given object are printed. 'name' is one of diff --git a/Documentation/btrfs-qgroup.asciidoc b/Documentation/btrfs-qgroup.asciidoc index dff0867..dc4c93b 100644 --- a/Documentation/btrfs-qgroup.asciidoc +++ b/Documentation/btrfs-qgroup.asciidoc @@ -52,7 +52,7 @@ assignment would lead to quota inconsistency. See 'QUOTA RESCAN' for more information. --no-rescan Explicitly ask not to do a rescan, even if the assignment will make the quotas
