[PATCH] btrfs: optimize code converge mutex unlock

[Anand Jain]

No functional change rearrange the mutex_unlock.

Signed-off-by: Anand Jain 
---
 fs/btrfs/transaction.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 6348573e26a7..04f07144b45c 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -2265,16 +2265,13 @@ int btrfs_commit_transaction(struct btrfs_trans_handle 
*trans)
}
 
ret = write_all_supers(fs_info, 0);
-   if (ret) {
-   mutex_unlock(&fs_info->tree_log_mutex);
-   goto scrub_continue;
-   }
-
/*
 * the super is written, we can safely allow the tree-loggers
 * to go about their business
 */
mutex_unlock(&fs_info->tree_log_mutex);
+   if (ret)
+   goto scrub_continue;
 
btrfs_finish_extent_commit(trans, fs_info);
 
-- 
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] btrfs: optimize code converge mutex unlock

[Nikolay Borisov]

On 20.12.2017 08:42, Anand Jain wrote:
> No functional change rearrange the mutex_unlock.
> 
> Signed-off-by: Anand Jain 

Reviewed-by: Nikolay Borisov 
> ---
>  fs/btrfs/transaction.c | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 6348573e26a7..04f07144b45c 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -2265,16 +2265,13 @@ int btrfs_commit_transaction(struct 
> btrfs_trans_handle *trans)
>   }
>  
>   ret = write_all_supers(fs_info, 0);
> - if (ret) {
> - mutex_unlock(&fs_info->tree_log_mutex);
> - goto scrub_continue;
> - }
> -
>   /*
>* the super is written, we can safely allow the tree-loggers
>* to go about their business
>*/
>   mutex_unlock(&fs_info->tree_log_mutex);
> + if (ret)
> + goto scrub_continue;
>  
>   btrfs_finish_extent_commit(trans, fs_info);
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] btrfs: optimize code converge mutex unlock

[David Sterba]

On Wed, Dec 20, 2017 at 10:19:14AM +0200, Nikolay Borisov wrote:
> 
> 
> On 20.12.2017 08:42, Anand Jain wrote:
> > No functional change rearrange the mutex_unlock.
> > 
> > Signed-off-by: Anand Jain 
> 
> Reviewed-by: Nikolay Borisov 

Added to for-next.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html