Re: [PATCH] btrfs-progs: fsck-tests: Move reloc tree images to 020-extent-ref-cases

2018-12-03 Thread David Sterba
On Mon, Dec 03, 2018 at 12:39:57PM +0800, Qu Wenruo wrote:
> For reloc tree, despite of its short lifespan, it's still the backref,
> where reloc tree root backref points back to itself, makes it special.
> 
> So it's more approriate to put them into 020-extent-ref-cases.
> 
> Signed-off-by: Qu Wenruo 

Applied, thanks.


[PATCH] btrfs-progs: fsck-tests: Move reloc tree images to 020-extent-ref-cases

2018-12-02 Thread Qu Wenruo
For reloc tree, despite of its short lifespan, it's still the backref,
where reloc tree root backref points back to itself, makes it special.

So it's more approriate to put them into 020-extent-ref-cases.

Signed-off-by: Qu Wenruo 
---
 tests/fsck-tests/015-tree-reloc-tree/test.sh|  16 
 tests/fsck-tests/020-extent-ref-cases/test.sh   |   5 +
 .../tree_reloc_for_data_reloc.img.xz| Bin
 .../tree_reloc_for_fs_tree.img.xz   | Bin
 4 files changed, 5 insertions(+), 16 deletions(-)
 delete mode 100755 tests/fsck-tests/015-tree-reloc-tree/test.sh
 rename tests/fsck-tests/{015-tree-reloc-tree => 
020-extent-ref-cases}/tree_reloc_for_data_reloc.img.xz (100%)
 rename tests/fsck-tests/{015-tree-reloc-tree => 
020-extent-ref-cases}/tree_reloc_for_fs_tree.img.xz (100%)

diff --git a/tests/fsck-tests/015-tree-reloc-tree/test.sh 
b/tests/fsck-tests/015-tree-reloc-tree/test.sh
deleted file mode 100755
index 5d9d5122fd06..
--- a/tests/fsck-tests/015-tree-reloc-tree/test.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-# Make sure btrfs check won't report any false alerts for valid image with
-# reloc tree.
-#
-# Also due to the short life span of reloc tree, save the as dump example for
-# later usage.
-
-source "$TEST_TOP/common"
-
-check_prereq btrfs
-
-check_image() {
-   run_check "$TOP/btrfs" check "$1"
-}
-
-check_all_images
diff --git a/tests/fsck-tests/020-extent-ref-cases/test.sh 
b/tests/fsck-tests/020-extent-ref-cases/test.sh
index a1bf75b14486..2f5a05cca4d4 100755
--- a/tests/fsck-tests/020-extent-ref-cases/test.sh
+++ b/tests/fsck-tests/020-extent-ref-cases/test.sh
@@ -14,6 +14,11 @@
 #   Containing a block group and its first extent at
 #   the beginning of leaf.
 #   Which caused false alert for lowmem mode.
+#
+# Special cases with some rare backref type
+# * reloc tree
+#   For both fs tree and data reloc tree.
+#   Special for its backref pointing to itself and its short life span.
 
 source "$TEST_TOP/common"
 
diff --git 
a/tests/fsck-tests/015-tree-reloc-tree/tree_reloc_for_data_reloc.img.xz 
b/tests/fsck-tests/020-extent-ref-cases/tree_reloc_for_data_reloc.img.xz
similarity index 100%
rename from 
tests/fsck-tests/015-tree-reloc-tree/tree_reloc_for_data_reloc.img.xz
rename to tests/fsck-tests/020-extent-ref-cases/tree_reloc_for_data_reloc.img.xz
diff --git a/tests/fsck-tests/015-tree-reloc-tree/tree_reloc_for_fs_tree.img.xz 
b/tests/fsck-tests/020-extent-ref-cases/tree_reloc_for_fs_tree.img.xz
similarity index 100%
rename from tests/fsck-tests/015-tree-reloc-tree/tree_reloc_for_fs_tree.img.xz
rename to tests/fsck-tests/020-extent-ref-cases/tree_reloc_for_fs_tree.img.xz
-- 
2.19.2