Re: [PATCH 0/2] btrfs-progs: check: enhanced progress indicator

2018-07-16 Thread David Sterba
On Wed, Jul 04, 2018 at 09:20:12PM +0200, Stéphane Lesimple wrote:
> This patch replaces the current ".oOo."-style progress indicator of
> btrfs check (-p), by a more helpful live indication of the check progress.
> I've been using it on a custom btrfs-progs version since 2015.
> 
> Here's how the output looks like on a 22 Tb 5-disk RAID1 FS:
> 
> # btrfs check -p /dev/mapper/luks-ST1VN0004-
> Opening filesystem to check...
> Checking filesystem on /dev/mapper/luks-ST1VN0004-
> UUID: ----
> [1/7] checking extents   (0:20:21 elapsed, 950958 items checked)
> [2/7] checking root items(0:01:29 elapsed, 15121 items checked)
> [3/7] checking free space cache  (0:00:11 elapsed, 4928 items checked)
> [4/7] checking fs roots  (0:51:31 elapsed, 600892 items checked)
> [5/7] checking csums (0:14:35 elapsed, 754522 items checked)
> [6/7] checking root refs (0:00:00 elapsed, 232 items checked)
> [7/7] checking quota groups skipped (not enabled on this FS)
> found 5286458060800 bytes used, no error found

Nice, this looks better than what we have now. Patches applied, with
some minor coding style adjustments and I changed the update period
back to 1 second, 50ms is IMHO too frequent for an operation that can
run for tens of minutes. Also as a safety against dumping too much
information to the log into if the output is redirected.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] btrfs-progs: check: enhanced progress indicator

2018-07-04 Thread Stéphane Lesimple
This patch replaces the current ".oOo."-style progress indicator of
btrfs check (-p), by a more helpful live indication of the check progress.
I've been using it on a custom btrfs-progs version since 2015.

Here's how the output looks like on a 22 Tb 5-disk RAID1 FS:

# btrfs check -p /dev/mapper/luks-ST1VN0004-
Opening filesystem to check...
Checking filesystem on /dev/mapper/luks-ST1VN0004-
UUID: ----
[1/7] checking extents   (0:20:21 elapsed, 950958 items checked)
[2/7] checking root items(0:01:29 elapsed, 15121 items checked)
[3/7] checking free space cache  (0:00:11 elapsed, 4928 items checked)
[4/7] checking fs roots  (0:51:31 elapsed, 600892 items checked)
[5/7] checking csums (0:14:35 elapsed, 754522 items checked)
[6/7] checking root refs (0:00:00 elapsed, 232 items checked)
[7/7] checking quota groups skipped (not enabled on this FS)
found 5286458060800 bytes used, no error found

The code is also viewable at https://github.com/kdave/btrfs-progs/pull/69

Stéphane Lesimple (2):
  btrfs-progs: fix nanosecs in task_period_start
  btrfs-progs: check: enhanced progress indicator

 check/main.c| 176 ++--
 check/mode-common.h |  20 ++
 check/mode-lowmem.c |   1 +
 convert/main.c  |   2 +-
 qgroup-verify.c |   7 +++
 qgroup-verify.h |   2 +
 task-utils.c|  10 ++-
 task-utils.h|   3 +-
 8 files changed, 155 insertions(+), 66 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html