Re: [PATCH 0/3] Btrfs: populate heuristic with detection logic

2017-07-24 Thread Josef Bacik
On Mon, Jul 24, 2017 at 02:37:05PM +0300, Timofey Titovets wrote:
> Based on kdave for-next
> As heuristic skeleton already merged
> Populate heuristic with basic code that:
> 1. Collect sample from input data
> 2. Calculate byte set for sample
>For detect easily compressible data
> 3. Calculate byte core set size
>For detect easily and not compressible data
> 
> Timofey Titovets (3):
>   Btrfs: heuristic add simple sampling logic
>   Btrfs: heuristic add byte set calculation
>   Btrfs: heuristic add byte core set calculation
> 
>  fs/btrfs/compression.c | 111 
> -
>  fs/btrfs/compression.h |  14 +++
>  2 files changed, 123 insertions(+), 2 deletions(-)
> 

Overall these look fine, I'd like more verbose changelogs to describe in more
detail the heuristic you are adding.  I had to go back and work out what you
were doing a few times because it wasn't clear what each patch was doing.
Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/3] Btrfs: populate heuristic with detection logic

2017-07-24 Thread Timofey Titovets
Based on kdave for-next
As heuristic skeleton already merged
Populate heuristic with basic code that:
1. Collect sample from input data
2. Calculate byte set for sample
   For detect easily compressible data
3. Calculate byte core set size
   For detect easily and not compressible data

Timofey Titovets (3):
  Btrfs: heuristic add simple sampling logic
  Btrfs: heuristic add byte set calculation
  Btrfs: heuristic add byte core set calculation

 fs/btrfs/compression.c | 111 -
 fs/btrfs/compression.h |  14 +++
 2 files changed, 123 insertions(+), 2 deletions(-)

--
2.13.3
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html