Re: [PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own

2018-02-01 Thread Qu Wenruo 


On 2018年02月02日 00:05, David Sterba wrote:
> On Thu, Feb 01, 2018 at 02:45:38PM +0800, Qu Wenruo wrote:
>> As usual, the main part is over 500K so the biggest patch won't reach
>> mail list.
>> Please fetch the whole branch from github:
>> https://github.com/adam900710/btrfs-progs/tree/split_check
> 
> Thanks, patches added to devel, with some more adjustments.
> 
>> Despite the update, a new patch is introduced, to address the tons of
>> BORING errors and warning from checkpatch.pl.
> 
> The checkpatch script can report lots of things to fix, but please note
> that not all of them match the style we use. I've updated the patch 3/3
> and undone some of the line splits, because it's the example where the
> code looks worse after fixing.

Yep, some 81/82 chars modification is not that elegant.

> 
> We'd probably have to host our modified version of checkpatch so the
> warnings don't get reported repeatedly.

That would be the best case, I could take some spare time to port
checkpatch to btrfs-progs.

Thanks,
Qu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



signature.asc
Description: OpenPGP digital signature

Re: [PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own

2018-02-01 Thread David Sterba 
On Thu, Feb 01, 2018 at 02:45:38PM +0800, Qu Wenruo wrote:
> As usual, the main part is over 500K so the biggest patch won't reach
> mail list.
> Please fetch the whole branch from github:
> https://github.com/adam900710/btrfs-progs/tree/split_check

Thanks, patches added to devel, with some more adjustments.

> Despite the update, a new patch is introduced, to address the tons of
> BORING errors and warning from checkpatch.pl.

The checkpatch script can report lots of things to fix, but please note
that not all of them match the style we use. I've updated the patch 3/3
and undone some of the line splits, because it's the example where the
code looks worse after fixing.

We'd probably have to host our modified version of checkpatch so the
warnings don't get reported repeatedly.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own

2018-01-31 Thread Qu Wenruo 
As usual, the main part is over 500K so the biggest patch won't reach
mail list.
Please fetch the whole branch from github:
https://github.com/adam900710/btrfs-progs/tree/split_check

This update rebased (the truth is, it's re-created other than rebase)
the branch to David's devel branch, whose head is:

commit cfe255515ae0a27fdd8e612a884b94ffb703acdf (david/devel)
Author: Qu Wenruo 
Date:   Thu Jan 18 16:38:23 2018 +0800

btrfs-progs: check: Move reset_cached_block_groups to check/common.c

Reviewed-by: Su Yue 
Signed-off-by: Qu Wenruo 


Despite the update, a new patch is introduced, to address the tons of
BORING errors and warning from checkpatch.pl.

Qu Wenruo (3):
  btrfs-progs: check: Move lowmem check code to its own
check/lowmem.[ch]
  btrfs-progs: check/lowmem: Cleanup unnecessary _v2 suffix
  btrfs-progs: check: Cleanup all checkpatch error and warning

 Makefile   | 2 +-
 check/lowmem.c |  4579 
 check/lowmem.h | 5 +
 check/main.c   | 12772 ++-
 4 files changed, 8694 insertions(+), 8664 deletions(-)
 create mode 100644 check/lowmem.c

-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html