Re: Missing __error symbol in btrfs-progs-4.10

2017-03-27 Thread David Sterba
On Sun, Mar 26, 2017 at 04:37:05PM -0400, Mike Gilbert wrote:
> A Gentoo user reports that snapper broke after upgrading to btrfs-progs-4.10.
> 
> snapper: symbol lookup error: /usr/lib64/libbtrfs.so.0: undefined
> symbol: __error
> 
> https://bugs.gentoo.org/show_bug.cgi?id=613890
> 
> It seems that the __error symbol is referenced, but not included in libbtrfs.
> 
> Exporting this symbol seems like a bad idea, so I would suggest
> renaming it, or go back to inlining it in the headers.

Right, the name is too generic. I'd like to keep the function not
inlined, so I'll rename them to __btrfs_error etc, but the macros could
still clash with other symbols from the library user.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Missing __error symbol in btrfs-progs-4.10

2017-03-26 Thread Mike Gilbert
A Gentoo user reports that snapper broke after upgrading to btrfs-progs-4.10.

snapper: symbol lookup error: /usr/lib64/libbtrfs.so.0: undefined
symbol: __error

https://bugs.gentoo.org/show_bug.cgi?id=613890

It seems that the __error symbol is referenced, but not included in libbtrfs.

Exporting this symbol seems like a bad idea, so I would suggest
renaming it, or go back to inlining it in the headers.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html