Re: 'filesystem resize max' tries to use devid 1

2012-04-24 Thread Chris Mason
On Tue, Apr 24, 2012 at 11:42:26AM -0400, Josef Bacik wrote:
> On Tue, Apr 24, 2012 at 06:39:03PM +0300, Ilya Dryomov wrote:
> > On Tue, Apr 24, 2012 at 11:31:15AM -0400, Josef Bacik wrote:
> > > On Sun, Apr 22, 2012 at 11:03:06PM -0400, Jeremy Atkins wrote:
> > > > Back story:
> > > > I started my pool with a 200gb partition at the end of my drive (sdc5)
> > > > , until I was able to clear out the data at the beginning of my drive.
> > > >  When I was ready, I ran `btrfs dev add /dev/sdc4 /` then `btrfs dev
> > > > del /dev/sdc5 /`,
> > > > 
> > > > $ sudo btrfs fi resize max /
> > > > Resize '/' of 'max'
> > > > ERROR: unable to resize '/' - Invalid argument
> > > > 
> > > > in dmesg i see:
> > > > [   72.729685] btrfs: resizer unable to find device 1
> > > > 
> > > > $ sudo btrfs fi df /
> > > > Data: total=34.00GB, used=17.79GB
> > > > System, DUP: total=64.00MB, used=20.00KB
> > > > Metadata, DUP: total=33.50GB, used=394.93MB
> > > > 
> > > > $ sudo btrfs fi sh
> > > > Label: none  uuid: b0ad55e2-09e0-4658-8cab-d2e11ba03753
> > > >         Total devices 1 FS bytes used 17.18GB
> > > >         devid    2 size 1.62TB used 101.12GB path /dev/sdc4
> > > > 
> > > > 
> > > > $ uname -r
> > > > 3.3.2-1.fc16.x86_64
> > > > 
> > > > btrfs-progs version is current git master ( commit 1957076 )
> > > > 
> > > > After writing this email, and searching around the wiki some, I
> > > > discovered the command to resize specific devids,
> > > > 
> > > > [antrat@tbox ~]$ sudo btrfs fi resize 2:max /
> > > > Resize '/' of '2:max'
> > > > 
> > > > and in dmesg:
> > > > [ 1661.933884] btrfs: resizing devid 2
> > > > [ 1661.933895] btrfs: new size for /dev/sdc4 is 1995564908544
> > > 
> > > Hrm, if we're using filesystem resize max we should probably just max out 
> > > all
> > > the devices and not require one specific device, what do you think Ilya?
> > 
> > I'd keep the devid:max syntax for maxing out a single device and add a
> > new fs:max or similar to resize all devices.  ABI here is just a string,
> > so I think it can be easily done.
> > 
> 
> Right I think the devid:max thing is handy for people who want to do specific
> things, but I think just a normal btrfs fi resize max should do all devices 
> for
> simplicity and easy of use, no need for a fs:max.  Thanks,
> 

Agreed, I hadn't thought of it this way in the past, but I can see
people expecting max to mean max out all the devices.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 'filesystem resize max' tries to use devid 1

2012-04-24 Thread Ilya Dryomov
On Tue, Apr 24, 2012 at 11:42:26AM -0400, Josef Bacik wrote:
> On Tue, Apr 24, 2012 at 06:39:03PM +0300, Ilya Dryomov wrote:
> > On Tue, Apr 24, 2012 at 11:31:15AM -0400, Josef Bacik wrote:
> > > On Sun, Apr 22, 2012 at 11:03:06PM -0400, Jeremy Atkins wrote:
> > > > Back story:
> > > > I started my pool with a 200gb partition at the end of my drive (sdc5)
> > > > , until I was able to clear out the data at the beginning of my drive.
> > > >  When I was ready, I ran `btrfs dev add /dev/sdc4 /` then `btrfs dev
> > > > del /dev/sdc5 /`,
> > > > 
> > > > $ sudo btrfs fi resize max /
> > > > Resize '/' of 'max'
> > > > ERROR: unable to resize '/' - Invalid argument
> > > > 
> > > > in dmesg i see:
> > > > [   72.729685] btrfs: resizer unable to find device 1
> > > > 
> > > > $ sudo btrfs fi df /
> > > > Data: total=34.00GB, used=17.79GB
> > > > System, DUP: total=64.00MB, used=20.00KB
> > > > Metadata, DUP: total=33.50GB, used=394.93MB
> > > > 
> > > > $ sudo btrfs fi sh
> > > > Label: none  uuid: b0ad55e2-09e0-4658-8cab-d2e11ba03753
> > > >         Total devices 1 FS bytes used 17.18GB
> > > >         devid    2 size 1.62TB used 101.12GB path /dev/sdc4
> > > > 
> > > > 
> > > > $ uname -r
> > > > 3.3.2-1.fc16.x86_64
> > > > 
> > > > btrfs-progs version is current git master ( commit 1957076 )
> > > > 
> > > > After writing this email, and searching around the wiki some, I
> > > > discovered the command to resize specific devids,
> > > > 
> > > > [antrat@tbox ~]$ sudo btrfs fi resize 2:max /
> > > > Resize '/' of '2:max'
> > > > 
> > > > and in dmesg:
> > > > [ 1661.933884] btrfs: resizing devid 2
> > > > [ 1661.933895] btrfs: new size for /dev/sdc4 is 1995564908544
> > > 
> > > Hrm, if we're using filesystem resize max we should probably just max out 
> > > all
> > > the devices and not require one specific device, what do you think Ilya?
> > 
> > I'd keep the devid:max syntax for maxing out a single device and add a
> > new fs:max or similar to resize all devices.  ABI here is just a string,
> > so I think it can be easily done.
> > 
> 
> Right I think the devid:max thing is handy for people who want to do specific
> things, but I think just a normal btrfs fi resize max should do all devices 
> for
> simplicity and easy of use, no need for a fs:max.  Thanks,

Sorry, I misread.  'btrfs fi resize max ' should of course resize
the entire FS.  I think this popped up before, at least a couple times.
I'll do it if nobody else wants to.

Thanks,

Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 'filesystem resize max' tries to use devid 1

2012-04-24 Thread Josef Bacik
On Tue, Apr 24, 2012 at 06:39:03PM +0300, Ilya Dryomov wrote:
> On Tue, Apr 24, 2012 at 11:31:15AM -0400, Josef Bacik wrote:
> > On Sun, Apr 22, 2012 at 11:03:06PM -0400, Jeremy Atkins wrote:
> > > Back story:
> > > I started my pool with a 200gb partition at the end of my drive (sdc5)
> > > , until I was able to clear out the data at the beginning of my drive.
> > >  When I was ready, I ran `btrfs dev add /dev/sdc4 /` then `btrfs dev
> > > del /dev/sdc5 /`,
> > > 
> > > $ sudo btrfs fi resize max /
> > > Resize '/' of 'max'
> > > ERROR: unable to resize '/' - Invalid argument
> > > 
> > > in dmesg i see:
> > > [   72.729685] btrfs: resizer unable to find device 1
> > > 
> > > $ sudo btrfs fi df /
> > > Data: total=34.00GB, used=17.79GB
> > > System, DUP: total=64.00MB, used=20.00KB
> > > Metadata, DUP: total=33.50GB, used=394.93MB
> > > 
> > > $ sudo btrfs fi sh
> > > Label: none  uuid: b0ad55e2-09e0-4658-8cab-d2e11ba03753
> > >         Total devices 1 FS bytes used 17.18GB
> > >         devid    2 size 1.62TB used 101.12GB path /dev/sdc4
> > > 
> > > 
> > > $ uname -r
> > > 3.3.2-1.fc16.x86_64
> > > 
> > > btrfs-progs version is current git master ( commit 1957076 )
> > > 
> > > After writing this email, and searching around the wiki some, I
> > > discovered the command to resize specific devids,
> > > 
> > > [antrat@tbox ~]$ sudo btrfs fi resize 2:max /
> > > Resize '/' of '2:max'
> > > 
> > > and in dmesg:
> > > [ 1661.933884] btrfs: resizing devid 2
> > > [ 1661.933895] btrfs: new size for /dev/sdc4 is 1995564908544
> > 
> > Hrm, if we're using filesystem resize max we should probably just max out 
> > all
> > the devices and not require one specific device, what do you think Ilya?
> 
> I'd keep the devid:max syntax for maxing out a single device and add a
> new fs:max or similar to resize all devices.  ABI here is just a string,
> so I think it can be easily done.
> 

Right I think the devid:max thing is handy for people who want to do specific
things, but I think just a normal btrfs fi resize max should do all devices for
simplicity and easy of use, no need for a fs:max.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 'filesystem resize max' tries to use devid 1

2012-04-24 Thread Ilya Dryomov
On Tue, Apr 24, 2012 at 11:31:15AM -0400, Josef Bacik wrote:
> On Sun, Apr 22, 2012 at 11:03:06PM -0400, Jeremy Atkins wrote:
> > Back story:
> > I started my pool with a 200gb partition at the end of my drive (sdc5)
> > , until I was able to clear out the data at the beginning of my drive.
> >  When I was ready, I ran `btrfs dev add /dev/sdc4 /` then `btrfs dev
> > del /dev/sdc5 /`,
> > 
> > $ sudo btrfs fi resize max /
> > Resize '/' of 'max'
> > ERROR: unable to resize '/' - Invalid argument
> > 
> > in dmesg i see:
> > [   72.729685] btrfs: resizer unable to find device 1
> > 
> > $ sudo btrfs fi df /
> > Data: total=34.00GB, used=17.79GB
> > System, DUP: total=64.00MB, used=20.00KB
> > Metadata, DUP: total=33.50GB, used=394.93MB
> > 
> > $ sudo btrfs fi sh
> > Label: none  uuid: b0ad55e2-09e0-4658-8cab-d2e11ba03753
> >         Total devices 1 FS bytes used 17.18GB
> >         devid    2 size 1.62TB used 101.12GB path /dev/sdc4
> > 
> > 
> > $ uname -r
> > 3.3.2-1.fc16.x86_64
> > 
> > btrfs-progs version is current git master ( commit 1957076 )
> > 
> > After writing this email, and searching around the wiki some, I
> > discovered the command to resize specific devids,
> > 
> > [antrat@tbox ~]$ sudo btrfs fi resize 2:max /
> > Resize '/' of '2:max'
> > 
> > and in dmesg:
> > [ 1661.933884] btrfs: resizing devid 2
> > [ 1661.933895] btrfs: new size for /dev/sdc4 is 1995564908544
> 
> Hrm, if we're using filesystem resize max we should probably just max out all
> the devices and not require one specific device, what do you think Ilya?

I'd keep the devid:max syntax for maxing out a single device and add a
new fs:max or similar to resize all devices.  ABI here is just a string,
so I think it can be easily done.

Thanks,

Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 'filesystem resize max' tries to use devid 1

2012-04-24 Thread Josef Bacik
On Sun, Apr 22, 2012 at 11:03:06PM -0400, Jeremy Atkins wrote:
> Back story:
> I started my pool with a 200gb partition at the end of my drive (sdc5)
> , until I was able to clear out the data at the beginning of my drive.
>  When I was ready, I ran `btrfs dev add /dev/sdc4 /` then `btrfs dev
> del /dev/sdc5 /`,
> 
> $ sudo btrfs fi resize max /
> Resize '/' of 'max'
> ERROR: unable to resize '/' - Invalid argument
> 
> in dmesg i see:
> [   72.729685] btrfs: resizer unable to find device 1
> 
> $ sudo btrfs fi df /
> Data: total=34.00GB, used=17.79GB
> System, DUP: total=64.00MB, used=20.00KB
> Metadata, DUP: total=33.50GB, used=394.93MB
> 
> $ sudo btrfs fi sh
> Label: none  uuid: b0ad55e2-09e0-4658-8cab-d2e11ba03753
>         Total devices 1 FS bytes used 17.18GB
>         devid    2 size 1.62TB used 101.12GB path /dev/sdc4
> 
> 
> $ uname -r
> 3.3.2-1.fc16.x86_64
> 
> btrfs-progs version is current git master ( commit 1957076 )
> 
> After writing this email, and searching around the wiki some, I
> discovered the command to resize specific devids,
> 
> [antrat@tbox ~]$ sudo btrfs fi resize 2:max /
> Resize '/' of '2:max'
> 
> and in dmesg:
> [ 1661.933884] btrfs: resizing devid 2
> [ 1661.933895] btrfs: new size for /dev/sdc4 is 1995564908544

Hrm, if we're using filesystem resize max we should probably just max out all
the devices and not require one specific device, what do you think Ilya?

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html