Re: [PATCH 2/5] btrfs: Split btrfs_del_delalloc_inode into 2 functions
On Fri, May 11, 2018 at 11:39:56AM +0300, Nikolay Borisov wrote: > On 11.05.2018 08:44, Anand Jain wrote: > > On 04/27/2018 05:21 PM, Nikolay Borisov wrote: > >> This is in preparation of fixing delalloc inodes leakage on transaction > >> abort. Also export the new function. > >> > >> Signed-off-by: Nikolay Borisov > > > > nit: I think we are reserving function prefix __ for some special > > functions. I am not sure if the function name should prefix with __ > > here. > > Generally __ prefix is used for some internal function. In this case the > gist of the function (with no locking) is behind the __ prefixed > function, whereas the non __ version adds the necessary locking. I think > this is a fairly well-established pattern in the kernel. Yes, this is one of few patterns where __ is ok. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/5] btrfs: Split btrfs_del_delalloc_inode into 2 functions
On 11.05.2018 08:44, Anand Jain wrote: > > > On 04/27/2018 05:21 PM, Nikolay Borisov wrote: >> This is in preparation of fixing delalloc inodes leakage on transaction >> abort. Also export the new function. >> >> Signed-off-by: Nikolay Borisov > > nit: I think we are reserving function prefix __ for some special > functions. I am not sure if the function name should prefix with __ > here. Generally __ prefix is used for some internal function. In this case the gist of the function (with no locking) is behind the __ prefixed function, whereas the non __ version adds the necessary locking. I think this is a fairly well-established pattern in the kernel. > > Reviewed-by: Anand Jain > > Thanks, Anand > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/5] btrfs: Split btrfs_del_delalloc_inode into 2 functions
On 04/27/2018 05:21 PM, Nikolay Borisov wrote: This is in preparation of fixing delalloc inodes leakage on transaction abort. Also export the new function. Signed-off-by: Nikolay Borisov nit: I think we are reserving function prefix __ for some special functions. I am not sure if the function name should prefix with __ here. Reviewed-by: Anand Jain Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html