Re: [PATCH v3 01/11] Btrfs: remove stale comment referencing vmtruncate()

[Omar Sandoval]

On Fri, May 11, 2018 at 12:19:43PM +0200, David Sterba wrote:
> On Fri, May 11, 2018 at 12:56:06AM -0700, Omar Sandoval wrote:
> > From: Omar Sandoval 
> > 
> > Commit a41ad394a03b ("Btrfs: convert to the new truncate sequence")
> > changed vmtruncate() to truncate_setsize() but didn't update the comment
> > above it. truncate_setsize() never fails (the IS_SWAPFILE() check
> > happens elsewhere), so remove the comment.
> 
> There's one more mention of vmtruncate at btrfs_page_mkwrite, can you
> please remove it and review that the comment is not stale in other
> respects? Thanks.

Yup, I'll take a look at that.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 01/11] Btrfs: remove stale comment referencing vmtruncate()

[David Sterba]

On Fri, May 11, 2018 at 12:56:06AM -0700, Omar Sandoval wrote:
> From: Omar Sandoval 
> 
> Commit a41ad394a03b ("Btrfs: convert to the new truncate sequence")
> changed vmtruncate() to truncate_setsize() but didn't update the comment
> above it. truncate_setsize() never fails (the IS_SWAPFILE() check
> happens elsewhere), so remove the comment.

There's one more mention of vmtruncate at btrfs_page_mkwrite, can you
please remove it and review that the comment is not stale in other
respects? Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html