Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-10-11 Thread Daniel
Hello Josef,

Josef Bacik jbacik at fusionio.com writes:

 
 On Thu, Sep 05, 2013 at 10:45:23AM -0500, Eric Sandeen wrote:

[...]

  This was a regression around July 3; there was no regression test at
  the time.
  
  [615f2867854c186a37cb2e2e5a2e13e9ed4ab0df] Btrfs-progs: cleanup similar 
code in open_ctree_* and close_ctree
  
  broke it.
  
  Patches were sent to the list to fix it on July 17,
  
  https://patchwork.kernel.org/patch/2828820/
  
  but they haven't been merged into the main repo.
  
  I sent a regression test for it to the list on Aug 4, but nobody
  reviewed it, so it hasn't been merged into the test suite, either.
  
  Winning all around!
 
 Alright, alright I'll review it, Jesus.  ;),

Is there any progress on this or can I help with solving this somehow?
 
 Josef

Daniel

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-10-11 Thread Wang Shilong

Hello Daniel,

On 10/11/2013 03:52 PM, Daniel wrote:

Hello Josef,

Josef Bacik jbacik at fusionio.com writes:


On Thu, Sep 05, 2013 at 10:45:23AM -0500, Eric Sandeen wrote:

[...]


This was a regression around July 3; there was no regression test at
the time.

[615f2867854c186a37cb2e2e5a2e13e9ed4ab0df] Btrfs-progs: cleanup similar

code in open_ctree_* and close_ctree

broke it.

Patches were sent to the list to fix it on July 17,

https://patchwork.kernel.org/patch/2828820/

but they haven't been merged into the main repo.

I sent a regression test for it to the list on Aug 4, but nobody
reviewed it, so it hasn't been merged into the test suite, either.

Winning all around!

Alright, alright I'll review it, Jesus.  ;),

Is there any progress on this or can I help with solving this somehow?

This problem has been fixed , but it did not come into Chris's branch.
But it did come into david's integration branches.

http://github.com/kdave/btrfs-progs.git integration-20131008

Thanks,
Wang
  

Josef

Daniel

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Тимофей Титовец
Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
No valid Btrfs found on file
unable to open ctree
conversion aborted.
Ubuntu 13.04
Kernel: 3.11
btrfs-progs git version 0.20-git20130822~194aa4a13

way to reproduce error:
$ truncate -s 4G file
$ mkfs.ext4 file #say yes to create fs on non block device.
$ btrfs-convert file
 No valid Btrfs found on file
 unable to open ctree
 conversion aborted.

With best regards,
Timofey.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Roman Mamedov
On Thu, 5 Sep 2013 15:54:07 +0100
Hugo Mills h...@carfax.org.uk wrote:

 On Thu, Sep 05, 2013 at 05:43:27PM +0300, Тимофей Титовец wrote:
  Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
  No valid Btrfs found on file
  unable to open ctree
  conversion aborted.
  Ubuntu 13.04
  Kernel: 3.11
  btrfs-progs git version 0.20-git20130822~194aa4a13
  
  way to reproduce error:
  $ truncate -s 4G file
  $ mkfs.ext4 file #say yes to create fs on non block device.
  $ btrfs-convert file
   No valid Btrfs found on file
   unable to open ctree
   conversion aborted.
 
I'm guessing here, but I suspect you will need to create a loopback
 device so that btrfs-convert can look at it as a block device rather
 than as a file:
 
 # losetup -f --show file
 /dev/loop0
 # btrfs-convert /dev/loop0
 
Hugo.
 

Nope, just today I saw someone report the same problem in a blog comment:
http://popey.com/blog/2013/09/02/fun-with-btrfs-on-ubuntu/#comment-9704

---
# umount /dev/sdb1
# fsck -f /dev/sdb1
fsck из util-linux 2.20.1
e2fsck 1.42.8 (20-Jun-2013)
data500: 144653/30531584 files (0.9% non-contiguous), 102659367/122096384
blocks

# btrfs-convert /dev/sdb1
No valid Btrfs found on /dev/sdb1
unable to open ctree
conversion aborted.

Ubuntu 13.10
btrfs-tools 0.19+20130705-1
---

It looks like a bug in btrfs-convert.

-- 
With respect,
Roman


signature.asc
Description: PGP signature


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Hugo Mills
On Thu, Sep 05, 2013 at 09:06:19PM +0600, Roman Mamedov wrote:
 On Thu, 5 Sep 2013 15:54:07 +0100
 Hugo Mills h...@carfax.org.uk wrote:
 
  On Thu, Sep 05, 2013 at 05:43:27PM +0300, Тимофей Титовец wrote:
   Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
   No valid Btrfs found on file
   unable to open ctree
   conversion aborted.
   Ubuntu 13.04
   Kernel: 3.11
   btrfs-progs git version 0.20-git20130822~194aa4a13
   
   way to reproduce error:
   $ truncate -s 4G file
   $ mkfs.ext4 file #say yes to create fs on non block device.
   $ btrfs-convert file
No valid Btrfs found on file
unable to open ctree
conversion aborted.
  
 I'm guessing here, but I suspect you will need to create a loopback
  device so that btrfs-convert can look at it as a block device rather
  than as a file:
  
  # losetup -f --show file
  /dev/loop0
  # btrfs-convert /dev/loop0
  
 Hugo.
  
 
 Nope, just today I saw someone report the same problem in a blog comment:
 http://popey.com/blog/2013/09/02/fun-with-btrfs-on-ubuntu/#comment-9704

   It's the same person, in fact. I'd not seen that the one on popey's
blog was doing it with block devices. This does indeed look like a
fairly drastic bug...

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
 --- Is it true that last known good on Windows XP --- 
boots into CP/M? 


signature.asc
Description: Digital signature


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Roman Mamedov
On Thu, 5 Sep 2013 16:30:23 +0100
Hugo Mills h...@carfax.org.uk wrote:

  Nope, just today I saw someone report the same problem in a blog comment:
  http://popey.com/blog/2013/09/02/fun-with-btrfs-on-ubuntu/#comment-9704
 
It's the same person, in fact.

FWIW both names are Cyrillic but they are different.


-- 
With respect,
Roman


signature.asc
Description: PGP signature


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Hugo Mills
On Thu, Sep 05, 2013 at 05:43:27PM +0300, Тимофей Титовец wrote:
 Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
 No valid Btrfs found on file
 unable to open ctree
 conversion aborted.
 Ubuntu 13.04
 Kernel: 3.11
 btrfs-progs git version 0.20-git20130822~194aa4a13
 
 way to reproduce error:
 $ truncate -s 4G file
 $ mkfs.ext4 file #say yes to create fs on non block device.
 $ btrfs-convert file
  No valid Btrfs found on file
  unable to open ctree
  conversion aborted.

   I'm guessing here, but I suspect you will need to create a loopback
device so that btrfs-convert can look at it as a block device rather
than as a file:

# losetup -f --show file
/dev/loop0
# btrfs-convert /dev/loop0

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
  --- Eighth Army Push Bottles Up Germans -- WWII newspaper ---  
 headline (possibly apocryphal)  


signature.asc
Description: Digital signature


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Eric Sandeen
On 9/5/13 9:43 AM, Тимофей Титовец wrote:
 Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
 No valid Btrfs found on file
 unable to open ctree
 conversion aborted.
 Ubuntu 13.04
 Kernel: 3.11
 btrfs-progs git version 0.20-git20130822~194aa4a13
 
 way to reproduce error:
 $ truncate -s 4G file
 $ mkfs.ext4 file #say yes to create fs on non block device.
 $ btrfs-convert file
  No valid Btrfs found on file
  unable to open ctree
  conversion aborted.

This was a regression around July 3; there was no regression test at
the time.

[615f2867854c186a37cb2e2e5a2e13e9ed4ab0df] Btrfs-progs: cleanup similar code in 
open_ctree_* and close_ctree

broke it.

Patches were sent to the list to fix it on July 17,

https://patchwork.kernel.org/patch/2828820/

but they haven't been merged into the main repo.

I sent a regression test for it to the list on Aug 4, but nobody
reviewed it, so it hasn't been merged into the test suite, either.

Winning all around!

-Eric
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1

2013-09-05 Thread Josef Bacik
On Thu, Sep 05, 2013 at 10:45:23AM -0500, Eric Sandeen wrote:
 On 9/5/13 9:43 AM, Тимофей Титовец wrote:
  Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
  No valid Btrfs found on file
  unable to open ctree
  conversion aborted.
  Ubuntu 13.04
  Kernel: 3.11
  btrfs-progs git version 0.20-git20130822~194aa4a13
  
  way to reproduce error:
  $ truncate -s 4G file
  $ mkfs.ext4 file #say yes to create fs on non block device.
  $ btrfs-convert file
   No valid Btrfs found on file
   unable to open ctree
   conversion aborted.
 
 This was a regression around July 3; there was no regression test at
 the time.
 
 [615f2867854c186a37cb2e2e5a2e13e9ed4ab0df] Btrfs-progs: cleanup similar code 
 in open_ctree_* and close_ctree
 
 broke it.
 
 Patches were sent to the list to fix it on July 17,
 
 https://patchwork.kernel.org/patch/2828820/
 
 but they haven't been merged into the main repo.
 
 I sent a regression test for it to the list on Aug 4, but nobody
 reviewed it, so it hasn't been merged into the test suite, either.
 
 Winning all around!

Alright, alright I'll review it, Jesus.  ;),

Josef
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html