Re: btrfs-progs 4.6 won't build on CentOS6

2016-06-23 Thread Steven Haigh

On 2016-06-24 13:22, Eric Sandeen wrote:

On 6/23/16 8:49 PM, Steven Haigh wrote:
I've tried to build the new tools for CentOS 6 / Scientific Linux 6 / 
RHEL 6 etc.


During the build process, I see:
cmds-fi-du.c: In function 'du_calc_file_space':
cmds-fi-du.c:330: error: 'FIEMAP_EXTENT_SHARED' undeclared (first use 
in this function)
cmds-fi-du.c:330: error: (Each undeclared identifier is reported only 
once

cmds-fi-du.c:330: error: for each function it appears in.)
make: *** [cmds-fi-du.o] Error 1

I'm guessing this is probably due to a different GCC version used? I'm 
guessing this is a simple fix for someone with knowhow... :)


Fair warning, the btrfs.ko in centos6 is positively ancient, and it
won't be updated.

Just in case that matters to you ... not sure if you just want to
build there, or use actually btrfs under a centos6 kernel


Thanks Eric,

Yeah - I understand the stock kernel is ancient in btrfs terms. I build 
4.4.x for Xen Dom0/U usage at my site: http://xen.crc.id.au and have 
done for several years. This is what I'm targeting with this.


--
Steven Haigh

Email: net...@crc.id.au
Web: https://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-progs 4.6 won't build on CentOS6

2016-06-23 Thread Qu Wenruo



At 06/24/2016 11:22 AM, Eric Sandeen wrote:

On 6/23/16 8:49 PM, Steven Haigh wrote:

I've tried to build the new tools for CentOS 6 / Scientific Linux 6 / RHEL 6 
etc.

During the build process, I see:
cmds-fi-du.c: In function 'du_calc_file_space':
cmds-fi-du.c:330: error: 'FIEMAP_EXTENT_SHARED' undeclared (first use in this 
function)
cmds-fi-du.c:330: error: (Each undeclared identifier is reported only once
cmds-fi-du.c:330: error: for each function it appears in.)
make: *** [cmds-fi-du.o] Error 1

I'm guessing this is probably due to a different GCC version used? I'm guessing 
this is a simple fix for someone with knowhow... :)


Fair warning, the btrfs.ko in centos6 is positively ancient, and it
won't be updated.

Just in case that matters to you ... not sure if you just want to
build there, or use actually btrfs under a centos6 kernel

-Eric


This is the new function introduced to calculate shared extents size for 
files/dirs.


Which uses EXTENT_SHARED flag for ioctl, which is not included in old 
kernels.


I have already informed the author several weeks ago, and the fix is 
quite easy.


But it seems that author didn't send out the fix though.

Thanks,
Qu


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html





--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-progs 4.6 won't build on CentOS6

2016-06-23 Thread Eric Sandeen
On 6/23/16 8:49 PM, Steven Haigh wrote:
> I've tried to build the new tools for CentOS 6 / Scientific Linux 6 / RHEL 6 
> etc.
> 
> During the build process, I see:
> cmds-fi-du.c: In function 'du_calc_file_space':
> cmds-fi-du.c:330: error: 'FIEMAP_EXTENT_SHARED' undeclared (first use in this 
> function)
> cmds-fi-du.c:330: error: (Each undeclared identifier is reported only once
> cmds-fi-du.c:330: error: for each function it appears in.)
> make: *** [cmds-fi-du.o] Error 1
> 
> I'm guessing this is probably due to a different GCC version used? I'm 
> guessing this is a simple fix for someone with knowhow... :)

Fair warning, the btrfs.ko in centos6 is positively ancient, and it
won't be updated.

Just in case that matters to you ... not sure if you just want to
build there, or use actually btrfs under a centos6 kernel

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: btrfs-progs 4.6 won't build on CentOS6

2016-06-23 Thread Jeff Mahoney
On 6/23/16 9:49 PM, Steven Haigh wrote:
> I've tried to build the new tools for CentOS 6 / Scientific Linux 6 /
> RHEL 6 etc.
> 
> During the build process, I see:
> cmds-fi-du.c: In function 'du_calc_file_space':
> cmds-fi-du.c:330: error: 'FIEMAP_EXTENT_SHARED' undeclared (first use in
> this function)
> cmds-fi-du.c:330: error: (Each undeclared identifier is reported only once
> cmds-fi-du.c:330: error: for each function it appears in.)
> make: *** [cmds-fi-du.o] Error 1
> 
> I'm guessing this is probably due to a different GCC version used? I'm
> guessing this is a simple fix for someone with knowhow... :)
> 

This is due to too-old headers.  That define was added in 2.6.33.

#define FIEMAP_EXTENT_SHARED0x2000 /* Space shared with other
* files. */

Just add that above that routine and you'll be good to go.  The right fix
is to add it to the tools, ofc.

-Jeff

-- 
Jeff Mahoney
SUSE Labs



signature.asc
Description: OpenPGP digital signature


btrfs-progs 4.6 won't build on CentOS6

2016-06-23 Thread Steven Haigh
I've tried to build the new tools for CentOS 6 / Scientific Linux 6 / 
RHEL 6 etc.


During the build process, I see:
cmds-fi-du.c: In function 'du_calc_file_space':
cmds-fi-du.c:330: error: 'FIEMAP_EXTENT_SHARED' undeclared (first use in 
this function)
cmds-fi-du.c:330: error: (Each undeclared identifier is reported only 
once

cmds-fi-du.c:330: error: for each function it appears in.)
make: *** [cmds-fi-du.o] Error 1

I'm guessing this is probably due to a different GCC version used? I'm 
guessing this is a simple fix for someone with knowhow... :)


--
Steven Haigh

Email: net...@crc.id.au
Web: https://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html