re: Btrfs: cleanup destroy_marked_extents

2013-05-09 Thread Dan Carpenter 
Hello Josef Bacik,

This is a semi-automatic email about new static checker warnings.

The patch fd8b2b611580: Btrfs: cleanup destroy_marked_extents from 
Apr 24, 2013, leads to the following Smatch complaint:

fs/btrfs/disk-io.c:3814 btrfs_destroy_marked_extents()
 warn: variable dereferenced before check 'eb' (see line 3813)

fs/btrfs/disk-io.c
  3812 root-leafsize);
  3813  start += eb-len;
 ^^^
New dereference.
  3814  if (!eb)
^^^
New check.  Maybe we should be adding root-leafsize here?  Just
the check earlier would cause a forever loop.

  3815  continue;
  3816  wait_on_extent_buffer_writeback(eb);

regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Btrfs: cleanup destroy_marked_extents

2013-05-09 Thread Josef Bacik 
On Thu, May 09, 2013 at 06:22:06AM -0600, Dan Carpenter wrote:
 Hello Josef Bacik,
 
 This is a semi-automatic email about new static checker warnings.
 
 The patch fd8b2b611580: Btrfs: cleanup destroy_marked_extents from 
 Apr 24, 2013, leads to the following Smatch complaint:
 
 fs/btrfs/disk-io.c:3814 btrfs_destroy_marked_extents()
warn: variable dereferenced before check 'eb' (see line 3813)
 
 fs/btrfs/disk-io.c
   3812   
 root-leafsize);
   3813start += eb-len;
  ^^^
 New dereference.
   3814if (!eb)
 ^^^
 New check.  Maybe we should be adding root-leafsize here?  Just
 the check earlier would cause a forever loop.
 
   3815continue;
   3816wait_on_extent_buffer_writeback(eb);
 

Yeah I sent a patch for it yesterday, just me being an idiot, nothing to see
here,

Josef
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html