Re: Bug in geode-aes.c ?
* Sergey Mironov | 2009-11-10 17:00:31 [+0300]:
116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
117 unsigned int len)
118 {
...
/** BUG? Should it be 'op-fallback.cip' instead of 'op-fallback.blk' ? **/
138 op-fallback.blk-base.crt_flags = ~CRYPTO_TFM_REQ_MASK;
139 op-fallback.blk-base.crt_flags |= (tfm-crt_flags
CRYPTO_TFM_REQ_MASK);
...
144 tfm-crt_flags |=
(op-fallback.blk-base.crt_flags CRYPTO_TFM_RES_MASK);
145 }
146 return ret;
Yup, good catch. It has to be cip instead of blk. I've copy/pasted it
and the same bug is in s390's crypto driver. No one noticed it because
both structs are equal, just the name / type is different.
Do you mind sending a patch?
Sebastian
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] crypto: testmgr: fix warning
On Mon, Oct 19, 2009 at 4:03 PM, Jarod Wilson ja...@redhat.com wrote: So yeah, I rescind my claim that initializing err to 0 is incorrect, I think that's just fine. So is this acked? Who will merge it? -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] crypto: testmgr: fix warning
On Thu, Nov 12, 2009 at 02:32:10AM +0200, Felipe Contreras wrote:
On Mon, Oct 19, 2009 at 4:03 PM, Jarod Wilson ja...@redhat.com wrote:
So yeah, I rescind my claim that initializing err to 0 is incorrect, I think
that's just fine.
So is this acked? Who will merge it?
It's already in cryptodev-2.6:
commit fa4ef8a6af4745bbf3a25789bc7d4f14a3a6d803
Author: Felipe Contreras felipe.contre...@gmail.com
Date: Tue Oct 27 19:04:42 2009 +0800
crypto: testmgr - Fix warning
crypto/testmgr.c: In function ‘test_cprng’:
crypto/testmgr.c:1204: warning: ‘err’ may be used uninitialized in this
function
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
