Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Hi Dmitry, On Mon, 21 Nov 2011 17:32:54 +0200 "Kasatkin, Dmitry" wrote: > > In fact it does not break bisect, because compilation is enabled in > the 3rd patch. Ah. sorry, I missed that. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgp4yIPO6WWQb.pgp Description: PGP signature
Re: [PATCH -next] digsig: fix build errors
On 11/21/2011 02:32 AM, Kasatkin, Dmitry wrote: > On Mon, Nov 21, 2011 at 8:12 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build errors by adding kconfig dependency on KEYS: >> >> lib/digsig.c:106:16: error: dereferencing pointer to incomplete type >> lib/digsig.c:107:11: error: dereferencing pointer to incomplete type >> lib/digsig.c:184:14: error: dereferencing pointer to incomplete type >> lib/digsig.c:223:3: error: 'key_ref_t' undeclared (first use in this >> function) >> lib/digsig.c:223:13: error: expected ';' before 'kref' >> lib/digsig.c:224:3: error: 'kref' undeclared (first use in this function) >> lib/digsig.c:224:3: error: implicit declaration of function 'keyring_search' >> lib/digsig.c:231:3: error: implicit declaration of function 'request_key' >> >> and after changing lib/Kconfig: >> warning: (INTEGRITY_DIGSIG) selects DIGSIG which has unmet direct >> dependencies (CRYPTO && KEYS) >> >> Signed-off-by: Randy Dunlap >> Cc: Dmitry Kasatkin >> --- >> lib/Kconfig|4 ++-- >> security/integrity/Kconfig |2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> --- next-2011-1121.orig/lib/Kconfig >> +++ next-2011-1121/lib/Kconfig >> @@ -294,10 +294,10 @@ config MPILIB_EXTRA >> >> config DIGSIG >>tristate "In-kernel signature checker" >> - depends on CRYPTO >> + depends on CRYPTO && KEYS > > this patch was in /crypto dir before, now it is in /lib... > I think CRYPTO is not needed at all at the moment.. > > >>select MPILIB >>help >> Digital signature verification. Currently only RSA is supported. >> - Implementation is done using GnuPG MPI library >> + Implementation is done using GnuPG MPI library. >> >> endmenu >> --- next-2011-1121.orig/security/integrity/Kconfig >> +++ next-2011-1121/security/integrity/Kconfig >> @@ -5,7 +5,7 @@ config INTEGRITY >> >> config INTEGRITY_DIGSIG >>boolean "Digital signature verification using multiple keyrings" >> - depends on INTEGRITY >> + depends on INTEGRITY && CRYPTO && KEYS > > Is it really needed, because 2 lines bellow is "select DIGSIG", which > will depend on KEYS?? Feel free to fix the build errors any way that you want to do it, but please get them fixed. Don't leave it as is. > >>default n >>select DIGSIG >>help >> > > Thanks! -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Mon, Nov 21, 2011 at 1:27 PM, James Morris wrote: > On Mon, 21 Nov 2011, Kasatkin, Dmitry wrote: > >> It can be easily split into 2 commits and one of them would not comply >> with mailing list limits. >> >> James, should I do anything about it? > > No, it's in my public tree now. > Ok. In fact it does not break bisect, because compilation is enabled in the 3rd patch. BR, Dmitry > > - James > -- > James Morris > > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Mon, 21 Nov 2011, Kasatkin, Dmitry wrote: > It can be easily split into 2 commits and one of them would not comply > with mailing list limits. > > James, should I do anything about it? No, it's in my public tree now. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] digsig: fix build errors
On Mon, Nov 21, 2011 at 8:12 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors by adding kconfig dependency on KEYS: > > lib/digsig.c:106:16: error: dereferencing pointer to incomplete type > lib/digsig.c:107:11: error: dereferencing pointer to incomplete type > lib/digsig.c:184:14: error: dereferencing pointer to incomplete type > lib/digsig.c:223:3: error: 'key_ref_t' undeclared (first use in this function) > lib/digsig.c:223:13: error: expected ';' before 'kref' > lib/digsig.c:224:3: error: 'kref' undeclared (first use in this function) > lib/digsig.c:224:3: error: implicit declaration of function 'keyring_search' > lib/digsig.c:231:3: error: implicit declaration of function 'request_key' > > and after changing lib/Kconfig: > warning: (INTEGRITY_DIGSIG) selects DIGSIG which has unmet direct > dependencies (CRYPTO && KEYS) > > Signed-off-by: Randy Dunlap > Cc: Dmitry Kasatkin > --- > lib/Kconfig | 4 ++-- > security/integrity/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > --- next-2011-1121.orig/lib/Kconfig > +++ next-2011-1121/lib/Kconfig > @@ -294,10 +294,10 @@ config MPILIB_EXTRA > > config DIGSIG > tristate "In-kernel signature checker" > - depends on CRYPTO > + depends on CRYPTO && KEYS this patch was in /crypto dir before, now it is in /lib... I think CRYPTO is not needed at all at the moment.. > select MPILIB > help > Digital signature verification. Currently only RSA is supported. > - Implementation is done using GnuPG MPI library > + Implementation is done using GnuPG MPI library. > > endmenu > --- next-2011-1121.orig/security/integrity/Kconfig > +++ next-2011-1121/security/integrity/Kconfig > @@ -5,7 +5,7 @@ config INTEGRITY > > config INTEGRITY_DIGSIG > boolean "Digital signature verification using multiple keyrings" > - depends on INTEGRITY > + depends on INTEGRITY && CRYPTO && KEYS Is it really needed, because 2 lines bellow is "select DIGSIG", which will depend on KEYS?? > default n > select DIGSIG > help > Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Sat, Nov 19, 2011 at 5:33 AM, Stephen Rothwell wrote: > Hi all, > > On Wed, 19 Oct 2011 14:51:30 +0300 Dmitry Kasatkin > wrote: >> >> Adds the multi-precision-integer maths library which was originally taken >> from GnuPG and ported to the kernel by (among others) David Howells. >> This version is taken from Fedora kernel 2.6.32-71.14.1.el6. >> The difference is that checkpatch reported errors and warnings have been >> fixed. >> >> This library is used to implemenet RSA digital signature verification >> used in IMA/EVM integrity protection subsystem. >> >> Due to patch size limitation, the patch is divided into 4 parts. > > I just noticed that this has been added to the "next" branch of the > security tree (and thus into the next release of linux-next). I think > that these patches should be rearranged as in their current form, they > break bisection (since the files in this patch reference include files in > a latter patch). We generally prefer large patches to be broken up into > logical sub patches rather than just along file boundaries. > > In this case, even though it was broken up for review, it could have been > committed as one large commit (assuming that there is no sensible way to > break it up). Hi, It can be easily split into 2 commits and one of them would not comply with mailing list limits. James, should I do anything about it? Thanks, - Dmitry > -- > Cheers, > Stephen Rothwell s...@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] crypto: talitos - add hmac algorithms
On Thu, Nov 17, 2011 at 12:19:16AM +, Kim Phillips wrote: > From: Lee Nipper > > Add these hmac algorithms to talitos: All patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] crypto: mv_cesa - fix hashing of chunks > 1920 bytes
On Wed, Nov 16, 2011 at 06:28:01PM +0100, Phil Sutter wrote: > This was broken by commit 7759995c75ae0cbd4c861582908449f6b6208e7a (yes, > myself). The basic problem here is since the digest state is only saved > after the last chunk, the state array is only valid when handling the > first chunk of the next buffer. Broken since linux-3.0. > > Signed-off-by: Phil Sutter > Cc: # 3.1.x Patch applied. Thanks Phil. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] [v2] crypto: serpent - add 8-way parallel x86_64/SSE2 assembler implementation
On Wed, Nov 09, 2011 at 04:26:25PM +0200, Jussi Kivilinna wrote: > Patch adds x86_64/SSE2 assembler implementation of serpent cipher. Assembler > functions crypt data in eigth block chunks (two 4 block chunk SSE2 operations > in parallel to improve performance on out-of-order CPUs). Glue code is based > on one from AES-NI implementation, so requests from irq context are redirected > to cryptd. All five patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
