Re: Tcrypt hmac(crc32) test can work only on Blackfin
On Thu, Nov 22, 2012 at 03:38:45AM -0500, Zhang, Sonic wrote: On Wed, Nov 21, 2012 at 01:01:49PM +0100, Milan Broz wrote: On 11/21/2012 12:29 PM, Zhang, Sonic wrote: Is there a policy that the CRC test vector in testmgr.h should support all CRC drivers? If so, I am fine to drop this test vector. Question for Herbert... But the problem I see is that it confuses people, it simply returns fail everytime (except Blackfin platform). My mail originates from bug report tcrypt tests started failing, and it was not obvious why (for people not familiar with tcrypt internals, they just tried all test modes available). We should just make a generic version of crc32 available. Hi Herbert and Broz, Unfortunately, after investigating the hardware manual of Blackfin CRC engine and the CRC algorithm, I have to say the Blackfin CRC driver can't use current crc32c test vector in testmgr.h. Blackfin CRC engine only supports big endian CRC algorithm, while current crypto crc32c driver uses little endian CRC algorithm. The big endian CRC digest is different from that of the little endian. There are 2 solutions. One is to add a big endian crc32c test vector. The other is to keep the Blackfin specific test vector. However, neither meets Broz's expectation of a generic crc32 test vector. Any idea? I think we should just remove the blackfin crc driver altogether as nothing in the kernel ever uses hmac(crc32). Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: cast5/cast6 - move lookup tables to shared module
On Tue, Nov 13, 2012 at 02:52:46PM -0500, David Miller wrote: From: Jussi Kivilinna jussi.kivili...@mbnet.fi Date: Tue, 13 Nov 2012 21:50:20 +0200 Quoting David Miller da...@davemloft.net: From: Jussi Kivilinna jussi.kivili...@mbnet.fi Date: Tue, 13 Nov 2012 11:43:14 +0200 CAST5 and CAST6 both use same lookup tables, which can be moved shared module 'cast_common'. Signed-off-by: Jussi Kivilinna jussi.kivili...@mbnet.fi Does this work if you make CAST5 modular and CAST6 static, or vice versa? Yes, dependencies force common module to be built-in/static in both cases and will be build as module only if both cast5 and cast6 are also. Fair enough: Acked-by: David S. Miller da...@davemloft.net Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] crypto: testmgr - clean alg_test_null entries in alg_test_descs[]
On Tue, Nov 13, 2012 at 01:53:45PM -0500, David Miller wrote: From: Jussi Kivilinna jussi.kivili...@mbnet.fi Date: Tue, 13 Nov 2012 11:47:37 +0200 Currently alg_test_null entries set .suite values to zero, which is unneeded. So perform clean-up of null test entries. Signed-off-by: Jussi Kivilinna jussi.kivili...@mbnet.fi Acked-by: David S. Miller da...@davemloft.net Both patches applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: testmgr - add larger crc32c test vector to test FPU path in crc32c_intel
On Tue, Nov 13, 2012 at 01:54:32PM -0500, David Miller wrote: From: Jussi Kivilinna jussi.kivili...@mbnet.fi Date: Tue, 13 Nov 2012 12:02:30 +0200 Signed-off-by: Jussi Kivilinna jussi.kivili...@mbnet.fi Acked-by: David S. Miller da...@davemloft.net Also applied. Thanks. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2] crypto: caam - Updated SEC-4.0 device tree binding for ERA information.
On Sat, Dec 01, 2012 at 03:16:54AM +, Vakul Garg wrote: The compatible property in device tree crypto node has been enhanced to provide SEC ERA information to the applications. Signed-off-by: Vakul Garg va...@freescale.com Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
