Re: [PATCH 0/3] crypto: x86/sha1 - regression and other fixes
On 24 March 2014 18:29, chandramouli narayanan wrote: > On Mon, 2014-03-24 at 17:10 +0100, Mathias Krause wrote: >> The recent addition of the AVX2 variant of the SHA1 hash function wrongly >> disabled the AVX variant by introducing a flaw in the feature test. Fixed >> in patch 1. >> >> The alignment calculations of the AVX2 assembler implementation are >> questionable, too. Especially the page alignment of the stack pointer is >> broken in multiple ways. Fixed in patch 2. In patch 3 another issue for >> code alignment is fixed. >> >> Please apply! >> >> Mathias Krause (3): >> crypto: x86/sha1 - re-enable the AVX variant >> crypto: x86/sha1 - fix stack alignment of AVX2 variant >> crypto: x86/sha1 - reduce size of the AVX2 asm implementation >> >> arch/x86/crypto/sha1_avx2_x86_64_asm.S |8 ++-- >> arch/x86/crypto/sha1_ssse3_glue.c | 26 -- >> 2 files changed, 18 insertions(+), 16 deletions(-) >> > Your fixes are the right on mark. I went through your patches and tested > them and found to be correct. Thanks for double-checking! > Sorry for causing regression and missing alignment issues in the patches > I submitted. No problem with that. But as I'm not subscribed to the linux-crypto mailing list I haven't seen your earlier submissions. Otherwise I would have objected earlier. ;) Thanks, Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] crypto: x86/sha1 - regression and other fixes
On Mon, Mar 24, 2014 at 09:19:44PM +0100, Marek Vasut wrote: > On Monday, March 24, 2014 at 05:10:36 PM, Mathias Krause wrote: > > The recent addition of the AVX2 variant of the SHA1 hash function wrongly > > disabled the AVX variant by introducing a flaw in the feature test. Fixed > > in patch 1. > > > > The alignment calculations of the AVX2 assembler implementation are > > questionable, too. Especially the page alignment of the stack pointer is > > broken in multiple ways. Fixed in patch 2. In patch 3 another issue for > > code alignment is fixed. > > > > Please apply! > > Nice, > > Reviewed-by: Marek Vasut All applied. Thanks Mathias! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix late crypto work queue initialization
On Fri, 2014-03-21 at 22:40 +0800, Herbert Xu wrote: > On Mon, Mar 17, 2014 at 04:52:26PM -0700, Tim Chen wrote: > > The crypto algorithm modules utilizing the crypto daemon could > > be used early when the system start up. Using module_init > > does not guarantee that the daemon's work queue is initialized > > when the cypto alorithm depending on crypto_wq starts. It is necessary > > to initialize the crypto work queue earlier at the subsystem > > init time to make sure that it is initialized > > when used. > > > > Signed-off-by: Tim Chen > > Patch applied. Herbert, Probably this patch should go to the stable patches as well. Copying Greg. Thanks. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix late crypto work queue initialization
On Tue, Mar 25, 2014 at 04:40:56PM -0700, Tim Chen wrote: > On Fri, 2014-03-21 at 22:40 +0800, Herbert Xu wrote: > > On Mon, Mar 17, 2014 at 04:52:26PM -0700, Tim Chen wrote: > > > The crypto algorithm modules utilizing the crypto daemon could > > > be used early when the system start up. Using module_init > > > does not guarantee that the daemon's work queue is initialized > > > when the cypto alorithm depending on crypto_wq starts. It is necessary > > > to initialize the crypto work queue earlier at the subsystem > > > init time to make sure that it is initialized > > > when used. > > > > > > Signed-off-by: Tim Chen > > > > Patch applied. > > Herbert, > > Probably this patch should go to the stable patches as well. > Copying Greg. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
