Re: [PATCH] Add select of CONFIG_SRCU by CONFIG_CRYPTO

2015-10-22 Thread Andrej Krutak
On Thursday 22 of October 2015 23:35:07 Herbert Xu wrote:
> Andrej Krutak  wrote:
> > Signed-off-by: Andrej Krutak 
> 
> You are supposed to describe the patch here, e.g., the reason
> why we need this patch.
> 


I'm sorry, please ignore this patch (it's for v4.1 with rt patches).

-- 
Best regards | S pozdravom | Mit freundlichen Grüßen | Cordialement

Andrej Krutak
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/8] crypto: ccp: Use precalculated hash from headers

2015-10-22 Thread Tom Lendacky

On 10/20/2015 02:33 AM, LABBE Corentin wrote:

Precalculated hash for empty message are now present in hash headers.
This patch just use them.

Signed-off-by: LABBE Corentin 


Tested-by: Tom Lendacky 
Acked-by: Tom Lendacky 


---
  drivers/crypto/ccp/ccp-ops.c | 39 ---
  1 file changed, 8 insertions(+), 31 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index d09c6c4..64fac2b 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -152,32 +152,6 @@ static const __be32 ccp_sha256_init[CCP_SHA_CTXSIZE / 
sizeof(__be32)] = {
cpu_to_be32(SHA256_H6), cpu_to_be32(SHA256_H7),
  };

-/* The CCP cannot perform zero-length sha operations so the caller
- * is required to buffer data for the final operation.  However, a
- * sha operation for a message with a total length of zero is valid
- * so known values are required to supply the result.
- */
-static const u8 ccp_sha1_zero[CCP_SHA_CTXSIZE] = {
-   0xda, 0x39, 0xa3, 0xee, 0x5e, 0x6b, 0x4b, 0x0d,
-   0x32, 0x55, 0xbf, 0xef, 0x95, 0x60, 0x18, 0x90,
-   0xaf, 0xd8, 0x07, 0x09, 0x00, 0x00, 0x00, 0x00,
-   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-};
-
-static const u8 ccp_sha224_zero[CCP_SHA_CTXSIZE] = {
-   0xd1, 0x4a, 0x02, 0x8c, 0x2a, 0x3a, 0x2b, 0xc9,
-   0x47, 0x61, 0x02, 0xbb, 0x28, 0x82, 0x34, 0xc4,
-   0x15, 0xa2, 0xb0, 0x1f, 0x82, 0x8e, 0xa6, 0x2a,
-   0xc5, 0xb3, 0xe4, 0x2f, 0x00, 0x00, 0x00, 0x00,
-};
-
-static const u8 ccp_sha256_zero[CCP_SHA_CTXSIZE] = {
-   0xe3, 0xb0, 0xc4, 0x42, 0x98, 0xfc, 0x1c, 0x14,
-   0x9a, 0xfb, 0xf4, 0xc8, 0x99, 0x6f, 0xb9, 0x24,
-   0x27, 0xae, 0x41, 0xe4, 0x64, 0x9b, 0x93, 0x4c,
-   0xa4, 0x95, 0x99, 0x1b, 0x78, 0x52, 0xb8, 0x55,
-};
-
  static u32 ccp_addr_lo(struct ccp_dma_info *info)
  {
return lower_32_bits(info->address + info->offset);
@@ -1388,18 +1362,21 @@ static int ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, 
struct ccp_cmd *cmd)
if (sha->msg_bits)
return -EINVAL;

-   /* A sha operation for a message with a total length of zero,
-* return known result.
+   /* The CCP cannot perform zero-length sha operations so the
+* caller is required to buffer data for the final operation.
+* However, a sha operation for a message with a total length
+* of zero is valid so known values are required to supply
+* the result.
 */
switch (sha->type) {
case CCP_SHA_TYPE_1:
-   sha_zero = ccp_sha1_zero;
+   sha_zero = sha1_zero_message_hash;
break;
case CCP_SHA_TYPE_224:
-   sha_zero = ccp_sha224_zero;
+   sha_zero = sha224_zero_message_hash;
break;
case CCP_SHA_TYPE_256:
-   sha_zero = ccp_sha256_zero;
+   sha_zero = sha256_zero_message_hash;
break;
default:
return -EINVAL;


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Add select of CONFIG_SRCU by CONFIG_CRYPTO

2015-10-22 Thread Herbert Xu
Andrej Krutak  wrote:
> Signed-off-by: Andrej Krutak 

You are supposed to describe the patch here, e.g., the reason
why we need this patch.

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] crypto: qat - remove superfluous check from adf_probe

2015-10-22 Thread Salvatore Benedetto
 - ent->device is already checked at the beginning of the function
   against the same value. This check is a duplicate.

Signed-off-by: Salvatore Benedetto 
---
 drivers/crypto/qat/qat_dh895xcc/adf_drv.c   | 8 +---
 drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 +
 2 files changed, 2 insertions(+), 15 deletions(-)

diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c 
b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index f8dd14f..f933f7d 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -253,13 +253,7 @@ static int adf_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
}
 
accel_dev->hw_device = hw_data;
-   switch (ent->device) {
-   case ADF_DH895XCC_PCI_DEVICE_ID:
-   adf_init_hw_data_dh895xcc(accel_dev->hw_device);
-   break;
-   default:
-   return -ENODEV;
-   }
+   adf_init_hw_data_dh895xcc(accel_dev->hw_device);
pci_read_config_byte(pdev, PCI_REVISION_ID, &accel_pci_dev->revid);
pci_read_config_dword(pdev, ADF_DH895XCC_FUSECTL_OFFSET,
  &hw_data->fuses);
diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c 
b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 789426f..7bec249 100644
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -243,14 +243,7 @@ static int adf_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
goto out_err;
}
accel_dev->hw_device = hw_data;
-   switch (ent->device) {
-   case ADF_DH895XCCIOV_PCI_DEVICE_ID:
-   adf_init_hw_data_dh895xcciov(accel_dev->hw_device);
-   break;
-   default:
-   ret = -ENODEV;
-   goto out_err;
-   }
+   adf_init_hw_data_dh895xcciov(accel_dev->hw_device);
 
/* Get Accelerators and Accelerators Engines masks */
hw_data->accel_mask = hw_data->get_accel_mask(hw_data->fuses);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] crypto: qat - fix get instance function

2015-10-22 Thread Tadeusz Struk
Fix the logic in case we have found a device on a given node.

Signed-off-by: Tadeusz Struk 
---
 drivers/crypto/qat/qat_common/qat_crypto.c |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_crypto.c 
b/drivers/crypto/qat/qat_common/qat_crypto.c
index 603c12d..4d0c65b 100644
--- a/drivers/crypto/qat/qat_common/qat_crypto.c
+++ b/drivers/crypto/qat/qat_common/qat_crypto.c
@@ -119,19 +119,19 @@ struct qat_crypto_instance 
*qat_crypto_get_instance_node(int node)
}
}
}
-   if (!accel_dev)
-   pr_info("QAT: Could not find a device on node %d\n", node);
-
-   /* Get any started device */
-   list_for_each(itr, adf_devmgr_get_head()) {
-   struct adf_accel_dev *tmp_dev;
 
-   tmp_dev = list_entry(itr, struct adf_accel_dev, list);
+   if (!accel_dev) {
+   pr_info("QAT: Could not find a device on node %d\n", node);
+   /* Get any started device */
+   list_for_each(itr, adf_devmgr_get_head()) {
+   struct adf_accel_dev *tmp_dev;
 
-   if (adf_dev_started(tmp_dev) &&
-   !list_empty(&tmp_dev->crypto_list)) {
-   accel_dev = tmp_dev;
-   break;
+   tmp_dev = list_entry(itr, struct adf_accel_dev, list);
+   if (adf_dev_started(tmp_dev) &&
+   !list_empty(&tmp_dev->crypto_list)) {
+   accel_dev = tmp_dev;
+   break;
+   }
}
}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] Add select of CONFIG_SRCU by CONFIG_CRYPTO

2015-10-22 Thread Andrej Krutak
Signed-off-by: Andrej Krutak 

---
 crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 48ee3e1..c7596ee 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -14,6 +14,7 @@ source "crypto/async_tx/Kconfig"
 #
 menuconfig CRYPTO
tristate "Cryptographic API"
+   select SRCU
help
  This option provides the core Cryptographic API.
 
-- 
1.9.1

-- 
Best regards | S pozdravom | Mit freundlichen Grüßen | Cordialement

Andrej Krutak
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html