Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code
Hello Arnd, On 01/02/2017 02:10 PM, Arnd Bergmann wrote: > On Monday, January 2, 2017 2:06:56 PM CET Javier Martinez Canillas wrote: >> >> This small series contains a couple of cleanups that removes some driver's >> code >> that isn't needed due the driver being for a DT-only platform. >> >> The changes were suggested by Arnd Bergmann as a response to a previous >> patch: >> https://lkml.org/lkml/2017/1/2/342 >> >> Patch #1 allows the driver to be built when the COMPILE_TEST option is >> enabled. >> Patch #2 removes the platform ID table since isn't needed for DT-only >> drivers. >> Patch #3 removes a wrapper function that's also not needed if driver is >> DT-only. >> >> > > Looks good, but I don't know if the first patch causes some build warnings Thanks for looking at the patches. > on non-ARM platforms, better wait at least for the 0-day build results, > and maybe build-test on x86-32 and x86-64. > I should had mentioned that I built tested for arm, arm64, x86-32 and x86-64, and saw now issues. But I agree with you that it's better to wait for the 0-day builder in case it reports issues on some platforms. > Arnd > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] crypto: picoxcell - Allow driver to build COMPILE_TEST is enabled
Driver only has runtime but no build time dependency with ARCH_PICOXCELL. So it can be built for testing purposes if COMPILE_TEST option is enabled. This is useful to have more build coverage and make sure that the driver is not affected by changes that could cause build regressions. Suggested-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 79564785ae30..35b1c4829696 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -339,7 +339,7 @@ config CRYPTO_DEV_OMAP_DES config CRYPTO_DEV_PICOXCELL tristate "Support for picoXcell IPSEC and Layer2 crypto engines" - depends on ARCH_PICOXCELL && HAVE_CLK + depends on (ARCH_PICOXCELL || COMPILE_TEST) && HAVE_CLK select CRYPTO_AEAD select CRYPTO_AES select CRYPTO_AUTHENC -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] crypto: picoxcell - Remove spacc_is_compatible() wrapper function
The function is used to check either the platform device ID name or the OF
node's compatible (depending how the device was registered) to know which
device type was registered.
But the driver is for a DT-only platform and so there's no need for this
level of indirection since the devices can only be registered via OF.
Suggested-by: Arnd Bergmann <a...@arndb.de>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/crypto/picoxcell_crypto.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/crypto/picoxcell_crypto.c
b/drivers/crypto/picoxcell_crypto.c
index 539effbbfc7a..b6f14844702e 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -1616,32 +1616,17 @@ static const struct of_device_id spacc_of_id_table[] = {
MODULE_DEVICE_TABLE(of, spacc_of_id_table);
#endif /* CONFIG_OF */
-static bool spacc_is_compatible(struct platform_device *pdev,
- const char *spacc_type)
-{
- const struct platform_device_id *platid = platform_get_device_id(pdev);
-
- if (platid && !strcmp(platid->name, spacc_type))
- return true;
-
-#ifdef CONFIG_OF
- if (of_device_is_compatible(pdev->dev.of_node, spacc_type))
- return true;
-#endif /* CONFIG_OF */
-
- return false;
-}
-
static int spacc_probe(struct platform_device *pdev)
{
int i, err, ret = -EINVAL;
struct resource *mem, *irq;
+ struct device_node *np = pdev->dev.of_node;
struct spacc_engine *engine = devm_kzalloc(>dev, sizeof(*engine),
GFP_KERNEL);
if (!engine)
return -ENOMEM;
- if (spacc_is_compatible(pdev, "picochip,spacc-ipsec")) {
+ if (of_device_is_compatible(np, "picochip,spacc-ipsec")) {
engine->max_ctxs= SPACC_CRYPTO_IPSEC_MAX_CTXS;
engine->cipher_pg_sz= SPACC_CRYPTO_IPSEC_CIPHER_PG_SZ;
engine->hash_pg_sz = SPACC_CRYPTO_IPSEC_HASH_PG_SZ;
@@ -1650,7 +1635,7 @@ static int spacc_probe(struct platform_device *pdev)
engine->num_algs= ARRAY_SIZE(ipsec_engine_algs);
engine->aeads = ipsec_engine_aeads;
engine->num_aeads = ARRAY_SIZE(ipsec_engine_aeads);
- } else if (spacc_is_compatible(pdev, "picochip,spacc-l2")) {
+ } else if (of_device_is_compatible(np, "picochip,spacc-l2")) {
engine->max_ctxs= SPACC_CRYPTO_L2_MAX_CTXS;
engine->cipher_pg_sz= SPACC_CRYPTO_L2_CIPHER_PG_SZ;
engine->hash_pg_sz = SPACC_CRYPTO_L2_HASH_PG_SZ;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code
Hello, This small series contains a couple of cleanups that removes some driver's code that isn't needed due the driver being for a DT-only platform. The changes were suggested by Arnd Bergmann as a response to a previous patch: https://lkml.org/lkml/2017/1/2/342 Patch #1 allows the driver to be built when the COMPILE_TEST option is enabled. Patch #2 removes the platform ID table since isn't needed for DT-only drivers. Patch #3 removes a wrapper function that's also not needed if driver is DT-only. Best regards, Javier Martinez Canillas (3): crypto: picoxcell - Allow driver to build COMPILE_TEST is enabled crypto: picoxcell - Remove platform device ID table crypto: picoxcell - Remove spacc_is_compatible() wrapper function drivers/crypto/Kconfig| 2 +- drivers/crypto/picoxcell_crypto.c | 28 +++- 2 files changed, 4 insertions(+), 26 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] crypto: picoxcell - Remove platform device ID table
This driver is only used in the picoxcell platform and this is DT-only.
So only a OF device ID table is needed and there's no need to have a
platform device ID table. This patch removes the unneeded table.
Suggested-by: Arnd Bergmann <a...@arndb.de>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/crypto/picoxcell_crypto.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/crypto/picoxcell_crypto.c
b/drivers/crypto/picoxcell_crypto.c
index 47576098831f..539effbbfc7a 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -1803,12 +1803,6 @@ static int spacc_remove(struct platform_device *pdev)
return 0;
}
-static const struct platform_device_id spacc_id_table[] = {
- { "picochip,spacc-ipsec", },
- { "picochip,spacc-l2", },
- { }
-};
-
static struct platform_driver spacc_driver = {
.probe = spacc_probe,
.remove = spacc_remove,
@@ -1819,7 +1813,6 @@ static struct platform_driver spacc_driver = {
#endif /* CONFIG_PM */
.of_match_table = of_match_ptr(spacc_of_id_table),
},
- .id_table = spacc_id_table,
};
module_platform_driver(spacc_driver);
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration
On 01/02/2017 01:24 PM, Arnd Bergmann wrote: > On Monday, January 2, 2017 1:13:24 PM CET Javier Martinez Canillas wrote: >> Hello Arnd, >> >> On 01/02/2017 01:05 PM, Arnd Bergmann wrote: >>> On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote: >>>> If the driver is built as a module, autoload won't work because the module >>>> alias information is not filled. So user-space can't match the registered >>>> device with the corresponding module if the device isn't registered via OF. >>>> >>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >>> >>> I think we can just remove the table, as the platform only supports >>> booting through DT anyway. >>> >> >> Agreed. I should had checked if mach-picoxcell was DT-only indeed. >> >> Should I also make the driver to depend on OF and remove the #ifdefery then? > > I don't think we need a dependency, the #ifdef checks in there were needed > only to make the driver smaller if OF is disabled and it should still build > fine if someone tries to compile it for CONFIG_COMPILE_TEST without > CONFIG_OF. > OK, the driver doesn't depend on COMPILE_TEST though but I agree with you since it seems the driver only has runtime but no build time dependencies with ARCH_PICOXCELL. > If we remove the platform ID, we can however also remove the > spacc_is_compatible() function and just call of_device_is_compatible() > in its place. > Yes. > Arnd > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration
Hello Arnd, On 01/02/2017 01:05 PM, Arnd Bergmann wrote: > On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote: >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module if the device isn't registered via OF. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > I think we can just remove the table, as the platform only supports > booting through DT anyway. > Agreed. I should had checked if mach-picoxcell was DT-only indeed. Should I also make the driver to depend on OF and remove the #ifdefery then? > Arnd > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] crypto: picoxcell - Fix module autoload for non-OF registration
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module if the device isn't registered via OF.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/crypto/picoxcell_crypto.ko | grep alias
alias: of:N*T*Cpicochip,spacc-l2C*
alias: of:N*T*Cpicochip,spacc-l2
alias: of:N*T*Cpicochip,spacc-ipsecC*
alias: of:N*T*Cpicochip,spacc-ipsec
After this patch:
$ modinfo drivers/crypto/picoxcell_crypto.ko | grep alias
alias: of:N*T*Cpicochip,spacc-l2C*
alias: of:N*T*Cpicochip,spacc-l2
alias: of:N*T*Cpicochip,spacc-ipsecC*
alias: of:N*T*Cpicochip,spacc-ipsec
alias: platform:picochip,spacc-l2
alias: platform:picochip,spacc-ipsec
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/crypto/picoxcell_crypto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/picoxcell_crypto.c
b/drivers/crypto/picoxcell_crypto.c
index 47576098831f..64449b7c00af 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -1808,6 +1808,7 @@ static const struct platform_device_id spacc_id_table[] =
{
{ "picochip,spacc-l2", },
{ }
};
+MODULE_DEVICE_TABLE(platform, spacc_id_table);
static struct platform_driver spacc_driver = {
.probe = spacc_probe,
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS
The Amlogic Meson is a DT-only platform, which means the devices are
registered via OF and not using the legacy platform devices support.
So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
the reported uevent MODALIAS to user-space will always be the OF one.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/char/hw_random/meson-rng.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/meson-rng.c
b/drivers/char/hw_random/meson-rng.c
index 51864a509be7..119d698439ae 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = {
module_platform_driver(meson_rng_driver);
-MODULE_ALIAS("platform:meson-rng");
MODULE_DESCRIPTION("Meson H/W Random Number Generator driver");
MODULE_AUTHOR("Lawrence Mok <lawrence@amlogic.com>");
MODULE_AUTHOR("Neil Armstrong <narmstr...@baylibre.com>");
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
Hello Fabio, On 10/17/2016 04:45 PM, Fabio Estevam wrote: > On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: > >> --- a/drivers/char/tpm/Kconfig >> +++ b/drivers/char/tpm/Kconfig >> @@ -32,7 +32,7 @@ config TCG_TIS_CORE >> >> config TCG_TIS >> tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO >> Interface" >> - depends on X86 >> + depends on X86 || COMPILE_TEST > > This is a separate change. > Yes, I did a commit by mistake. Sorry about that. Jason already pointed out and I posted a v2. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] hwrng: meson: Fix module autoload for OF registration
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
After this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
alias: of:N*T*Camlogic,meson-rngC*
alias: of:N*T*Camlogic,meson-rng
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Changes in v2:
- Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe.
drivers/char/hw_random/meson-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/meson-rng.c
b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
{ .compatible = "amlogic,meson-rng", },
{},
};
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
static struct platform_driver meson_rng_driver = {
.probe = meson_rng_probe,
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
Hello Jason, On 10/17/2016 04:45 PM, Jason Gunthorpe wrote: > On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote: > >> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> >> >> drivers/char/hw_random/meson-rng.c | 1 + >> drivers/char/tpm/Kconfig | 2 +- > > Looks like this patch should not have tpm in it. > Argh, yes. I had some unrelated changes in my staging area and did a commit by mistake. Thanks a lot for pointing out and sorry for that. I'll post a v2 without this. > Jason > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] hwrng: meson: Fix module autoload for OF registration
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
After this patch:
$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias: platform:meson-rng
alias: of:N*T*Camlogic,meson-rngC*
alias: of:N*T*Camlogic,meson-rng
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/char/hw_random/meson-rng.c | 1 +
drivers/char/tpm/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/meson-rng.c
b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
{ .compatible = "amlogic,meson-rng", },
{},
};
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
static struct platform_driver meson_rng_driver = {
.probe = meson_rng_probe,
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 9faa0b1e7766..982ed2fe927c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -32,7 +32,7 @@ config TCG_TIS_CORE
config TCG_TIS
tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO
Interface"
- depends on X86
+ depends on X86 || COMPILE_TEST
select TCG_TIS_CORE
---help---
If you have a TPM security chip that is compliant with the
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] crypto: Allow drivers to build if COMPILE_TEST is enabled
These drivers only have runtime but no build time dependencies so can be built for testing purposes if the Kconfig COMPILE_TEST option is enabled. This is useful to have more build coverage and make sure that drivers are not affected by changes that could cause build regressions. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/crypto/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index ab7e3b668890..dba87ab8878f 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -51,7 +51,7 @@ config CRYPTO_DEV_PADLOCK_SHA config CRYPTO_DEV_GEODE tristate "Support for the Geode LX AES engine" - depends on X86_32 && PCI + depends on (X86_32 || COMPILE_TEST) && PCI select CRYPTO_ALGAPI select CRYPTO_BLKCIPHER help @@ -175,7 +175,7 @@ config CRYPTO_DEV_MV_CESA config CRYPTO_DEV_MARVELL_CESA tristate "New Marvell's Cryptographic Engine driver" - depends on PLAT_ORION || ARCH_MVEBU + depends on PLAT_ORION || ARCH_MVEBU || COMPILE_TEST select CRYPTO_AES select CRYPTO_DES select CRYPTO_BLKCIPHER @@ -310,7 +310,7 @@ config CRYPTO_DEV_OMAP_DES config CRYPTO_DEV_PICOXCELL tristate "Support for picoXcell IPSEC and Layer2 crypto engines" - depends on ARCH_PICOXCELL && HAVE_CLK + depends on (ARCH_PICOXCELL || COMPILE_TEST) && HAVE_CLK select CRYPTO_AEAD select CRYPTO_AES select CRYPTO_AUTHENC @@ -338,7 +338,7 @@ config CRYPTO_DEV_SAHARA config CRYPTO_DEV_S5P tristate "Support for Samsung S5PV210/Exynos crypto accelerator" - depends on ARCH_S5PV210 || ARCH_EXYNOS + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST select CRYPTO_AES select CRYPTO_BLKCIPHER help @@ -429,7 +429,7 @@ endif config CRYPTO_DEV_MXS_DCP tristate "Support for Freescale MXS DCP" - depends on (ARCH_MXS || ARCH_MXC) + depends on (ARCH_MXS || ARCH_MXC || COMPILE_TEST) select CRYPTO_CBC select CRYPTO_ECB select CRYPTO_AES -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Hello Paul, On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker paul.gortma...@windriver.com wrote: [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote: On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: Hi Herbert, On Sun, 21 Jun 2015 16:27:17 +0800 Herbert Xu herb...@gondor.apana.org.au wrote: On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote: Indeed. Here is a patch fixing that. I think you should just kill COMPILE_TEST instead of adding ARM. The following patch is killing the COMPILE_TEST dependency. Patch applied. Just a heads up, this driver is still killing a couple of linux-next builds today and for the past few days. drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function 'of_get_named_gen_pool' [-Werror=implicit-function-declaration] http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/ http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/ Missing dependency on CONFIG_OF_blah presumably. I haven't looked at the series but linux/genalloc.h has a stub of_get_named_gen_pool() function if CONFIG_OF is not enabled [0]. So it seems that the problem is rather that the header is not being included in some file. Paul. -- Best regards, Javier [0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131 -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
