Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-18 Thread Paul Gortmaker 
On Wed, Apr 5, 2017 at 2:34 PM, Matthias Kaehlcke  wrote:
> The operand is an integer constant, make the constness explicit by
> adding the modifier. This is needed for clang to generate valid code
> and also works with gcc.

Actually it doesn't work with all gcc.  I've got an older arm64 toolchain that I
only use for syntax checking (and hence I don't care if it is the latest and
greatest) and this commit breaks it:

arch/arm64/crypto/sha1-ce-glue.c:21:2: error: invalid 'asm': invalid
operand prefix '%c'
  asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));

I'm currently reverting this change locally so I can continue to use the old
toolchain:

$ aarch64-linux-gnu-gcc --version
aarch64-linux-gnu-gcc (crosstool-NG linaro-1.13.1-4.8-2013.12 - Linaro
GCC 2013.11) 4.8.3 20131202 (prerelease)
Copyright (C) 2013 Free Software Foundation, Inc.

$ aarch64-linux-gnu-as --version
GNU assembler (crosstool-NG linaro-1.13.1-4.8-2013.12 - Linaro GCC
2013.11) 2.24.0.20131220
Copyright 2013 Free Software Foundation, Inc.

Maybe it is finally too old and nobody cares, but I thought it worth a mention.

Paul.
--

>
> Also change the constraint of the operand from 'I' ("Integer constant
> that is valid as an immediate operand in an ADD instruction", AArch64)
> to 'i' ("An immediate integer operand").
>
> Based-on-patch-from: Greg Hackmann 
> Signed-off-by: Greg Hackmann 
> Signed-off-by: Matthias Kaehlcke 
> ---
> Changes in v2:
> - Changed operand constraint from I to i
> - Updated commit message
> - Changed 'From' tag to 'Based-on-patch-from'
>
>  arch/arm64/crypto/sha1-ce-glue.c | 2 +-
>  arch/arm64/crypto/sha2-ce-glue.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/crypto/sha1-ce-glue.c 
> b/arch/arm64/crypto/sha1-ce-glue.c
> index aefda9868627..6b520e3f3ab1 100644
> --- a/arch/arm64/crypto/sha1-ce-glue.c
> +++ b/arch/arm64/crypto/sha1-ce-glue.c
> @@ -18,7 +18,7 @@
>  #include 
>
>  #define ASM_EXPORT(sym, val) \
> -   asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));
> +   asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));
>
>  MODULE_DESCRIPTION("SHA1 secure hash using ARMv8 Crypto Extensions");
>  MODULE_AUTHOR("Ard Biesheuvel ");
> diff --git a/arch/arm64/crypto/sha2-ce-glue.c 
> b/arch/arm64/crypto/sha2-ce-glue.c
> index 7cd587564a41..e3abe11de48c 100644
> --- a/arch/arm64/crypto/sha2-ce-glue.c
> +++ b/arch/arm64/crypto/sha2-ce-glue.c
> @@ -18,7 +18,7 @@
>  #include 
>
>  #define ASM_EXPORT(sym, val) \
> -   asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));
> +   asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));
>
>  MODULE_DESCRIPTION("SHA-224/SHA-256 secure hash using ARMv8 Crypto 
> Extensions");
>  MODULE_AUTHOR("Ard Biesheuvel ");
> --
> 2.12.2.715.g7642488e1d-goog
>

Re: linux-next: Tree for Oct 26 (crypto/acompress.ko)

2016-10-26 Thread Paul Gortmaker 
On Wed, Oct 26, 2016 at 10:48 AM, Randy Dunlap  wrote:
> On 10/25/16 19:51, Stephen Rothwell wrote:
>> Hi all,
>>
>> There will probably be no linux-next releases next week while I attend
>> the Kernel Summit.
>>
>> Changes since 20161025:
>>
>
> on x864_64:
>
> ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined!
> ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined!
> ERROR: "crypto_init_scomp_ops_async" [crypto/acompress.ko] undefined!
>
>
> Full randconfig file is attached.

crypto/acompress.o > crypto/Makefile:obj-$(CONFIG_CRYPTO_ACOMP2)
+= acompress.o

crypto/Kconfig:config CRYPTO_ACOMP2
crypto/Kconfig: tristate

paul@builder:~/git/linux-head$ git grep crypto_acomp_scomp_alloc_ctx
crypto/acompress.c: return crypto_acomp_scomp_alloc_ctx(req);
crypto/scompress.c:struct acomp_req
*crypto_acomp_scomp_alloc_ctx(struct acomp_req *req)
include/crypto/internal/scompress.h:struct acomp_req
*crypto_acomp_scomp_alloc_ctx(struct acomp_req *req);
paul@builder:~/git/linux-head$

So, no EXPORT_SYMBOL, and any .config which has ACOMP2=m will fail.

Paul.
--





>
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] padata: remove recently added module usage from bool code

2016-09-26 Thread Paul Gortmaker 
In commit 30e92153b4e6 ("padata: Convert to hotplug state machine")
this file started using module.h and got module_init and module_exit
added to it.

However the Kconfig for it is:

   init/Kconfig:config PADATA
   init/Kconfig:   depends on SMP
   init/Kconfig:   bool

...and so it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

Cc: Steffen Klassert <steffen.klass...@secunet.com>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Sebastian Andrzej Siewior <bige...@linutronix.de>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
---
 kernel/padata.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 7848f0566403..355807e52b1e 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -30,7 +30,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #define MAX_OBJ_NUM 1000
 
@@ -1043,11 +1043,6 @@ static __init int padata_driver_init(void)
hp_online = ret;
return 0;
 }
-module_init(padata_driver_init);
+device_initcall(padata_driver_init);
 
-static __exit void padata_driver_exit(void)
-{
-   cpuhp_remove_multi_state(hp_online);
-}
-module_exit(padata_driver_exit);
 #endif
-- 
2.10.0

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: x86/glue_helper make bool

2016-07-21 Thread Paul Gortmaker 
[Re: [PATCH] crypto: x86/glue_helper make bool] On 22/07/2016 (Fri 01:06) Luis 
R. Rodriguez wrote:

> On Thu, Jul 21, 2016 at 07:01:11PM -0400, Paul Gortmaker wrote:
> > [[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis 
> > R. Rodriguez wrote:
> > 
> > > Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> > > causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> > > it now detects the license is missing if you try to build the driver
> > > as a module, log below.
> > 
> > Reported and fixed two days ago ; the fix went out in yesterday's
> > linux-next via the tip tree.
> > 
> > https://lkml.kernel.org/r/20160719144243.gk21...@windriver.com
> > 
> > I fixed it by restoring the license, since making it bool might break
> > existing use cases,
> 
> How so?

In the now deleted text, you wrote:

  Fix this by removing the module option for it via Kconfig as it
  cannot be a module.

  glue_helper: module license 'unspecified' taints kernel.

The 2nd line of output clearly contradicts your 1st line stating it
cannot be a module.   It clearly was a module, and loaded, and tainted
the kernel because it had no license.

As for use cases, there can be many that could break. Someone with a
kernel that just fit in flash, now ends up with glue_helper builtin, and
their kernel won't fit anymore.

Or someone has a script that manually ran "modprobe glue_helper" at
startup along with other specifically chosen modules.  Now that step
will fail.

As I said, I don't want to be introducing runtime changes in an audit
for unnecessary module.h instances.

Paul.
--
> 
>   Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: x86/glue_helper make bool

2016-07-21 Thread Paul Gortmaker 
[[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis R. 
Rodriguez wrote:

> Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> it now detects the license is missing if you try to build the driver
> as a module, log below.

Reported and fixed two days ago ; the fix went out in yesterday's
linux-next via the tip tree.

https://lkml.kernel.org/r/20160719144243.gk21...@windriver.com

I fixed it by restoring the license, since making it bool might break
existing use cases, and my intent of this audit was to get rid of stuff
without altering runtime at all.

Thanks,
Paul.
--

> 
> Fix this by removing the module option for it via Kconfig as it
> cannot be a module.
> 
> glue_helper: module license 'unspecified' taints kernel.
> glue_helper: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> glue_helper: Unknown symbol blkcipher_walk_done (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
> glue_helper: Unknown symbol kernel_fpu_end (err 0)
> glue_helper: Unknown symbol kernel_fpu_begin (err 0)
> glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
> 
> Signed-off-by: Luis R. Rodriguez 
> ---
>  crypto/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a9377bef25e3..ed6abf4bbf3b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -237,7 +237,7 @@ config CRYPTO_ABLK_HELPER
>   select CRYPTO_CRYPTD
>  
>  config CRYPTO_GLUE_HELPER_X86
> - tristate
> + bool
>   depends on X86
>   select CRYPTO_ALGAPI
>  
> -- 
> 2.8.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] crypto: asymmetric_keys/signature.c does not need

2015-12-09 Thread Paul Gortmaker 
This file does not contain any modular related function calls.  So get
rid of module.h since it drags in a lot of other headers and adds to
the preprocessing load.  It does export some symbols though, so we'll
need to ensure it has export.h present instead.

Cc: Herbert Xu <herb...@gondor.apana.org.au>
Cc: "David S. Miller" <da...@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
---
 crypto/asymmetric_keys/signature.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/asymmetric_keys/signature.c 
b/crypto/asymmetric_keys/signature.c
index 7525fd183574..da0821eb69fd 100644
--- a/crypto/asymmetric_keys/signature.c
+++ b/crypto/asymmetric_keys/signature.c
@@ -13,7 +13,7 @@
 
 #define pr_fmt(fmt) "SIG: "fmt
 #include 
-#include 
+#include 
 #include 
 #include 
 #include "asymmetric_keys.h"
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug

2015-08-21 Thread Paul Gortmaker 
On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa
leosi...@linux.vnet.ibm.com wrote:
 AES-CTR is using a counter 8bytes-8bytes what miss match with
 kernel specs.

 In the previous code a vadduwm was done to increment counter.
 Replacing this for a vadduqm now considering both cases counter
 8-8 bytes and full 16bytes.

Seems this breaks ppc allmodconfig:

drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm'

1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 is the first bad commit
commit 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0
Author: Leonidas Da Silva Barbosa leosi...@linux.vnet.ibm.com
Date:   Fri Aug 14 10:12:22 2015 -0300

crypto: vmx - Fixing AES-CTR counter bug


   http://kisskb.ellerman.id.au/kisskb/buildresult/12490159/


Paul.
--


 Signed-off-by: Leonidas S Barbosa leosi...@linux.vnet.ibm.com
 ---
  drivers/crypto/vmx/aes_ctr.c|  8 +++-
  drivers/crypto/vmx/aesp8-ppc.pl | 34 +-
  2 files changed, 24 insertions(+), 18 deletions(-)


--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename

2015-06-25 Thread Paul Gortmaker 
On Thu, Jun 25, 2015 at 11:30 AM, Herbert Xu
herb...@gondor.apana.org.au wrote:
 On Thu, Jun 25, 2015 at 10:37:50AM +0200, Simon Guinot wrote:
 This patch fixes the following build error:

 drivers/crypto/mv_cesa.c: In function 'mv_cesa_get_sram':
 drivers/crypto/mv_cesa.c:1037: error: implicit declaration of function 
 'of_get_named_gen_pool'
 drivers/crypto/mv_cesa.c:1038: warning: assignment makes pointer from 
 integer without a cast
 scripts/Makefile.build:258: recipe for target 'drivers/crypto/mv_cesa.o' 
 failed

 Signed-off-by: Simon Guinot simon.gui...@sequanux.org

 This patch doesn't compile.

As sfr pointed out, this is an interaction with a rename patch in
the akpm tree; sfr added a fixup patch here last night:

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?h=akpm

crypto: marvell/cesa - another fix up for of_get_named_gen_pool() rename

Paul.
--

 --
 Email: Herbert Xu herb...@gondor.apana.org.au
 Home Page: http://gondor.apana.org.au/~herbert/
 PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
 --
 To unsubscribe from this list: send the line unsubscribe linux-next in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-24 Thread Paul Gortmaker 
[Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 
22/06/2015 (Mon 15:59) Herbert Xu wrote:

 On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote:
  Hi Herbert,
  
  On Sun, 21 Jun 2015 16:27:17 +0800
  Herbert Xu herb...@gondor.apana.org.au wrote:
  
   On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote:

Indeed. Here is a patch fixing that.
   
   I think you should just kill COMPILE_TEST instead of adding ARM.
  
  The following patch is killing the COMPILE_TEST dependency.
 
 Patch applied.

Just a heads up, this driver is still killing a couple of linux-next
builds today and for the past few days.

drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function
'of_get_named_gen_pool' [-Werror=implicit-function-declaration]

http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/
http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/

Missing dependency on CONFIG_OF_blah presumably.

Paul.
--

 -- 
 Email: Herbert Xu herb...@gondor.apana.org.au
 Home Page: http://gondor.apana.org.au/~herbert/
 PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-20 Thread Paul Gortmaker 
On Fri, Jun 19, 2015 at 10:24 AM, Herbert Xu
herb...@gondor.apana.org.au wrote:
 On Thu, Jun 18, 2015 at 03:46:16PM +0200, Boris Brezillon wrote:
 Hello,

 This patch series adds a new driver supporting Marvell's CESA IP.
 This driver addresses some limitations of the existing one.
 From a performance and CPU load point of view the most important
 limitation in the existing driver is the lack of DMA support, thus
 preventing us from chaining crypto operations.

 All applied to cryptodev.  Thanks a lot!

It seems this breaks linux-next allmodconfig on i386:

http://kisskb.ellerman.id.au/kisskb/buildresult/12445342/

ERROR: phys_to_dma [drivers/crypto/marvell/marvell-cesa.ko] undefined!
make[2]: *** [__modpost] Error 1

Paul.
--
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-20 Thread Paul Gortmaker 
On Sat, Jun 20, 2015 at 4:32 PM, Paul Gortmaker
paul.gortma...@windriver.com wrote:
 On Fri, Jun 19, 2015 at 10:24 AM, Herbert Xu
 herb...@gondor.apana.org.au wrote:
 On Thu, Jun 18, 2015 at 03:46:16PM +0200, Boris Brezillon wrote:
 Hello,

 This patch series adds a new driver supporting Marvell's CESA IP.
 This driver addresses some limitations of the existing one.
 From a performance and CPU load point of view the most important
 limitation in the existing driver is the lack of DMA support, thus
 preventing us from chaining crypto operations.

 All applied to cryptodev.  Thanks a lot!

 It seems this breaks linux-next allmodconfig on i386:

Similar breakage for s390 and sparc it seems:

drivers/crypto/marvell/cesa.c:353:2: error: implicit declaration of
function 'phys_to_dma' [-Werror=implicit-function-declaration]

http://kisskb.ellerman.id.au/kisskb/buildresult/12445415/
http://kisskb.ellerman.id.au/kisskb/buildresult/12445345/

If the CESA IP is only available on a single arch then
adding an arch dependency might be the easiest fix,
since phys_to_dma seems sparsely implemented.

Paul.
--


 http://kisskb.ellerman.id.au/kisskb/buildresult/12445342/

 ERROR: phys_to_dma [drivers/crypto/marvell/marvell-cesa.ko] undefined!
 make[2]: *** [__modpost] Error 1

 Paul.
 --
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in

[PATCH 62/73] drivers/crypto: delete non-required instances of include linux/init.h

2014-01-21 Thread Paul Gortmaker 
None of these files are actually using any __init type directives
and hence don't need to include linux/init.h.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: David S. Miller da...@davemloft.net
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com
---
 drivers/crypto/atmel-aes.c| 1 -
 drivers/crypto/atmel-sha.c| 1 -
 drivers/crypto/atmel-tdes.c   | 1 -
 drivers/crypto/nx/nx_debugfs.c| 1 -
 drivers/crypto/omap-aes.c | 1 -
 drivers/crypto/omap-sham.c| 1 -
 drivers/crypto/picoxcell_crypto.c | 1 -
 drivers/crypto/s5p-sss.c  | 1 -
 drivers/crypto/tegra-aes.c| 1 -
 9 files changed, 9 deletions(-)

diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index d7c9e31..70fb6fb 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 0618be0..637141b 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 6cde5b5..604a67f 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c
index 7ab2e8d..899d857 100644
--- a/drivers/crypto/nx/nx_debugfs.c
+++ b/drivers/crypto/nx/nx_debugfs.c
@@ -24,7 +24,6 @@
 #include linux/string.h
 #include linux/debugfs.h
 #include linux/module.h
-#include linux/init.h
 #include linux/crypto.h
 #include crypto/hash.h
 #include asm/vio.h
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index dde41f1d..6d34dac 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -19,7 +19,6 @@
 
 #include linux/err.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/platform_device.h
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index a727a6a..5d303eb 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -19,7 +19,6 @@
 #include linux/err.h
 #include linux/device.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/kernel.h
diff --git a/drivers/crypto/picoxcell_crypto.c 
b/drivers/crypto/picoxcell_crypto.c
index a6175ba..e50a1b9 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -29,7 +29,6 @@
 #include linux/dma-mapping.h
 #include linux/dmapool.h
 #include linux/err.h
-#include linux/init.h
 #include linux/interrupt.h
 #include linux/io.h
 #include linux/list.h
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index cf149b1..78b7eed 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -14,7 +14,6 @@
 #include linux/delay.h
 #include linux/err.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/clk.h
diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c
index 060eecc..4c0548f 100644
--- a/drivers/crypto/tegra-aes.c
+++ b/drivers/crypto/tegra-aes.c
@@ -30,7 +30,6 @@
 #define pr_fmt(fmt) KBUILD_MODNAME :  fmt
 
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/clk.h
-- 
1.8.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

2012-03-11 Thread Paul Gortmaker 
On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper ja...@lakedaemon.net wrote:
 On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
 Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)

     ARM: kirkwood: mv_cesa devicetree bindings

 fails to compile as follows:

  CC      drivers/crypto/mv_cesa.o
  drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 
 'of_match_ptr'
  drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not 
 in a function)
  drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
  drivers/crypto/mv_cesa.c:1139: error: (near initialization for 
 'marvell_crypto.driver.of_match_table')

 because it is missing the linux/of.h header file.

 Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com

 Paul,

 Thanks for the patch.  Unfortunately, I'm not learning fast enough.  ;-)
 This series has been in a lot of flux lately, as you've experienced.

 The good news is, after talking with Olaf and Arnd, I think I have a
 good workflow figured out.  Hopefully, failures like this won't happen
 in the future.

Sounds good -- don't be too hard on yourself wrt. a minor breakage.
Feel free to just squish the above patch into whatever updates you
have going.  I don't see it needing to exist as a standalone commit.

THanks,
Paul.
--


 As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label
 it broken ;-) )  I intended it as a publicly viewable branch of what's
 coming down the pipe, but it's not working out the way I intended.

 As for mv_cesa, it's next on my list.  As soon as I figure out the irq
 stuff.

 Thanks for testing.

 Jason.


 diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
 index b7a3d48..093e214 100644
 --- a/drivers/crypto/mv_cesa.c
 +++ b/drivers/crypto/mv_cesa.c
 @@ -10,6 +10,7 @@
  #include crypto/algapi.h
  #include linux/crypto.h
  #include linux/interrupt.h
 +#include linux/of.h
  #include linux/io.h
  #include linux/kthread.h
  #include linux/platform_device.h
 --
 1.7.9.1

 --
 To unsubscribe from this list: send the line unsubscribe linux-next in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html