Re: [PATCH] crypto: omap-sham: fix memleak

[Herbert Xu]

On Tue, Apr 17, 2018 at 02:53:13PM -0500, Bin Liu wrote:
> Fixes: 8043bb1ae03cb ("crypto: omap-sham - convert driver logic to use sgs 
> for data xmit")
> 
> The memory pages freed in omap_sham_finish_req() were less than those
> allocated in omap_sham_copy_sgs().
> 
> Cc: sta...@vger.kernel.org
> Signed-off-by: Bin Liu 
> ---
>  drivers/crypto/omap-sham.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: omap-sham: fix memleak

[Tero Kristo]

On 17/04/18 22:53, Bin Liu wrote:

Fixes: 8043bb1ae03cb ("crypto: omap-sham - convert driver logic to use sgs for data 
xmit")

The memory pages freed in omap_sham_finish_req() were less than those
allocated in omap_sham_copy_sgs().

Cc: sta...@vger.kernel.org
Signed-off-by: Bin Liu 


Acked-by: Tero Kristo 


---
  drivers/crypto/omap-sham.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 86b89ace836f..07235d0be29c 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -1082,7 +1082,7 @@ static void omap_sham_finish_req(struct ahash_request 
*req, int err)
  
  	if (test_bit(FLAGS_SGS_COPIED, >flags))

free_pages((unsigned long)sg_virt(ctx->sg),
-  get_order(ctx->sg->length));
+  get_order(ctx->sg->length + ctx->bufcnt));
  
  	if (test_bit(FLAGS_SGS_ALLOCED, >flags))

kfree(ctx->sg);



--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[PATCH] crypto: omap-sham: fix memleak

[Bin Liu]

Fixes: 8043bb1ae03cb ("crypto: omap-sham - convert driver logic to use sgs for 
data xmit")

The memory pages freed in omap_sham_finish_req() were less than those
allocated in omap_sham_copy_sgs().

Cc: sta...@vger.kernel.org
Signed-off-by: Bin Liu 
---
 drivers/crypto/omap-sham.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 86b89ace836f..07235d0be29c 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -1082,7 +1082,7 @@ static void omap_sham_finish_req(struct ahash_request 
*req, int err)
 
if (test_bit(FLAGS_SGS_COPIED, >flags))
free_pages((unsigned long)sg_virt(ctx->sg),
-  get_order(ctx->sg->length));
+  get_order(ctx->sg->length + ctx->bufcnt));
 
if (test_bit(FLAGS_SGS_ALLOCED, >flags))
kfree(ctx->sg);
-- 
1.9.1