Re: [PATCH 0/2] add crypto support for TPM communication

2018-03-09 Thread Herbert Xu
James Bottomley  wrote:
> To support cryptographic communication with the TPM, we need to add
> Cipher FeedBack (CFB) mode for stream encryption because this is the
> mandated encryption scheme for all encrypted parameters and responses.
>  Additionally, we ran across a problem in the elliptic curve routines
> in that the size of the scatterlist is hard coded to 1 which causes a
> kernel BUG if you use a longer scatterlist.  Since all the current
> kernel consumers use a single element scatterlist, this bug won't
> manifest until we add the TPM routines to use crypto, so I didn't mark
> it for stable.
> 
> James Bottomley (2):
>  crypto: cfb: add support for Cipher FeedBack mode
>  crypto: ecdh: fix to allow multi segment scatterlists
> 
> crypto/Kconfig  |   8 ++
> crypto/Makefile |   1 +
> crypto/cfb.c| 353 
> crypto/ecdh.c   |  23 +++-
> 4 files changed, 379 insertions(+), 6 deletions(-)
> create mode 100644 crypto/cfb.c

All applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


[PATCH 0/2] add crypto support for TPM communication

2018-03-01 Thread James Bottomley
To support cryptographic communication with the TPM, we need to add
Cipher FeedBack (CFB) mode for stream encryption because this is the
mandated encryption scheme for all encrypted parameters and responses.
 Additionally, we ran across a problem in the elliptic curve routines
in that the size of the scatterlist is hard coded to 1 which causes a
kernel BUG if you use a longer scatterlist.  Since all the current
kernel consumers use a single element scatterlist, this bug won't
manifest until we add the TPM routines to use crypto, so I didn't mark
it for stable.

James Bottomley (2):
  crypto: cfb: add support for Cipher FeedBack mode
  crypto: ecdh: fix to allow multi segment scatterlists

 crypto/Kconfig  |   8 ++
 crypto/Makefile |   1 +
 crypto/cfb.c| 353 
 crypto/ecdh.c   |  23 +++-
 4 files changed, 379 insertions(+), 6 deletions(-)
 create mode 100644 crypto/cfb.c

-- 
2.12.3