Re: [PATCH 00/11] crypto: caam: Error reporting fixes

2014-05-08 Thread Marek Vasut
On Thursday, May 08, 2014 at 04:01:06 PM, Herbert Xu wrote:
> On Thu, Apr 24, 2014 at 08:05:11PM +0200, Marek Vasut wrote:
> > First stab at reworking the error.c thing in Freescale CAAM.
> > This patchset cleans it up so it's not doing any too insane
> > string messing anymore.
> > 
> > NOTE: Can someone please test this on real hardware? I have
> > 
> >   none at hand, so THIS IS COMPILE-TESTED ONLY!
> > 
> > Marek Vasut (11):
> All applied.  Thanks Marek.

Thank you!

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/11] crypto: caam: Error reporting fixes

2014-05-08 Thread Herbert Xu
On Thu, Apr 24, 2014 at 08:05:11PM +0200, Marek Vasut wrote:
> First stab at reworking the error.c thing in Freescale CAAM.
> This patchset cleans it up so it's not doing any too insane
> string messing anymore.
> 
> NOTE: Can someone please test this on real hardware? I have
>   none at hand, so THIS IS COMPILE-TESTED ONLY!
> 
> Marek Vasut (11):

All applied.  Thanks Marek.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/11] crypto: caam: Error reporting fixes

2014-04-25 Thread Kees Cook
On Apr 24, Marek wrote:
> First stab at reworking the error.c thing in Freescale CAAM.
> This patchset cleans it up so it's not doing any too insane
> string messing anymore.
>
> NOTE: Can someone please test this on real hardware? I have
>   none at hand, so THIS IS COMPILE-TESTED ONLY!
>
> Marek Vasut (11):
>   crypto: caam: Contain caam_jr_strstatus() ugliness
>   crypto: caam: Pull all the error codes out
>   crypto: caam: Implement fast-path for error codes with no handler
>   crypto: caam: Pass error type into the functions
>   crypto: caam: Kill the easy targets
>   crypto: caam: Dissolve report_jump_idx()
>   crypto: caam: Clean up report_ccb_status()
>   crypto: caam: Clean up report_deco_status()
>   crypto: caam: Kill SPRINTFCAT() with fire
>   crypto: caam: Sweep the remnants
>   crypto: caam: Fix the 'quoted string split across lines'
>
>  drivers/crypto/caam/caamalg.c  |  28 +--
>  drivers/crypto/caam/caamhash.c |  28 +--
>  drivers/crypto/caam/caamrng.c  |   7 +-
>  drivers/crypto/caam/error.c| 389
> +++--
>  drivers/crypto/caam/error.h|   2 +-
>  drivers/crypto/caam/key_gen.c  |   7 +-
>  6 files changed, 200 insertions(+), 261 deletions(-)
>
> Signed-off-by: Marek Vasut 
> Cc: Herbert Xu 
> Cc: Horia Geanta 

Thanks for doing this! The final result looks good to me, though I too
can't test with real hardware. Please consider the whole series:

Reviewed-by: Kees Cook 

Thanks,

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 00/11] crypto: caam: Error reporting fixes

2014-04-24 Thread Marek Vasut
First stab at reworking the error.c thing in Freescale CAAM.
This patchset cleans it up so it's not doing any too insane
string messing anymore.

NOTE: Can someone please test this on real hardware? I have
  none at hand, so THIS IS COMPILE-TESTED ONLY!

Marek Vasut (11):
  crypto: caam: Contain caam_jr_strstatus() ugliness
  crypto: caam: Pull all the error codes out
  crypto: caam: Implement fast-path for error codes with no handler
  crypto: caam: Pass error type into the functions
  crypto: caam: Kill the easy targets
  crypto: caam: Dissolve report_jump_idx()
  crypto: caam: Clean up report_ccb_status()
  crypto: caam: Clean up report_deco_status()
  crypto: caam: Kill SPRINTFCAT() with fire
  crypto: caam: Sweep the remnants
  crypto: caam: Fix the 'quoted string split across lines'

 drivers/crypto/caam/caamalg.c  |  28 +--
 drivers/crypto/caam/caamhash.c |  28 +--
 drivers/crypto/caam/caamrng.c  |   7 +-
 drivers/crypto/caam/error.c| 389 +++--
 drivers/crypto/caam/error.h|   2 +-
 drivers/crypto/caam/key_gen.c  |   7 +-
 6 files changed, 200 insertions(+), 261 deletions(-)

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 

-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html