Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP

2013-08-27 Thread Jiri Kosina 
On Mon, 26 Aug 2013, Pavel Machek wrote:

Due to RSA_I2OSP is not only used by signature verification path but 
also used
in signature generation path. So, separate the length checking of octet 
string
because it's not for generate 0x00 0x01 leading string when used in 
signature
generation.

Reviewed-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Lee, Chun-Yi j...@suse.com
   
+static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
+{
+   unsigned x_size;
+   unsigned X_size;
+   u8 *X = NULL;
   
   Is this kernel code or entry into obfuscated C code contest? This is not 
   funny.
   
  The small x is the input integer that will transfer to big X that is
  a octet sting. 
  
  Sorry for I direct give variable name to match with spec, maybe I need
  use big_X or
 
 Having variables that differ only in case is confusing. Actually
 RSA_I2OSP is not a good name for function, either.
 
 If it converts x into X, perhaps you can name one input and second output?

The variable naming is according to spec, and I believe it makes sense to 
keep it so, no matter how stupid the naming in the spec might be.

Otherwise you have to do mental remapping when looking at the code and the 
spec at the same time, which is very inconvenient.

Would a comment next to the variable declaration, that would point this 
fact out, be satisfactory for you?

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP

2013-08-26 Thread joeyli 
於 日，2013-08-25 於 18:01 +0200，Pavel Machek 提到：
 On Thu 2013-08-22 19:01:42, Lee, Chun-Yi wrote:
  Due to RSA_I2OSP is not only used by signature verification path but also 
  used
  in signature generation path. So, separate the length checking of octet 
  string
  because it's not for generate 0x00 0x01 leading string when used in 
  signature
  generation.
  
  Reviewed-by: Jiri Kosina jkos...@suse.cz
  Signed-off-by: Lee, Chun-Yi j...@suse.com
 
  +static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
  +{
  +   unsigned x_size;
  +   unsigned X_size;
  +   u8 *X = NULL;
 
 Is this kernel code or entry into obfuscated C code contest? This is not 
 funny.
 
   Pavel

The small x is the input integer that will transfer to big X that is
a octet sting. 

Sorry for I direct give variable name to match with spec, maybe I need
use big_X or

Do you have good suggest for the naming?


Thanks a lot!
Joey Lee


--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP

2013-08-25 Thread Pavel Machek 
On Thu 2013-08-22 19:01:42, Lee, Chun-Yi wrote:
 Due to RSA_I2OSP is not only used by signature verification path but also used
 in signature generation path. So, separate the length checking of octet string
 because it's not for generate 0x00 0x01 leading string when used in signature
 generation.
 
 Reviewed-by: Jiri Kosina jkos...@suse.cz
 Signed-off-by: Lee, Chun-Yi j...@suse.com

 +static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
 +{
 + unsigned x_size;
 + unsigned X_size;
 + u8 *X = NULL;

Is this kernel code or entry into obfuscated C code contest? This is not funny.

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html