Re: [PATCH 1/2] crypto: move CCP device driver to misc
Hi Brijesh, [auto build test ERROR on cryptodev/master] [also build test ERROR on next-20170120] [cannot apply to char-misc/char-misc-testing v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brijesh-Singh/Introduce-AMD-Secure-Processor-device/20170120-185157 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: um-allyesconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=um All errors (new ones prefixed by >>): arch/um/drivers/built-in.o: In function `vde_open_real': (.text+0xc9a1): warning: Using 'getgrnam' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `vde_open_real': (.text+0xc7ec): warning: Using 'getpwuid' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `vde_open_real': (.text+0xcb05): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `pcap_nametoaddr': (.text+0x1d595): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `pcap_nametonetaddr': (.text+0x1d635): warning: Using 'getnetbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `pcap_nametoproto': (.text+0x1d855): warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking arch/um/drivers/built-in.o: In function `pcap_nametoport': (.text+0x1d687): warning: Using 'getservbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking drivers/built-in.o: In function `ccp_init_dm_workarea': >> drivers/misc/amd-sp/ccp-ops.c:141: undefined reference to `dma_pool_alloc' drivers/built-in.o: In function `ccp_init_dm_workarea': include/linux/dma-mapping.h:190: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp_sg_free': include/linux/dma-mapping.h:242: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp_dm_free': >> drivers/misc/amd-sp/ccp-ops.c:112: undefined reference to `dma_pool_free' drivers/built-in.o: In function `ccp_dm_free': include/linux/dma-mapping.h:207: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp_init_data': include/linux/dma-mapping.h:227: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp_destroy': >> drivers/misc/amd-sp/ccp-dev-v3.c:501: undefined reference to >> `dma_pool_destroy' drivers/built-in.o: In function `ccp_init': >> drivers/misc/amd-sp/ccp-dev-v3.c:337: undefined reference to >> `dma_pool_create' drivers/misc/amd-sp/ccp-dev-v3.c:456: undefined reference to `dma_pool_destroy' drivers/built-in.o: In function `ccp5_destroy': include/linux/dma-mapping.h:484: undefined reference to `bad_dma_ops' include/linux/dma-mapping.h:490: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp5_init': >> drivers/misc/amd-sp/ccp-dev-v5.c:676: undefined reference to >> `dma_pool_create' drivers/built-in.o: In function `ccp5_init': include/linux/dma-mapping.h:463: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp5_init': >> drivers/misc/amd-sp/ccp-dev-v5.c:861: undefined reference to >> `dma_pool_destroy' drivers/built-in.o: In function `ccp_platform_probe': drivers/misc/amd-sp/ccp-platform.c:148: undefined reference to `devm_ioremap_resource' drivers/built-in.o: In function `ccp_platform_probe': include/linux/dma-mapping.h:555: undefined reference to `bad_dma_ops' include/linux/dma-mapping.h:542: undefined reference to `bad_dma_ops' include/linux/dma-mapping.h:544: undefined reference to `bad_dma_ops' include/linux/dma-mapping.h:542: undefined reference to `bad_dma_ops' include/linux/dma-mapping.h:544: undefined reference to `bad_dma_ops' drivers/built-in.o: In function `ccp_cmd_callback': drivers/misc/amd-sp/ccp-dmaengine.c:204: undefined reference to `dma_run_dependencies' drivers/built-in.o: In function `ccp_alloc_dma_desc': drivers/misc/amd-sp/ccp-dmaengine.c:306: undefined reference to `dma_async_tx_descriptor_init' drivers/built-in.o: In function `ccp_dmaengine_register': drivers/misc/amd-sp/ccp-dmaengine.c:705: undefined reference to `dma_async_de
Re: [PATCH 1/2] crypto: move CCP device driver to misc
Hi Greg, On 01/19/2017 12:18 PM, Greg KH wrote: On Thu, Jan 19, 2017 at 01:08:01PM -0500, Brijesh Singh wrote: The CCP device is part of the AMD Secure Processor, which is not dedicated solely to crypto. Move the CCP device driver to the misc directory in prepration for expanding the usage of the AMD Secure Processor. Leaving the CCP cryptographic layer (the ccp-crypto* files) in their current directory. Signed-off-by: Brijesh Singh Signed-off-by: Tom Lendacky --- drivers/crypto/Kconfig | 11 drivers/crypto/Makefile |2 drivers/crypto/ccp/Kconfig | 21 drivers/crypto/ccp/Makefile |9 drivers/crypto/ccp/ccp-dev-v3.c | 574 --- drivers/crypto/ccp/ccp-dev-v5.c | 1021 --- drivers/crypto/ccp/ccp-dev.c| 588 --- drivers/crypto/ccp/ccp-dev.h| 647 drivers/crypto/ccp/ccp-dmaengine.c | 728 -- drivers/crypto/ccp/ccp-ops.c| 1876 --- drivers/crypto/ccp/ccp-pci.c| 354 --- drivers/crypto/ccp/ccp-platform.c | 293 - drivers/misc/Kconfig|1 drivers/misc/Makefile |1 drivers/misc/amd-sp/Kconfig | 14 drivers/misc/amd-sp/Makefile|8 drivers/misc/amd-sp/ccp-dev-v3.c| 574 +++ drivers/misc/amd-sp/ccp-dev-v5.c| 1021 +++ drivers/misc/amd-sp/ccp-dev.c | 588 +++ drivers/misc/amd-sp/ccp-dev.h | 647 drivers/misc/amd-sp/ccp-dmaengine.c | 728 ++ drivers/misc/amd-sp/ccp-ops.c | 1876 +++ drivers/misc/amd-sp/ccp-pci.c | 354 +++ drivers/misc/amd-sp/ccp-platform.c | 293 + include/linux/ccp.h |3 25 files changed, 6111 insertions(+), 6121 deletions(-) delete mode 100644 drivers/crypto/ccp/ccp-dev-v3.c delete mode 100644 drivers/crypto/ccp/ccp-dev-v5.c delete mode 100644 drivers/crypto/ccp/ccp-dev.c delete mode 100644 drivers/crypto/ccp/ccp-dev.h delete mode 100644 drivers/crypto/ccp/ccp-dmaengine.c delete mode 100644 drivers/crypto/ccp/ccp-ops.c delete mode 100644 drivers/crypto/ccp/ccp-pci.c delete mode 100644 drivers/crypto/ccp/ccp-platform.c create mode 100644 drivers/misc/amd-sp/Kconfig create mode 100644 drivers/misc/amd-sp/Makefile create mode 100644 drivers/misc/amd-sp/ccp-dev-v3.c create mode 100644 drivers/misc/amd-sp/ccp-dev-v5.c create mode 100644 drivers/misc/amd-sp/ccp-dev.c create mode 100644 drivers/misc/amd-sp/ccp-dev.h create mode 100644 drivers/misc/amd-sp/ccp-dmaengine.c create mode 100644 drivers/misc/amd-sp/ccp-ops.c create mode 100644 drivers/misc/amd-sp/ccp-pci.c create mode 100644 drivers/misc/amd-sp/ccp-platform.c Please create your patch with -M, to show this is a rename, or a change with a rename. Otherwise this is an impossible patch to review, would you want to try to do it? Thanks for the tip, will re-generate the patches with -M. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] crypto: move CCP device driver to misc
On Thu, Jan 19, 2017 at 01:08:01PM -0500, Brijesh Singh wrote: > The CCP device is part of the AMD Secure Processor, which is not dedicated > solely to crypto. Move the CCP device driver to the misc directory in > prepration for expanding the usage of the AMD Secure Processor. Leaving the > CCP cryptographic layer (the ccp-crypto* files) in their current directory. > > Signed-off-by: Brijesh Singh > Signed-off-by: Tom Lendacky > --- > drivers/crypto/Kconfig | 11 > drivers/crypto/Makefile |2 > drivers/crypto/ccp/Kconfig | 21 > drivers/crypto/ccp/Makefile |9 > drivers/crypto/ccp/ccp-dev-v3.c | 574 --- > drivers/crypto/ccp/ccp-dev-v5.c | 1021 --- > drivers/crypto/ccp/ccp-dev.c| 588 --- > drivers/crypto/ccp/ccp-dev.h| 647 > drivers/crypto/ccp/ccp-dmaengine.c | 728 -- > drivers/crypto/ccp/ccp-ops.c| 1876 > --- > drivers/crypto/ccp/ccp-pci.c| 354 --- > drivers/crypto/ccp/ccp-platform.c | 293 - > drivers/misc/Kconfig|1 > drivers/misc/Makefile |1 > drivers/misc/amd-sp/Kconfig | 14 > drivers/misc/amd-sp/Makefile|8 > drivers/misc/amd-sp/ccp-dev-v3.c| 574 +++ > drivers/misc/amd-sp/ccp-dev-v5.c| 1021 +++ > drivers/misc/amd-sp/ccp-dev.c | 588 +++ > drivers/misc/amd-sp/ccp-dev.h | 647 > drivers/misc/amd-sp/ccp-dmaengine.c | 728 ++ > drivers/misc/amd-sp/ccp-ops.c | 1876 > +++ > drivers/misc/amd-sp/ccp-pci.c | 354 +++ > drivers/misc/amd-sp/ccp-platform.c | 293 + > include/linux/ccp.h |3 > 25 files changed, 6111 insertions(+), 6121 deletions(-) > delete mode 100644 drivers/crypto/ccp/ccp-dev-v3.c > delete mode 100644 drivers/crypto/ccp/ccp-dev-v5.c > delete mode 100644 drivers/crypto/ccp/ccp-dev.c > delete mode 100644 drivers/crypto/ccp/ccp-dev.h > delete mode 100644 drivers/crypto/ccp/ccp-dmaengine.c > delete mode 100644 drivers/crypto/ccp/ccp-ops.c > delete mode 100644 drivers/crypto/ccp/ccp-pci.c > delete mode 100644 drivers/crypto/ccp/ccp-platform.c > create mode 100644 drivers/misc/amd-sp/Kconfig > create mode 100644 drivers/misc/amd-sp/Makefile > create mode 100644 drivers/misc/amd-sp/ccp-dev-v3.c > create mode 100644 drivers/misc/amd-sp/ccp-dev-v5.c > create mode 100644 drivers/misc/amd-sp/ccp-dev.c > create mode 100644 drivers/misc/amd-sp/ccp-dev.h > create mode 100644 drivers/misc/amd-sp/ccp-dmaengine.c > create mode 100644 drivers/misc/amd-sp/ccp-ops.c > create mode 100644 drivers/misc/amd-sp/ccp-pci.c > create mode 100644 drivers/misc/amd-sp/ccp-platform.c Please create your patch with -M, to show this is a rename, or a change with a rename. Otherwise this is an impossible patch to review, would you want to try to do it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html