Re: [PATCH 1/3] crypto: talitos - fix warning: 'alg' may be used uninitialized in this function

2010-09-23 Thread Herbert Xu 
On Mon, Sep 13, 2010 at 10:45:33PM +, Kim Phillips wrote:
> drivers/crypto/talitos.c: In function 'talitos_probe':
> drivers/crypto/talitos.c:2363: warning: 'alg' may be used uninitialized in 
> this function
> drivers/crypto/talitos.c:2363: note: 'alg' was declared here
> 
> Signed-off-by: Kim Phillips 

All three patches applied.  Thanks Kim!
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] crypto: talitos - fix warning: 'alg' may be used uninitialized in this function

2010-09-13 Thread Kim Phillips 
drivers/crypto/talitos.c: In function 'talitos_probe':
drivers/crypto/talitos.c:2363: warning: 'alg' may be used uninitialized in this 
function
drivers/crypto/talitos.c:2363: note: 'alg' was declared here

Signed-off-by: Kim Phillips 
---
 drivers/crypto/talitos.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index 4bcd825..d4c1fc2 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -2389,6 +2389,9 @@ static struct talitos_crypto_alg 
*talitos_alg_alloc(struct device *dev,
DESC_HDR_MODE0_MDEU_SHA256;
}
break;
+   default:
+   dev_err(dev, "unknown algorithm type %d\n", t_alg->algt.type);
+   return ERR_PTR(-EINVAL);
}
 
alg->cra_module = THIS_MODULE;
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html