Re: [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()
On Mon, Jun 29, 2009 at 11:45:08PM +0200, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior
>
> As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads
> to:
> |BUG: sleeping function called from invalid context at kernel/rwsem.c:21
> |in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe
> |INFO: lockdep is turned off.
> |Pid: 4926, comm: modprobe Tainted: G M 2.6.31-rc1-22297-g5298976 #24
> |Call Trace:
> | [] __might_sleep+0xf9/0x101
> | [] down_read+0x16/0x68
> | [] crypto_alg_lookup+0x16/0x34
> | [] crypto_larval_lookup+0x30/0xf9
> | [] crypto_alg_mod_lookup+0x1d/0x62
> | [] crypto_alloc_base+0x1e/0x64
> | [] reset_prng_context+0xab/0x13f
> | [] ? __spin_lock_init+0x27/0x51
> | [] cprng_init+0x2a/0x42
> | [] __crypto_alloc_tfm+0xfa/0x128
> | [] crypto_alloc_base+0x33/0x64
> | [] alg_test_cprng+0x30/0x1f4
> | [] alg_test+0x12f/0x19f
> | [] ? __alloc_pages_nodemask+0x14d/0x481
> | [] do_test+0xf9d/0x163f [tcrypt]
> | [] do_test+0x3a1/0x163f [tcrypt]
> | [] tcrypt_mod_init+0x35/0x7c [tcrypt]
> | [] _stext+0x54/0x12c
> | [] ? tcrypt_mod_init+0x0/0x7c [tcrypt]
> | [] ? up_read+0x16/0x2b
> | [] ? __blocking_notifier_call_chain+0x40/0x4c
> | [] sys_init_module+0xa9/0x1bf
> | [] sysenter_do_call+0x12/0x32
>
> because a spin lock is held and crypto_alloc_base() may sleep.
> There is no reason to re-allocate the cipher, the state is resetted in
> ->setkey(). This move it to init.
>
> Signed-off-by: Sebastian Andrzej Siewior
NAK. Functionally its, ok. But in the conversion, you set ctx->tfm to NULL, and
then return PTR_ERR(ctx->tfm), which is going to return success erroneously
(NULL == 0 == success).. Grab the value of tfm before setting it to null and
return that instead, please
Regards
Neil
> ---
> crypto/ansi_cprng.c | 18 +++---
> 1 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c
> index ff00b58..259d2de 100644
> --- a/crypto/ansi_cprng.c
> +++ b/crypto/ansi_cprng.c
> @@ -307,17 +307,6 @@ static int reset_prng_context(struct prng_context *ctx,
> memset(ctx->rand_data, 0, DEFAULT_BLK_SZ);
> memset(ctx->last_rand_data, 0, DEFAULT_BLK_SZ);
>
> - if (ctx->tfm)
> - crypto_free_cipher(ctx->tfm);
> -
> - ctx->tfm = crypto_alloc_cipher("aes", 0, 0);
> - if (IS_ERR(ctx->tfm)) {
> - dbgprint(KERN_CRIT "Failed to alloc tfm for context %p\n",
> - ctx);
> - ctx->tfm = NULL;
> - goto out;
> - }
> -
> ctx->rand_data_valid = DEFAULT_BLK_SZ;
>
> ret = crypto_cipher_setkey(ctx->tfm, prng_key, klen);
> @@ -342,6 +331,13 @@ static int cprng_init(struct crypto_tfm *tfm)
> struct prng_context *ctx = crypto_tfm_ctx(tfm);
>
> spin_lock_init(&ctx->prng_lock);
> + ctx->tfm = crypto_alloc_cipher("aes", 0, 0);
> + if (IS_ERR(ctx->tfm)) {
> + dbgprint(KERN_CRIT "Failed to alloc tfm for context %p\n",
> + ctx);
> + ctx->tfm = NULL;
> + return PTR_ERR(ctx->tfm);
^
Use after assignment is bad here :)
> + }
>
> if (reset_prng_context(ctx, NULL, DEFAULT_PRNG_KSZ, NULL, NULL) < 0)
> return -EINVAL;
> --
> 1.6.3.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()
On Mon, Jun 29, 2009 at 11:48:21PM +0200, Sebastian Andrzej Siewior wrote: > * Sebastian Andrzej Siewior | 2009-06-29 23:45:08 [+0200]: > > >From: Sebastian Andrzej Siewior > > > >As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads > > Neil, the patches are untested. Could you please verify them? > > Sebastian > Yeah, you'll have to give me a day or two to get to it, but I'll test them Neil -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()
* Sebastian Andrzej Siewior | 2009-06-29 23:45:08 [+0200]: >From: Sebastian Andrzej Siewior > >As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads Neil, the patches are untested. Could you please verify them? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()
From: Sebastian Andrzej Siewior
As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads
to:
|BUG: sleeping function called from invalid context at kernel/rwsem.c:21
|in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe
|INFO: lockdep is turned off.
|Pid: 4926, comm: modprobe Tainted: G M 2.6.31-rc1-22297-g5298976 #24
|Call Trace:
| [] __might_sleep+0xf9/0x101
| [] down_read+0x16/0x68
| [] crypto_alg_lookup+0x16/0x34
| [] crypto_larval_lookup+0x30/0xf9
| [] crypto_alg_mod_lookup+0x1d/0x62
| [] crypto_alloc_base+0x1e/0x64
| [] reset_prng_context+0xab/0x13f
| [] ? __spin_lock_init+0x27/0x51
| [] cprng_init+0x2a/0x42
| [] __crypto_alloc_tfm+0xfa/0x128
| [] crypto_alloc_base+0x33/0x64
| [] alg_test_cprng+0x30/0x1f4
| [] alg_test+0x12f/0x19f
| [] ? __alloc_pages_nodemask+0x14d/0x481
| [] do_test+0xf9d/0x163f [tcrypt]
| [] do_test+0x3a1/0x163f [tcrypt]
| [] tcrypt_mod_init+0x35/0x7c [tcrypt]
| [] _stext+0x54/0x12c
| [] ? tcrypt_mod_init+0x0/0x7c [tcrypt]
| [] ? up_read+0x16/0x2b
| [] ? __blocking_notifier_call_chain+0x40/0x4c
| [] sys_init_module+0xa9/0x1bf
| [] sysenter_do_call+0x12/0x32
because a spin lock is held and crypto_alloc_base() may sleep.
There is no reason to re-allocate the cipher, the state is resetted in
->setkey(). This move it to init.
Signed-off-by: Sebastian Andrzej Siewior
---
crypto/ansi_cprng.c | 18 +++---
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c
index ff00b58..259d2de 100644
--- a/crypto/ansi_cprng.c
+++ b/crypto/ansi_cprng.c
@@ -307,17 +307,6 @@ static int reset_prng_context(struct prng_context *ctx,
memset(ctx->rand_data, 0, DEFAULT_BLK_SZ);
memset(ctx->last_rand_data, 0, DEFAULT_BLK_SZ);
- if (ctx->tfm)
- crypto_free_cipher(ctx->tfm);
-
- ctx->tfm = crypto_alloc_cipher("aes", 0, 0);
- if (IS_ERR(ctx->tfm)) {
- dbgprint(KERN_CRIT "Failed to alloc tfm for context %p\n",
- ctx);
- ctx->tfm = NULL;
- goto out;
- }
-
ctx->rand_data_valid = DEFAULT_BLK_SZ;
ret = crypto_cipher_setkey(ctx->tfm, prng_key, klen);
@@ -342,6 +331,13 @@ static int cprng_init(struct crypto_tfm *tfm)
struct prng_context *ctx = crypto_tfm_ctx(tfm);
spin_lock_init(&ctx->prng_lock);
+ ctx->tfm = crypto_alloc_cipher("aes", 0, 0);
+ if (IS_ERR(ctx->tfm)) {
+ dbgprint(KERN_CRIT "Failed to alloc tfm for context %p\n",
+ ctx);
+ ctx->tfm = NULL;
+ return PTR_ERR(ctx->tfm);
+ }
if (reset_prng_context(ctx, NULL, DEFAULT_PRNG_KSZ, NULL, NULL) < 0)
return -EINVAL;
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
