Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
On Fri, Mar 09, 2018 at 06:35:35AM -0800, Joe Perches wrote: > > and likely, as this is a global name, it should > be something like crypto_hash_alg_name crypto_ is not a good prefix here. Perhaps crypto_bcm_. Thanks, -- Email: Herbert XuHome Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
On 27.02.2018 23:01, Hernán Gonzalez wrote: > Note: This is compile only tested. > No gain from this except some self-documenting. > > Signed-off-by: Hernán Gonzalez> --- > drivers/crypto/bcm/spu.c | 5 +++-- > drivers/crypto/bcm/spu.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c > index efaf3cf..c7bb79e 100644 > --- a/drivers/crypto/bcm/spu.c > +++ b/drivers/crypto/bcm/spu.c > @@ -23,8 +23,9 @@ > #include "cipher.h" > > /* This array is based on the hash algo type supported in spu.h */ > -char *hash_alg_name[] = { "None", "md5", "sha1", "sha224", "sha256", "aes", ^^^ 'aes' is not hash, so either remove 'aes' or change array name to crypto_alg_name Or maybe I am missing something, or is it hardcoded in silicon ? > - "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", "sha3_512" }; > +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224", > + "sha256", "aes", "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", > + "sha3_512" }; > > /* Assumes SPU-M messages are in big endian */ > void spum_dump_msg_hdr(u8 *buf, unsigned int buf_len) > diff --git a/drivers/crypto/bcm/spu.h b/drivers/crypto/bcm/spu.h > index f252367..71cf6b5 100644 > --- a/drivers/crypto/bcm/spu.h > +++ b/drivers/crypto/bcm/spu.h > @@ -111,7 +111,7 @@ enum aead_type { > AEAD_TYPE_LAST > }; > > -extern char *hash_alg_name[HASH_ALG_LAST]; > +extern const char * const hash_alg_name[HASH_ALG_LAST]; > > struct spu_request_opts { > bool is_inbound; > -- Best regards, Kamil Konieczny Samsung R Institute Poland
Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
On Fri, 2018-03-09 at 22:29 +0800, Herbert Xu wrote: > On Tue, Feb 27, 2018 at 07:01:27PM -0300, Hernán Gonzalez wrote: > > Note: This is compile only tested. > > No gain from this except some self-documenting. [] > > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c [] > > @@ -23,8 +23,9 @@ > > #include "cipher.h" > > > > /* This array is based on the hash algo type supported in spu.h */ > > -char *hash_alg_name[] = { "None", "md5", "sha1", "sha224", "sha256", "aes", > > - "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", "sha3_512" }; > > +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224", > > Please make that > > const char *const > > Ditto with patch 4. > > Thanks, and likely, as this is a global name, it should be something like crypto_hash_alg_name
Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
On Tue, Feb 27, 2018 at 07:01:27PM -0300, Hernán Gonzalez wrote: > Note: This is compile only tested. > No gain from this except some self-documenting. > > Signed-off-by: Hernán Gonzalez> --- > drivers/crypto/bcm/spu.c | 5 +++-- > drivers/crypto/bcm/spu.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c > index efaf3cf..c7bb79e 100644 > --- a/drivers/crypto/bcm/spu.c > +++ b/drivers/crypto/bcm/spu.c > @@ -23,8 +23,9 @@ > #include "cipher.h" > > /* This array is based on the hash algo type supported in spu.h */ > -char *hash_alg_name[] = { "None", "md5", "sha1", "sha224", "sha256", "aes", > - "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", "sha3_512" }; > +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224", Please make that const char *const Ditto with patch 4. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
Note: This is compile only tested. No gain from this except some self-documenting. Signed-off-by: Hernán Gonzalez--- drivers/crypto/bcm/spu.c | 5 +++-- drivers/crypto/bcm/spu.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c index efaf3cf..c7bb79e 100644 --- a/drivers/crypto/bcm/spu.c +++ b/drivers/crypto/bcm/spu.c @@ -23,8 +23,9 @@ #include "cipher.h" /* This array is based on the hash algo type supported in spu.h */ -char *hash_alg_name[] = { "None", "md5", "sha1", "sha224", "sha256", "aes", - "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", "sha3_512" }; +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224", + "sha256", "aes", "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", + "sha3_512" }; /* Assumes SPU-M messages are in big endian */ void spum_dump_msg_hdr(u8 *buf, unsigned int buf_len) diff --git a/drivers/crypto/bcm/spu.h b/drivers/crypto/bcm/spu.h index f252367..71cf6b5 100644 --- a/drivers/crypto/bcm/spu.h +++ b/drivers/crypto/bcm/spu.h @@ -111,7 +111,7 @@ enum aead_type { AEAD_TYPE_LAST }; -extern char *hash_alg_name[HASH_ALG_LAST]; +extern const char * const hash_alg_name[HASH_ALG_LAST]; struct spu_request_opts { bool is_inbound; -- 2.7.4